libxl: add missing action in DEFINE_DEVICE_ADD
authorWei Liu <wei.liu2@citrix.com>
Wed, 12 Nov 2014 10:39:31 +0000 (10:39 +0000)
committerIan Campbell <ian.campbell@citrix.com>
Fri, 14 Nov 2014 10:42:57 +0000 (10:42 +0000)
... otherwise when device add operation fails, the error message looks
like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null)
device", which is not very helpful.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
tools/libxl/libxl.c

index f7961f608a864a7d287477bb49cf694b8bc3e999..de23fec44a438431529f84bb744c26735517d075 100644 (file)
@@ -4164,6 +4164,7 @@ DEFINE_DEVICE_REMOVE(vtpm, destroy, 1)
                                                                         \
         GCNEW(aodev);                                                   \
         libxl__prepare_ao_device(ao, aodev);                            \
+        aodev->action = LIBXL__DEVICE_ACTION_ADD;                       \
         aodev->callback = device_addrm_aocomplete;                      \
         aodev->update_json = true;                                      \
         libxl__device_##type##_add(egc, domid, type, aodev);            \