x86/HVM: fix AMD ECS handling for Fam10
authorJan Beulich <jbeulich@suse.com>
Thu, 9 Apr 2020 08:16:27 +0000 (10:16 +0200)
committerJan Beulich <jbeulich@suse.com>
Thu, 9 Apr 2020 08:16:27 +0000 (10:16 +0200)
The involved comparison was, very likely inadvertently, converted from
>= to > when making changes unrelated to the actual family range.

Fixes: 9841eb71ea87 ("x86/cpuid: Drop a guests cached x86 family and model information")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Paul Durrant <paul@xen.org>
master commit: 5d515b1c296ebad6889748ea1e49e063453216a3
master date: 2020-04-01 12:28:30 +0200

xen/arch/x86/hvm/ioreq.c

index f95fb18c1f50cc5b3fec86171ecc8b7a3adb1996..3698f07f29fa6e0f087405870236082284b68afd 100644 (file)
@@ -1333,7 +1333,7 @@ struct hvm_ioreq_server *hvm_select_ioreq_server(struct domain *d,
         if ( CF8_ADDR_HI(cf8) &&
              d->arch.cpuid->x86_vendor == X86_VENDOR_AMD &&
              (x86_fam = get_cpu_family(
-                 d->arch.cpuid->basic.raw_fms, NULL, NULL)) > 0x10 &&
+                 d->arch.cpuid->basic.raw_fms, NULL, NULL)) >= 0x10 &&
              x86_fam < 0x17 )
         {
             uint64_t msr_val;