libxl: fix cirrus vga video memory setting with upstream qemu
authorFabio Fantoni <fabio.fantoni@m2r.biz>
Fri, 9 May 2014 12:55:46 +0000 (14:55 +0200)
committerIan Campbell <ian.campbell@citrix.com>
Thu, 15 May 2014 15:01:23 +0000 (16:01 +0100)
The Cirrus VGA videoram setting used with upstream qemu is wrong. Qemu
silently ignores the incorrect setting.

Switch to the correct vgamem_mb property which was added in qemu 1.3.

Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
Reviewed-by: Don Slutz <dslutz@verizon.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
[ ijc -- updated changelog. ]

tools/libxl/libxl_dm.c

index 8abed7bff206ada6219373d43a204832140946e5..90f19b796d8cadd6eb2ec612c9b259288bb5de64 100644 (file)
@@ -508,9 +508,8 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
             flexarray_append_pair(dm_args, "-device", "VGA");
             break;
         case LIBXL_VGA_INTERFACE_TYPE_CIRRUS:
-            flexarray_append_pair(dm_args, "-device", "cirrus-vga");
-            flexarray_append_pair(dm_args, "-global",
-                GCSPRINTF("vga.vram_size_mb=%d",
+            flexarray_append_pair(dm_args, "-device",
+                GCSPRINTF("cirrus-vga,vgamem_mb=%d",
                 libxl__sizekb_to_mb(b_info->video_memkb)));
             break;
         case LIBXL_VGA_INTERFACE_TYPE_NONE: