places sidebar: Fix rows getting 'lost' when dnd fails
authorMatthias Clasen <mclasen@redhat.com>
Wed, 8 Jul 2015 03:16:09 +0000 (23:16 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Wed, 8 Jul 2015 10:10:00 +0000 (06:10 -0400)
There was some code that lead to the places sidebar loosing track
of the row being dragged if a motion event came in between letting
go of the button and the drag snap-back animation ending. This would
cause us to not show the row again, giving the appearance that it
was 'lost'.

https://bugzilla.gnome.org/show_bug.cgi?id=751448

gtk/gtkplacessidebar.c

index a591ea5da31f4f452bd80ccceb9ef854443ae80e..322b7f154269514d32e2519d2cd8490289120baf 100644 (file)
@@ -1456,11 +1456,7 @@ on_motion_notify_event (GtkWidget      *widget,
     return FALSE;
 
   if (!(event->state & GDK_BUTTON1_MASK))
-    {
-      sidebar->drag_row = NULL;
-
-      return FALSE;
-    }
+    return FALSE;
 
   if (gtk_drag_check_threshold (widget,
                                 sidebar->drag_root_x, sidebar->drag_root_y,