projects
/
gtk4.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
25f8793
)
gtkselectioninputstream-x11: Do not add an extra reference to the returned stream
author
Marco Trevisan (Treviño)
<mail@3v1n0.net>
Tue, 30 May 2023 15:50:56 +0000
(17:50 +0200)
committer
Matthias Clasen
<mclasen@redhat.com>
Mon, 5 Jun 2023 12:01:40 +0000
(08:01 -0400)
We create a new stream during gdk_x11_selection_input_stream_new_async()
then such stream is referenced when passed to the task via
g_task_return_pointer(), so there's no need to reference it again before
returning it, or we'd end up leaking.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/4892
gdk/x11/gdkselectioninputstream-x11.c
patch
|
blob
|
history
diff --git
a/gdk/x11/gdkselectioninputstream-x11.c
b/gdk/x11/gdkselectioninputstream-x11.c
index 0f4ce37d4c3c03452fc4d9d5baf760f828e7b256..5d480cf6abf5a50cd1d0b8acf7a96e967966b07d 100644
(file)
--- a/
gdk/x11/gdkselectioninputstream-x11.c
+++ b/
gdk/x11/gdkselectioninputstream-x11.c
@@
-577,7
+577,6
@@
gdk_x11_selection_input_stream_new_finish (GAsyncResult *result,
*type = priv->type;
if (format)
*format = priv->format;
- g_object_ref (stream);
}
return G_INPUT_STREAM (stream);