viewport: Set scroll-to-focus to TRUE by default
authorMaximiliano Sandoval R <msandova@gnome.org>
Sat, 8 Jan 2022 11:56:43 +0000 (12:56 +0100)
committerMaximiliano Sandoval R <msandova@gnome.org>
Tue, 15 Feb 2022 15:29:08 +0000 (16:29 +0100)
In GTK 3 this was the default.

gtk/gtkviewport.c

index 7116592544595eefa9c5a71ac4709918e688bf17..ccac4fbf90010a8b943f233b2c9a7919b546eab5 100644 (file)
@@ -312,13 +312,17 @@ gtk_viewport_class_init (GtkViewportClass *class)
    * GtkViewport:scroll-to-focus: (attributes org.gtk.Property.get=gtk_viewport_get_scroll_to_focus org.gtk.Property.set=gtk_viewport_set_scroll_to_focus)
    *
    * Whether to scroll when the focus changes.
+   *
+   * Before 4.6.2, this property was mistakenly defaulting to FALSE, so if your
+   * code needs to work with older versions, consider setting it explicitly to
+   * TRUE.
    */
   g_object_class_install_property (gobject_class,
                                    PROP_SCROLL_TO_FOCUS,
                                    g_param_spec_boolean ("scroll-to-focus",
                                                          P_("Scroll to focus"),
                                                          P_("Whether to scroll when the focus changes"),
-                                                         FALSE,
+                                                         TRUE,
                                                          GTK_PARAM_READWRITE|G_PARAM_EXPLICIT_NOTIFY));
 
   /**
@@ -430,6 +434,8 @@ gtk_viewport_init (GtkViewport *viewport)
 
   viewport_set_adjustment (viewport, GTK_ORIENTATION_HORIZONTAL, NULL);
   viewport_set_adjustment (viewport, GTK_ORIENTATION_VERTICAL, NULL);
+
+  viewport->scroll_to_focus = TRUE;
 }
 
 /**