ostree-repo-pull: Take correct out path on error
authorPhilip Withnall <pwithnall@endlessos.org>
Tue, 8 Mar 2022 15:36:27 +0000 (15:36 +0000)
committerPhilip Withnall <pwithnall@endlessos.org>
Tue, 8 Mar 2022 15:36:27 +0000 (15:36 +0000)
Like every other error return path in this function, jump to the `out`
label on error here. Returning directly will cause leaks.

Spotted by reading the code, not actually necessarily encountered in the
wild.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
src/libostree/ostree-repo-pull.c

index e8918cf63b12a03e90e2f3cb279a79a26951d70d..1d61faaf005eb930044c807df8f74a80fb98b9b5 100644 (file)
@@ -4020,7 +4020,7 @@ ostree_repo_pull_with_options (OstreeRepo             *self,
                                      &pull_data->signapi_commit_verifiers,
                                      &pull_data->signapi_summary_verifiers,
                                      error))
-        return FALSE;
+        goto out;
     }
 
   pull_data->phase = OSTREE_PULL_PHASE_FETCHING_REFS;