placessidebar: Do not set as a "track motion" DnD site
authorCarlos Garnacho <carlosg@gnome.org>
Wed, 1 Jul 2015 16:50:22 +0000 (18:50 +0200)
committerCarlos Garnacho <carlosg@gnome.org>
Wed, 1 Jul 2015 17:37:42 +0000 (19:37 +0200)
It has the unintended effect of picking the suggested action from the
context, which conflicts with the (possibly 0) status we set on our
::drag-motion handler.

Given this widget is not interested in listening to DnD from every
possible target, it is safe to just disable it.

gtk/gtkplacessidebar.c

index 1344e425f7701163a2d5a8d98bf13aa0d8d349fa..0a19fa830f6a3025bf0e9a81c51d45239740ca82 100644 (file)
@@ -3766,8 +3766,6 @@ gtk_places_sidebar_init (GtkPlacesSidebar *sidebar)
   sidebar->source_targets = gtk_target_list_new (dnd_source_targets, G_N_ELEMENTS (dnd_source_targets));
   gtk_target_list_add_text_targets (sidebar->source_targets, 0);
 
-  gtk_drag_dest_set_track_motion (GTK_WIDGET (sidebar->list_box), TRUE);
-
   g_signal_connect (sidebar->list_box, "motion-notify-event",
                     G_CALLBACK (on_motion_notify_event), sidebar);
   g_signal_connect (sidebar->list_box, "drag-begin",