build/maint.mk: Comment out setting of LC_ALL

This triggers obscure bugs; really we shouldn't be overriding
the global locale here.  In practice, production build systems
will be using fixed locales anyways.

Also, we only use a small subset of this file (`make syntax-check`),
which appears to work OK without this.

I will probably try to work out where to submit this as at
least an issue report for upstream gnulib.

Closes: https://github.com/ostreedev/ostree/issues/1101
Closes: #1107
Approved by: heftig

diff --git a/maint.mk b/maint.mk
index ff231c7d802f66f53cb9a1c8eb6bb10d527a8497..09ab24010cf08a808b9bc3ba17c65d454eba81f9 100644 (file)
--- a/maint.mk
+++ b/maint.mk
@@ -105,7 +105,8 @@ my_distdir = $(PACKAGE)-$(VERSION)
 
 # Prevent programs like 'sort' from considering distinct strings to be equal.
 # Doing it here saves us from having to set LC_ALL elsewhere in this file.
-export LC_ALL = C
+# NOTE: commented out for https://github.com/ostreedev/ostree/issues/1101
+# export LC_ALL = C
 
 ## --------------- ##
 ## Sanity checks.  ##