ShareDialog: Keep default server permissions by default (#4152)
authorOlivier Goffart <ogoffart@woboq.com>
Thu, 19 Nov 2015 09:38:51 +0000 (10:38 +0100)
committerOlivier Goffart <ogoffart@woboq.com>
Thu, 19 Nov 2015 09:49:39 +0000 (10:49 +0100)
src/gui/ocssharejob.cpp
src/gui/share.h
src/gui/shareusergroupwidget.cpp

index 93c0c1d144b46482db372d9807c3453183c3e605..256dfd7845303bbb2b8c9f283849906dd9a8cc81 100644 (file)
@@ -122,7 +122,9 @@ void OcsShareJob::createShare(const QString& path,
     addParam(QString::fromLatin1("path"), path);
     addParam(QString::fromLatin1("shareType"), QString::number(shareType));
     addParam(QString::fromLatin1("shareWith"), shareWith);
-    addParam(QString::fromLatin1("permissions"), QString::number(permissions));
+    if (!(permissions & Share::PermissionDefault)) {
+        addParam(QString::fromLatin1("permissions"), QString::number(permissions));
+    }
 
     start();
 }
index 99e3e76e8df528aa659516d874beb7535dd2fc72..8ac7fae5dd2f38dd2a0d3cd498cafe772ce5101a 100644 (file)
@@ -51,7 +51,8 @@ public:
         PermissionUpdate =  2,
         PermissionCreate =  4,
         PermissionDelete =  8,
-        PermissionShare  = 16
+        PermissionShare  = 16,
+        PermissionDefault = 1 << 30
     };
     Q_DECLARE_FLAGS(Permissions, Permission)
 
@@ -62,7 +63,7 @@ public:
                    const QString& id,
                    const QString& path,
                    const ShareType shareType,
-                   const Permissions permissions,
+                   const Permissions permissions = PermissionDefault,
                    const QSharedPointer<Sharee> shareWith = QSharedPointer<Sharee>(NULL));
 
     /*
index 8ff7c76238a0aa602c8c3db324412b2c72de9add..ffc5bfbf1726789f20e305e6489334d70c454a5d 100644 (file)
@@ -170,10 +170,8 @@ void ShareUserGroupWidget::slotCompleterActivated(const QModelIndex & index)
         return;
     }
 
-    _manager->createShare(_sharePath,
-                          (Share::ShareType)sharee->type(),
-                          sharee->shareWith(),
-                          Share::PermissionRead);
+    _manager->createShare(_sharePath, Share::ShareType(sharee->type()),
+                          sharee->shareWith(), Share::PermissionDefault);
 
     _ui->shareeLineEdit->setText(QString());
 }