Remove unnecessary local file operations in FileProviderExt

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

diff --git a/shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderEnumerator.swift b/shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderEnumerator.swift
index c270c65ddf7a39b8598f5ce19b9d6ea2cd19be6d..58ef390537d628e388f3a1bdd46b73630fe1c8b5 100644 (file)
--- a/shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderEnumerator.swift
+++ b/shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderEnumerator.swift
@@ -294,7 +294,7 @@ class FileProviderEnumerator: NSObject, NSFileProviderEnumerator {
 
     // MARK: - Helper methods
 
-    private static func completeEnumerationObserver(_ observer: NSFileProviderEnumerationObserver, ncKit: NextcloudKit, numPage: Int, itemMetadatas: [NextcloudItemMetadataTable], createLocalFileOrDirectory: Bool = true) {
+    private static func completeEnumerationObserver(_ observer: NSFileProviderEnumerationObserver, ncKit: NextcloudKit, numPage: Int, itemMetadatas: [NextcloudItemMetadataTable]) {
 
         var items: [NSFileProviderItem] = []
 
@@ -304,10 +304,6 @@ class FileProviderEnumerator: NSObject, NSFileProviderEnumerator {
                 continue
             }
 
-            if createLocalFileOrDirectory {
-                createFileOrDirectoryLocally(metadata: itemMetadata)
-            }
-
             if let parentItemIdentifier = NextcloudFilesDatabaseManager.shared.parentItemIdentifierFromMetadata(itemMetadata) {
                 let item = FileProviderItem(metadata: itemMetadata, parentItemIdentifier: parentItemIdentifier, ncKit: ncKit)
                 Logger.enumeration.debug("Will enumerate item with ocId: \(itemMetadata.ocId) and name: \(itemMetadata.fileName, privacy: OSLogPrivacy.auto(mask: .hash))")

diff --git a/shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/LocalFilesUtils.swift b/shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/LocalFilesUtils.swift
index 470e23219fe38dd30ac4b3cee508265717da20cd..0a9d1eaa497fc2847039ac7e4a5e39e47617a08d 100644 (file)
--- a/shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/LocalFilesUtils.swift
+++ b/shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/LocalFilesUtils.swift
@@ -50,16 +50,6 @@ func pathForFileProviderExtFiles() -> URL? {
     return folderPathUrl
 }
 
-@discardableResult func localPathForNCDirectory(directoryMetadata: NextcloudDirectoryMetadataTable) throws -> URL {
-    let ocId = directoryMetadata.ocId
-    return try localPathForNCDirectory(ocId: ocId)
-}
-
-@discardableResult func localPathForNCDirectory(itemMetadata: NextcloudItemMetadataTable) throws -> URL {
-    let ocId = itemMetadata.ocId
-    return try localPathForNCDirectory(ocId: ocId)
-}
-
 @discardableResult func localPathForNCFile(ocId: String, fileNameView: String) throws -> URL {
     let fileFolderPathUrl = try localPathForNCDirectory(ocId: ocId)
     let filePathUrl = fileFolderPathUrl.appendingPathComponent(fileNameView)
@@ -71,21 +61,3 @@ func pathForFileProviderExtFiles() -> URL? {
 
     return filePathUrl
 }
-
-@discardableResult func localPathForNCFile(itemMetadata: NextcloudItemMetadataTable) throws -> URL {
-    let ocId = itemMetadata.ocId
-    let fileNameView = itemMetadata.fileNameView
-    return try localPathForNCFile(ocId: ocId, fileNameView: fileNameView)
-}
-
-func createFileOrDirectoryLocally(metadata: NextcloudItemMetadataTable) {
-    do {
-        if metadata.directory {
-            try localPathForNCDirectory(ocId: metadata.ocId)
-        } else {
-            try localPathForNCFile(itemMetadata: metadata)
-        }
-    } catch let error {
-        Logger.enumeration.error("Could not create NC file or directory locally, received error: \(error, privacy: .public)")
-    }
-}