SyncEngine: Add unittest for SyncFileItem properties #5855

Checks instruction, direction, size, modtime for three common cases.

diff --git a/test/testsyncengine.cpp b/test/testsyncengine.cpp
index 1f48931da1e8f2cf26242a2196983ee1ae3b12b2..1a9ac42d11435cc3b024558b4970dbed7afc4d66 100644 (file)
--- a/test/testsyncengine.cpp
+++ b/test/testsyncengine.cpp
@@ -385,6 +385,81 @@ private slots:
         QVERIFY(fakeFolder.syncOnce());
         QCOMPARE(nGET, 1);
     }
+
+    /**
+     * Checks whether SyncFileItems have the expected properties before start
+     * of propagation.
+     */
+    void testSyncFileItemProperties()
+    {
+        FakeFolder fakeFolder{ FileInfo::A12_B12_C12_S12() };
+
+        auto initialMtime = fakeFolder.currentLocalState().find("A/a1")->lastModified;
+        auto changedMtime = QDateTime::currentDateTime().addDays(-4);
+        auto changedMtime2 = QDateTime::currentDateTime().addDays(-3);
+
+        // Base mtime with no ms content (filesystem is seconds only)
+        initialMtime.setMSecsSinceEpoch(initialMtime.toMSecsSinceEpoch() / 1000 * 1000);
+        changedMtime.setMSecsSinceEpoch(changedMtime.toMSecsSinceEpoch() / 1000 * 1000);
+        changedMtime2.setMSecsSinceEpoch(changedMtime2.toMSecsSinceEpoch() / 1000 * 1000);
+
+        // upload a
+        fakeFolder.localModifier().appendByte("A/a1");
+        fakeFolder.localModifier().setModTime("A/a1", changedMtime);
+        // download b
+        fakeFolder.remoteModifier().appendByte("B/b1");
+        fakeFolder.remoteModifier().setModTime("B/b1", changedMtime);
+        // conflict c
+        fakeFolder.localModifier().appendByte("C/c1");
+        fakeFolder.localModifier().appendByte("C/c1");
+        fakeFolder.localModifier().setModTime("C/c1", changedMtime);
+        fakeFolder.remoteModifier().appendByte("C/c1");
+        fakeFolder.remoteModifier().setModTime("C/c1", changedMtime2);
+
+        connect(&fakeFolder.syncEngine(), &SyncEngine::aboutToPropagate, [&](SyncFileItemVector &items) {
+            SyncFileItemPtr a1, b1, c1;
+            for (auto &item : items) {
+                if (item->_file == "A/a1")
+                    a1 = item;
+                if (item->_file == "B/b1")
+                    b1 = item;
+                if (item->_file == "C/c1")
+                    c1 = item;
+            }
+
+            // a1: should have local size and modtime
+            QVERIFY(a1);
+            QCOMPARE(a1->_instruction, CSYNC_INSTRUCTION_SYNC);
+            QCOMPARE(a1->_direction, SyncFileItem::Up);
+
+            // NOTE: This is currently a bug! #5855
+            //QCOMPARE(a1->_size, quint64(5));
+
+            QCOMPARE(Utility::qDateTimeFromTime_t(a1->_modtime), changedMtime);
+            QCOMPARE(a1->log._other_size, quint64(4));
+            QCOMPARE(Utility::qDateTimeFromTime_t(a1->log._other_modtime), initialMtime);
+
+            // b2: should have remote size and modtime
+            QVERIFY(b1);
+            QCOMPARE(b1->_instruction, CSYNC_INSTRUCTION_SYNC);
+            QCOMPARE(b1->_direction, SyncFileItem::Down);
+            QCOMPARE(b1->_size, quint64(17));
+            QCOMPARE(Utility::qDateTimeFromTime_t(b1->_modtime), changedMtime);
+            QCOMPARE(b1->log._other_size, quint64(16));
+            QCOMPARE(Utility::qDateTimeFromTime_t(b1->log._other_modtime), initialMtime);
+
+            // c1: conflicts are downloads, so remote size and modtime
+            QVERIFY(c1);
+            QCOMPARE(c1->_instruction, CSYNC_INSTRUCTION_CONFLICT);
+            QCOMPARE(c1->_direction, SyncFileItem::None);
+            QCOMPARE(c1->_size, quint64(25));
+            QCOMPARE(Utility::qDateTimeFromTime_t(c1->_modtime), changedMtime2);
+            QCOMPARE(c1->log._other_size, quint64(26));
+            QCOMPARE(Utility::qDateTimeFromTime_t(c1->log._other_modtime), changedMtime);
+        });
+
+        QVERIFY(fakeFolder.syncOnce());
+    }
 };
 
 QTEST_GUILESS_MAIN(TestSyncEngine)