x86: ensure invalidate_icache() definition is visible only when !__ASSEMBLY__
authorPunit Agrawal <punit.agrawal@arm.com>
Wed, 7 Jun 2017 10:34:20 +0000 (12:34 +0200)
committerJan Beulich <jbeulich@suse.com>
Wed, 7 Jun 2017 10:34:20 +0000 (12:34 +0200)
Commit edff605421 introduces an empty invalidate_icache() function in
page.h for x86 but mistakenly places it outside the !__ASSEMBLY__
block. This causes build failure on x86.

Address this by moving the function definition to within the existing
!__ASSEMBLY__ block.

Fixes: edff605421 ("Avoid excess icache flushes in populate_physmap() before domain has been created")
Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
xen/include/asm-x86/page.h

index 9b86d5183a4eb3806c5c9ad5744b6bac38625d06..474b9bde78639d57747c939282ca9ec217014e82 100644 (file)
@@ -371,10 +371,6 @@ perms_strictly_increased(uint32_t old_flags, uint32_t new_flags)
     return ((of | (of ^ nf)) == nf);
 }
 
-#endif /* !__ASSEMBLY__ */
-
-#define PAGE_ALIGN(x) (((x) + PAGE_SIZE - 1) & PAGE_MASK)
-
 static inline void invalidate_icache(void)
 {
 /*
@@ -383,6 +379,10 @@ static inline void invalidate_icache(void)
  */
 }
 
+#endif /* !__ASSEMBLY__ */
+
+#define PAGE_ALIGN(x) (((x) + PAGE_SIZE - 1) & PAGE_MASK)
+
 #endif /* __X86_PAGE_H__ */
 
 /*