Remove ssl options to re-use encryption session for different TCP connections.
authorCamila Ayres <hello@camilasan.com>
Wed, 29 May 2024 17:19:56 +0000 (19:19 +0200)
committerMatthieu Gallien <matthieu_gallien@yahoo.fr>
Mon, 1 Jul 2024 14:35:06 +0000 (16:35 +0200)
One option is said to be possibly breaking some sites: QSsl::SslOptionDisableSessionTickets
It disables the SSL session ticket extension and some servers are not compatible with the extension.

Signed-off-by: Camila Ayres <hello@camilasan.com>
src/libsync/account.cpp

index 9be583b49c8aa816c264ccd4f5dbd2aae11bb8d0..3feb65b46052f5770639443de43e59caa0f9f14e 100644 (file)
@@ -483,11 +483,6 @@ QSslConfiguration Account::getOrCreateSslConfig()
     //  "An internal error number 1060 happened. SSL handshake failed, client certificate was requested: SSL error: sslv3 alert handshake failure"
     QSslConfiguration sslConfig = QSslConfiguration::defaultConfiguration();
 
-    // Try hard to reuse session for different requests
-    sslConfig.setSslOption(QSsl::SslOptionDisableSessionTickets, false);
-    sslConfig.setSslOption(QSsl::SslOptionDisableSessionSharing, false);
-    sslConfig.setSslOption(QSsl::SslOptionDisableSessionPersistence, false);
-
     sslConfig.setOcspStaplingEnabled(Theme::instance()->enableStaplingOCSP());
 
     return sslConfig;