HttpCredentials::slotAuthentication: fix comment
authorOlivier Goffart <ogoffart@woboq.com>
Thu, 7 Jan 2016 13:58:02 +0000 (14:58 +0100)
committerOlivier Goffart <ogoffart@woboq.com>
Thu, 7 Jan 2016 13:58:02 +0000 (14:58 +0100)
The recent revert did no fix the comment

src/libsync/creds/httpcredentials.cpp

index d30c009f07c5b04ce4172e9de0ac3064a20dea78..fbe78fadd733e8b8fa5ac6c30f6bdab4debc1473 100644 (file)
@@ -308,9 +308,8 @@ void HttpCredentials::slotWriteJobDone(QKeychain::Job *job)
 void HttpCredentials::slotAuthentication(QNetworkReply* reply, QAuthenticator* authenticator)
 {
     Q_UNUSED(authenticator)
-    // we cannot use QAuthenticator, because it sends username and passwords with latin1
-    // instead of utf8 encoding. Instead, we send it manually. Thus, if we reach this signal,
-    // those credentials were invalid and we terminate.
+    // Because of issue #4326, we need to set the login and password manually at every requests
+    // Thus, if we reach this signal, those credentials were invalid and we terminate.
     qDebug() << "Stop request: Authentication failed for " << reply->url().toString();
     reply->setProperty(authenticationFailedC, true);
     reply->close();