Make PluginFactory virtual to silent -Wnon-virtual-dtor warning
authorOlivier Goffart <ogoffart@woboq.com>
Wed, 5 Feb 2020 12:04:52 +0000 (13:04 +0100)
committerKevin Ottens <kevin.ottens@nextcloud.com>
Tue, 15 Dec 2020 09:59:06 +0000 (10:59 +0100)
This is not necessary, but it also shouldn't hurt.

src/common/plugin.h

index df17ccc5c5b4fa0b8f72f96119df431dedb73810..3d28f7dd3f76160fc1b24c4cdb577bcc7bddc584 100644 (file)
@@ -26,7 +26,7 @@ namespace OCC {
 class OCSYNC_EXPORT PluginFactory
 {
 public:
-    ~PluginFactory();
+    virtual ~PluginFactory();
     virtual QObject* create(QObject* parent) = 0;
 };