kexec_file: Disable at runtime if securelevel has been set
authorLee, Chun-Yi <joeyli.kernel@gmail.com>
Wed, 5 Apr 2017 16:40:30 +0000 (17:40 +0100)
committerPeter Michael Green <plugwash@raspbian.org>
Wed, 7 Feb 2018 23:32:32 +0000 (23:32 +0000)
When KEXEC_VERIFY_SIG is not enabled, kernel should not loads image
through kexec_file systemcall if securelevel has been set.

This code was showed in Matthew's patch but not in git:
https://lkml.org/lkml/2015/3/13/778

Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Gbp-Pq: Topic features/all/lockdown
Gbp-Pq: Name 0046-kexec_file-Disable-at-runtime-if-securelevel-has-bee.patch

kernel/kexec_file.c

index 9f48f441229720b0e02434b2375b61d9c62b7706..7da87007c2026687ad1cbc1e630b591ddc51a3dc 100644 (file)
@@ -255,6 +255,12 @@ SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd,
        if (!capable(CAP_SYS_BOOT) || kexec_load_disabled)
                return -EPERM;
 
+       /* Don't permit images to be loaded into trusted kernels if we're not
+        * going to verify the signature on them
+        */
+       if (!IS_ENABLED(CONFIG_KEXEC_VERIFY_SIG) && kernel_is_locked_down())
+               return -EPERM;
+
        /* Make sure we have a legal set of flags */
        if (flags != (flags & KEXEC_FILE_FLAGS))
                return -EINVAL;