x86/MCE: merge AMD quirks

merge mce_amd_quirks.c into mce_amd.c

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
Committed-by: Jan Beulich <jbeulich@suse.com>

diff --git a/xen/arch/x86/cpu/mcheck/Makefile b/xen/arch/x86/cpu/mcheck/Makefile
index a5c6c4e0937ece0fd7b32a24d64c6e2378d8f5f9..c8cd5f943f2af5154211b97ec030acbfe0772aaa 100644 (file)
--- a/xen/arch/x86/cpu/mcheck/Makefile
+++ b/xen/arch/x86/cpu/mcheck/Makefile
@@ -8,7 +8,6 @@ obj-y += mctelem.o
 obj-y += mce.o
 obj-y += mce-apei.o
 obj-y += mce_intel.o
-obj-y += mce_amd_quirks.o
 obj-y += non-fatal.o
 obj-y += util.o
 obj-y += vmce.o

diff --git a/xen/arch/x86/cpu/mcheck/mce_amd.c b/xen/arch/x86/cpu/mcheck/mce_amd.c
index 1f124b1b8db4bb396e62432bd412ee7100436bdd..74ee11533344b707ecd9e9627d1d3c9afc2b05eb 100644 (file)
--- a/xen/arch/x86/cpu/mcheck/mce_amd.c
+++ b/xen/arch/x86/cpu/mcheck/mce_amd.c
@@ -21,12 +21,24 @@
 #include <xen/types.h>
 
 #include <asm/msr.h>
+#include <asm/processor.h>
 
 #include "mce.h"
 #include "x86_mca.h"
 #include "mce_amd.h"
 #include "mcaction.h"
 
+#include "mce_quirks.h"
+
+#define ANY -1
+
+static const struct mce_quirkdata mce_amd_quirks[] = {
+    { 0xf /* cpu family */, ANY /* all models */, ANY /* all steppings */,
+      MCEQUIRK_K8_GART },
+    { 0x10 /* cpu family */, ANY /* all models */, ANY /* all steppings */,
+      MCEQUIRK_F10_GART },
+};
+
 /* Error Code Types */
 enum mc_ec_type {
     MC_EC_TLB_TYPE = 0x0010,
@@ -99,6 +111,53 @@ mc_amd_addrcheck(uint64_t status, uint64_t misc, int addrtype)
     return 0;
 }
 
+/* MC quirks */
+enum mcequirk_amd_flags
+mcequirk_lookup_amd_quirkdata(struct cpuinfo_x86 *c)
+{
+    int i;
+
+    BUG_ON(c->x86_vendor != X86_VENDOR_AMD);
+
+    for ( i = 0; i < ARRAY_SIZE(mce_amd_quirks); i++ )
+    {
+        if ( c->x86 != mce_amd_quirks[i].cpu_family )
+            continue;
+        if ( (mce_amd_quirks[i].cpu_model != ANY) &&
+             (mce_amd_quirks[i].cpu_model != c->x86_model) )
+            continue;
+        if ( (mce_amd_quirks[i].cpu_stepping != ANY) &&
+             (mce_amd_quirks[i].cpu_stepping != c->x86_mask) )
+                continue;
+        return mce_amd_quirks[i].quirk;
+    }
+    return 0;
+}
+
+int mcequirk_amd_apply(enum mcequirk_amd_flags flags)
+{
+    uint64_t val;
+
+    switch ( flags )
+    {
+    case MCEQUIRK_K8_GART:
+        /*
+         * Enable error reporting for all errors except for GART
+         * TBL walk error reporting, which trips off incorrectly
+         * with AGP GART & 3ware & Cerberus.
+         */
+        wrmsrl(MSR_IA32_MCx_CTL(4), ~(1ULL << 10));
+        wrmsrl(MSR_IA32_MCx_STATUS(4), 0ULL);
+        break;
+    case MCEQUIRK_F10_GART:
+        if ( rdmsr_safe(MSR_AMD64_MCx_MASK(4), val) == 0 )
+                wrmsr_safe(MSR_AMD64_MCx_MASK(4), val | (1 << 10));
+        break;
+    }
+
+    return 0;
+}
+
 enum mcheck_type
 amd_mcheck_init(struct cpuinfo_x86 *ci)
 {

diff --git a/xen/arch/x86/cpu/mcheck/mce_amd_quirks.c b/xen/arch/x86/cpu/mcheck/mce_amd_quirks.c
deleted file mode 100644 (file)
index d75ac06..0000000
--- a/xen/arch/x86/cpu/mcheck/mce_amd_quirks.c
+++ /dev/null
@@ -1,76 +0,0 @@
-/*
- * MCA quirks for AMD CPUs
- * Copyright (c) 2009 Advanced Micro Devices, Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
- */
-
-#include <asm-x86/msr.h>
-#include <asm-x86/processor.h>
-
-#include "mce_quirks.h"
-
-#define ANY -1
-
-static const struct mce_quirkdata mce_amd_quirks[] = {
-       { 0xf /* cpu family */, ANY /* all models */, ANY /* all steppings */,
-         MCEQUIRK_K8_GART },
-       { 0x10 /* cpu family */, ANY /* all models */, ANY /* all steppings */,
-         MCEQUIRK_F10_GART },
-};
-
-enum mcequirk_amd_flags
-mcequirk_lookup_amd_quirkdata(struct cpuinfo_x86 *c)
-{
-       int i;
-
-       BUG_ON(c->x86_vendor != X86_VENDOR_AMD);
-
-       for (i = 0; i < ARRAY_SIZE(mce_amd_quirks); i++) {
-               if (c->x86 != mce_amd_quirks[i].cpu_family)
-                       continue;
-               if ( (mce_amd_quirks[i].cpu_model != ANY) &&
-                    (mce_amd_quirks[i].cpu_model != c->x86_model) )
-                       continue;
-               if ( (mce_amd_quirks[i].cpu_stepping != ANY) &&
-                    (mce_amd_quirks[i].cpu_stepping != c->x86_mask) )
-                       continue;
-               return mce_amd_quirks[i].quirk;
-       }
-       return 0;
-}
-
-int mcequirk_amd_apply(enum mcequirk_amd_flags flags)
-{
-       u64 val;
-
-       switch (flags) {
-       case MCEQUIRK_K8_GART:
-               /*
-                * Enable error reporting for all errors except for GART
-                * TBL walk error reporting, which trips off incorrectly
-                * with AGP GART & 3ware & Cerberus.
-                */
-               wrmsrl(MSR_IA32_MCx_CTL(4), ~(1ULL << 10));
-               wrmsrl(MSR_IA32_MCx_STATUS(4), 0ULL);
-               break;
-       case MCEQUIRK_F10_GART:
-               if (rdmsr_safe(MSR_AMD64_MCx_MASK(4), val) == 0)
-                       wrmsr_safe(MSR_AMD64_MCx_MASK(4), val | (1 << 10));
-               break;
-       }
-
-       return 0;
-}