x86/EFI: permit setting variable with non-zero attributes
authorJan Beulich <jbeulich@suse.com>
Wed, 27 Mar 2013 07:46:28 +0000 (08:46 +0100)
committerJan Beulich <jbeulich@suse.com>
Wed, 27 Mar 2013 07:46:28 +0000 (08:46 +0100)
This must have been a copy-and-paste mistake - get_variable uses
op->misc as output only, and wants to make sure it's zero for future
extensibility. For set_variable, this is an input though, and hence
the check is wrong.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
xen/arch/x86/efi/runtime.c

index 73aa15eb9a4902ff85e02ed91c25ae809ca5bb9a..aafdfebdd848b1ee6af9e980bd3c151133374c06 100644 (file)
@@ -398,9 +398,6 @@ int efi_runtime_call(struct xenpf_efi_runtime_call *op)
         long len;
         unsigned char *data;
 
-        if ( op->misc )
-            return -EINVAL;
-
         len = gwstrlen(guest_handle_cast(op->u.set_variable.name, CHAR16));
         if ( len < 0 )
             return len;