Shiboken: Fix the oldest shiboken bug ever which shows up on Python 3.11

b7df2f1c0 "Fix signal initializer.", 18. May 2010 at 00:55

There was a `PySequence_Check` in the evaluation of some signature
function parameter processing, which should have been `PyTuple_Check`.

Since the new PyEnums are also sequences, the new optimization in
Python 3.11 changed the parameter handling in a correct way and
replaced the argument tuple by a direct single argument of an enum
type. And that is also a sequence ...

There are probably still dormant issues like this in the codebase
which gives reason to submit a task that checks all Python interface
functions for correctness.

Change-Id: I45996a0458c3e60795d2eb802eb98f7dd3678d92
Pick-to: 6.3
Task-number: PYSIDE-1735
Task-number: PYSIDE-1987
Fixes: PYSIDE-1988
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
(cherry picked from commit 2720e01f21f3771cb755ef183b8160f691bdb575)

Gbp-Pq: Name Shiboken-Fix-the-oldest-shiboken-bug-ever.patch

diff --git a/sources/pyside2/libpyside/pysidesignal.cpp b/sources/pyside2/libpyside/pysidesignal.cpp
index ce89a9d10fdcaecbb6ef55c1f8ebd2eebfd952f6..71fc0e3fdc0fce7ea0d1a206868205a88c56910e 100644 (file)
--- a/sources/pyside2/libpyside/pysidesignal.cpp
+++ b/sources/pyside2/libpyside/pysidesignal.cpp
@@ -725,7 +725,7 @@ static QByteArray buildSignature(const QByteArray &name, const QByteArray &signa
 
 static QByteArray parseSignature(PyObject *args)
 {
-    if (args && (Shiboken::String::check(args) || !PySequence_Check(args)))
+    if (args && (Shiboken::String::check(args) || !PyTuple_Check(args)))
         return getTypeName(args);
 
     QByteArray signature;