closing

diff --git a/CHANGELOG b/CHANGELOG
index 14048bc3963d10fde13e46da0f89902cded6a781..19433049bd2d370e83d82b49e8eb19a01125c4af 100644 (file)
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -15,7 +15,8 @@ git-annex (8.20210622) UNRELEASED; urgency=medium
     reason.
   * Fixed bug that interrupting git-annex repair (or assistant) while
     it was fixing repository corruption would lose objects that were
-    contained in pack files.
+    contained in pack files. Also the assistant might sometimes have
+    crashed with the same result.
   * repair: Fix reversion in version 8.20200522 that prevented fetching
     missing objects from remotes.
 

diff --git a/doc/bugs/Git_repos_corrupt_themselves.mdwn b/doc/bugs/Git_repos_corrupt_themselves.mdwn
index 38376a81305c14521d4a98f56dfb864d824a38df..9964c48545d2999514369e20719da13b5cc10b89 100644 (file)
--- a/doc/bugs/Git_repos_corrupt_themselves.mdwn
+++ b/doc/bugs/Git_repos_corrupt_themselves.mdwn
@@ -104,3 +104,5 @@ Git fsck spat out a huge list of broken blobs and trees.
 ### Have you had any luck using git-annex before? (Sometimes we get tired of reading bug reports all day and a lil' positive end note does wonders)
 
 There are a surprising amount of weird bugs and quirks like these but it's such an amazing tool, there's nothing like it.
+
+> [[fixed|done]] --[[Joey]]

diff --git a/doc/bugs/Git_repos_corrupt_themselves/comment_18_238bbbcabd626c33acc14f930a7d536c._comment b/doc/bugs/Git_repos_corrupt_themselves/comment_18_238bbbcabd626c33acc14f930a7d536c._comment
new file mode 100644 (file)
index 0000000..4081cb9
--- /dev/null
+++ b/doc/bugs/Git_repos_corrupt_themselves/comment_18_238bbbcabd626c33acc14f930a7d536c._comment
@@ -0,0 +1,17 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 18"""
+ date="2021-06-30T15:36:39Z"
+ content="""
+If the assistant crashed in the middle of a repair that confirms my
+analysis, and my fix will avoid both the data loss problem *and* the crash.
+
+Only remaining question to me is why would it trigger an unncessary repair.
+
+But that could be anything that causes git fsck to exit nonzero. Or it
+might be that git fsck found an actual problem, but not one that was
+preventing the repo from working. Eg, a missing/corrupt object used
+somewhere deep in the history.
+
+(Note that git-repair already exists. git-annex integrates it.)
+"""]]