Extract the svg renderer from the loop
authorKevin Ottens <kevin.ottens@nextcloud.com>
Thu, 23 Jul 2020 17:04:26 +0000 (19:04 +0200)
committerKevin Ottens (Rebase PR Action) <er-vin@users.noreply.github.com>
Tue, 28 Jul 2020 09:20:34 +0000 (09:20 +0000)
No need to recreate it each time for nothing.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
src/libsync/theme.cpp

index 8274e15803d3decadd56f89c20d1cd23817c5603..50e5de836ea88a939a5e43c03d5c4c651f643e3c 100644 (file)
@@ -144,11 +144,12 @@ QIcon Theme::themeIcon(const QString &name, bool sysTray) const
             return cached = QIcon::fromTheme(name);
         }
 
+        const auto svgName = QString::fromLatin1(":/client/theme/%1/%2.svg").arg(flavor).arg(name);
+        QSvgRenderer renderer(svgName);
+
         const auto sizes = isBranded() ? QVector<int>{ 16, 22, 32, 48, 64, 128, 256, 512, 1024 }
                                        : QVector<int>{ 16, 32, 64, 128, 256 };
         for (int size : sizes) {
-            QString svgName = QString::fromLatin1(":/client/theme/%1/%2.svg").arg(flavor).arg(name);
-            QSvgRenderer renderer(svgName);
             QImage img(size, size, QImage::Format_ARGB32);
             img.fill(Qt::GlobalColor::transparent);
             QPainter imgPainter(&img);