build: Make GCC ignore fallthrough comments
authorTimm Bäder <mail@baedert.org>
Thu, 27 Jan 2022 15:05:33 +0000 (16:05 +0100)
committerTimm Bäder <mail@baedert.org>
Thu, 27 Jan 2022 15:05:33 +0000 (16:05 +0100)
From the GCC manpage:

> Wimplicit-fallthrough=5 doesn't recognize any comments as
> fallthrough comments, only attributes disable
> the warning.

So, check for the =5 version after checking for the simple version. This
way we get -Wfallhrough with clang and -Wfallthrough -Wfallthrough=5
with GCC, which works.

meson.build

index 65bf0b20afe377eba1180291d2eb954536a599b0..4fbbb2f539b170a7a09974036570e6608c0018ea 100644 (file)
@@ -298,7 +298,8 @@ elif cc.get_id() == 'gcc' or cc.get_id() == 'clang'
     'array-bounds',
     'empty-body',
     'implicit',
-    'implicit-fallthrough',
+    'implicit-fallthrough',   # For non-gcc
+    'implicit-fallthrough=5', # For GCC, only recognize the attribute and no comments
     'init-self',
     'int-to-pointer-cast',
     'main',