x86/iommu: add missing break
authorRoger Pau Monné <roger.pau@citrix.com>
Fri, 10 Feb 2017 09:42:47 +0000 (10:42 +0100)
committerJan Beulich <jbeulich@suse.com>
Fri, 10 Feb 2017 09:42:47 +0000 (10:42 +0100)
50a498 failed to add a break in the p2m_mmio_direct case, so Xen was still not
adding IOMMU entries for p2m_mmio_direct regions.

Spotted by Coverity.

Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/include/asm-x86/p2m.h

index 173a6f825a17603810f08fa68368b41eaee8a673..c68ff589e1de317d3e697515e120df5e8d7d6eb0 100644 (file)
@@ -819,6 +819,7 @@ static inline unsigned int p2m_get_iommu_flags(p2m_type_t p2mt, mfn_t mfn)
         flags = IOMMUF_readable;
         if ( !rangeset_contains_singleton(mmio_ro_ranges, mfn_x(mfn)) )
             flags |= IOMMUF_writable;
+        break;
     default:
         flags = 0;
         break;