tools/hotplug: Do not mind if "ip link set" fails on vif backends

Most versions of netback do not support setting the MAC address.  This
means that c/s 937488219719 causes the hotplug script to break for
vifs, even as it fixes the bridge-wrong-MAC-address problem for tap
devices (used for emulated nics).

The mac-setting operation is not necessary for vifs since they are
hardcoded to fe:ff* anyway.

As a band-aid, add "|| true" to the call to ip link, so that this
error does not cause the hotplug operation to fail.  There will still
be an error message printed until we can fix this better.

Suggested-by: Ian Campbell <Ian.Campbell@eu.citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh
index 3157a1061808ac1519960fa7a1b6782465fdfdaf..1100757c82bb37ebd0cc9733eb9e0f6c764ba8f0 100644 (file)
--- a/tools/hotplug/Linux/xen-network-common.sh
+++ b/tools/hotplug/Linux/xen-network-common.sh
@@ -90,7 +90,7 @@ setup_bridge_port() {
     # largest non-broadcast address to prevent the address getting
     # stolen by an Ethernet bridge for STP purposes.
     # (FE:FF:FF:FF:FF:FF)
-    ip link set ${dev} address fe:ff:ff:ff:ff:ff
+    ip link set ${dev} address fe:ff:ff:ff:ff:ff || true
 
     # ... and configure it
     ip addr flush ${dev}