improve code in activity list model
authorMatthieu Gallien <matthieu.gallien@nextcloud.com>
Tue, 16 May 2023 09:54:32 +0000 (11:54 +0200)
committerMatthieu Gallien <matthieu_gallien@yahoo.fr>
Wed, 17 May 2023 06:43:54 +0000 (08:43 +0200)
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
src/gui/tray/activitylistmodel.cpp

index 8adae711f620b6536d74dcac4ec2e6f7868178ac..7b152a9842b04e0f5b113e0e8f3c0c7e65c32b63 100644 (file)
@@ -551,13 +551,10 @@ void ActivityListModel::addEntriesToActivityList(const ActivityList &activityLis
     }
     endInsertRows();
 
-    auto conflictsFound = false;
-    for(const auto &activity : _finalList) {
-        if (activity._syncFileItemStatus == SyncFileItem::Conflict) {
-            conflictsFound = true;
-            break;
-        }
-    }
+    const auto deselectedConflictIt = std::find_if(_finalList.constBegin(), _finalList.constEnd(), [] (const auto activity) {
+        return activity._syncFileItemStatus == SyncFileItem::Conflict;
+    });
+    const auto conflictsFound = (deselectedConflictIt != _finalList.constEnd());
 
     setHasSyncConflicts(conflictsFound);
 }