Disable http2 support for now
authorHannah von Reth <hannah.vonreth@owncloud.com>
Mon, 2 Dec 2019 14:30:47 +0000 (15:30 +0100)
committerKevin Ottens <kevin.ottens@nextcloud.com>
Tue, 15 Dec 2020 09:59:04 +0000 (10:59 +0100)
Issue: #7610

src/libsync/accessmanager.cpp

index 50107609e5395fbf1387f100b9730502773543df..87d435644d8a16a70dfb945d3e42d9a18633c3c4 100644 (file)
@@ -98,12 +98,8 @@ QNetworkReply *AccessManager::createRequest(QNetworkAccessManager::Operation op,
 
 #if QT_VERSION >= QT_VERSION_CHECK(5, 9, 4)
     // only enable HTTP2 with Qt 5.9.4 because old Qt have too many bugs (e.g. QTBUG-64359 is fixed in >= Qt 5.9.4)
-
-    /* Disable http2 for now due to Qt bug but allow enabling it via env var, see: https://github.com/owncloud/client/pull/7620
-     *   and: https://github.com/nextcloud/desktop/pull/1806
-     * Issue: https://github.com/nextcloud/desktop/issues/1503
-     */
     if (newRequest.url().scheme() == "https") { // Not for "http": QTBUG-61397
+        // http2 seems to cause issues, as with our recommended server setup we don't support http2, disable it by default for now
         static const bool http2EnabledEnv = qEnvironmentVariableIntValue("OWNCLOUD_HTTP2_ENABLED") == 1;
 
         newRequest.setAttribute(QNetworkRequest::HTTP2AllowedAttribute, http2EnabledEnv);