build: correct usage comments in Kbuild.include
authorJan Beulich <jbeulich@suse.com>
Thu, 13 Jan 2022 13:32:34 +0000 (14:32 +0100)
committerJan Beulich <jbeulich@suse.com>
Thu, 13 Jan 2022 13:32:34 +0000 (14:32 +0100)
Macros with arguments need to be invoked via $(call ...); don't misguide
people looking up usage of such macros.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/scripts/Kbuild.include

index 83c7e1457baae8a11c788f329722a8dd6331d7e4..f75d724ed7fd37af5415405484fee28aa263ea63 100644 (file)
@@ -43,15 +43,15 @@ define as-option-add-closure
     endif
 endef
 
-# $(if-success,<command>,<then>,<else>)
+# $(call if-success,<command>,<then>,<else>)
 # Return <then> if <command> exits with 0, <else> otherwise.
 if-success = $(shell { $(1); } >/dev/null 2>&1 && echo "$(2)" || echo "$(3)")
 
-# $(success,<command>)
+# $(call success,<command>)
 # Return y if <command> exits with 0, n otherwise
 success = $(call if-success,$(1),y,n)
 
-# $(ld-option,<flag>)
+# $(call ld-option,<flag>)
 # Return y if the linker supports <flag>, n otherwise
 ld-option = $(call success,$(LD) -v $(1))