lib/repo: Properly handle NULL homedir when signing commit
authorDan Nicholson <nicholson@endlessm.com>
Tue, 24 Oct 2017 19:27:17 +0000 (19:27 +0000)
committerAtomic Bot <atomic-devel@projectatomic.io>
Tue, 24 Oct 2017 19:58:07 +0000 (19:58 +0000)
Without this, ostree_repo_sign_commit throws a critical message when no
homedir is provided:

(ostree gpg-sign:5034): GLib-GIO-CRITICAL **: g_file_new_for_path: assertion 'path != NULL' failed

Closes: #1305
Approved by: cgwalters

src/libostree/ostree-repo.c

index 7ee7892a1670c7e67599bfe83e5e08fce08888f3..3d53a2db2cec0db33d61fd00b9885b9ca81cc5a9 100644 (file)
@@ -4092,7 +4092,9 @@ ostree_repo_sign_commit (OstreeRepo     *self,
    * pass the homedir so that the signing key can be imported, allowing
    * subkey signatures to be recognised. */
   g_autoptr(GError) local_error = NULL;
-  g_autoptr(GFile) verify_keydir = g_file_new_for_path (homedir);
+  g_autoptr(GFile) verify_keydir = NULL;
+  if (homedir != NULL)
+    verify_keydir = g_file_new_for_path (homedir);
   g_autoptr(OstreeGpgVerifyResult) result
     =_ostree_repo_gpg_verify_with_metadata (self, commit_data, old_metadata,
                                             NULL, verify_keydir, NULL,