Wizard: Avoid cert dialog multiple connection
authorChristian Kamm <mail@ckamm.de>
Mon, 18 Feb 2019 13:02:14 +0000 (14:02 +0100)
committerKevin Ottens <kevin.ottens@nextcloud.com>
Tue, 15 Dec 2020 09:58:42 +0000 (10:58 +0100)
This could lead to odd behavior when slotCertificateAccepted
was called multiple times.

src/gui/wizard/owncloudsetuppage.cpp

index c024c19d56d93054341cbef7b7c313a4bdd63f6c..3fac734d0b1cf557c677dbbe787a600f4940f77c 100644 (file)
@@ -68,6 +68,7 @@ OwncloudSetupPage::OwncloudSetupPage(QWidget *parent)
     connect(_ui.leUrl, &QLineEdit::editingFinished, this, &OwncloudSetupPage::slotUrlEditFinished);
 
     addCertDial = new AddCertificateDialog(this);
+    connect(addCertDial, &QDialog::accepted, this, &OwncloudSetupPage::slotCertificateAccepted);
 
 #ifdef WITH_PROVIDERS
     connect(_ui.loginButton, &QPushButton::clicked, this, &OwncloudSetupPage::slotLogin);
@@ -319,7 +320,6 @@ void OwncloudSetupPage::setErrorString(const QString &err, bool retryHTTPonly)
                 } break;
                 case OwncloudConnectionMethodDialog::Client_Side_TLS:
                     addCertDial->show();
-                    connect(addCertDial, &QDialog::accepted, this, &OwncloudSetupPage::slotCertificateAccepted);
                     break;
                 case OwncloudConnectionMethodDialog::Closed:
                 case OwncloudConnectionMethodDialog::Back: