arm: fix gic_init_secondary_cpu.
authorIan Campbell <ian.campbell@citrix.com>
Fri, 3 Aug 2012 08:54:04 +0000 (09:54 +0100)
committerIan Campbell <ian.campbell@citrix.com>
Fri, 3 Aug 2012 08:54:04 +0000 (09:54 +0100)
Using spin_lock_irq here is unnecessary (interrupts are not yet enabled) and
wrong (since they will get unexpectedly renabled by spin_unlock_irq).

We can just use spin_lock/spin_unlock.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Tim Deegan <tim@xen.org>
Committed-by: Ian Campbell <ian.campbell@citrix.com>
xen/arch/arm/gic.c

index 378158beb45a004e6216e78b26680b9f727bff39..6f5b0e1b1606c75394d03f7b741eca60530d2ab0 100644 (file)
@@ -323,10 +323,10 @@ int __init gic_init(void)
 /* Set up the per-CPU parts of the GIC for a secondary CPU */
 void __cpuinit gic_init_secondary_cpu(void)
 {
-    spin_lock_irq(&gic.lock);
+    spin_lock(&gic.lock);
     gic_cpu_init();
     gic_hyp_init();
-    spin_unlock_irq(&gic.lock);
+    spin_unlock(&gic.lock);
 }
 
 /* Shut down the per-CPU GIC interface */