Address PR feedback.

Signed-off-by: Camila Ayres <hello@camilasan.com>

diff --git a/src/gui/generalsettings.cpp b/src/gui/generalsettings.cpp
index 57936b7182c88fc2215ef40a076dcbac50f99744..d9fcbefe284cd77f8b3e71b8d2a8aec21aa563d1 100644 (file)
--- a/src/gui/generalsettings.cpp
+++ b/src/gui/generalsettings.cpp
@@ -299,7 +299,7 @@ void GeneralSettings::loadUpdateChannelsList() {
         _ui->updateChannel->clear();
         _ui->updateChannel->addItems(_currentUpdateChannelList);
         const auto currentUpdateChannelIndex = _currentUpdateChannelList.indexOf(cfgFile.currentUpdateChannel());
-        _ui->updateChannel->setCurrentIndex(currentUpdateChannelIndex != -1? currentUpdateChannelIndex : 0);
+        _ui->updateChannel->setCurrentIndex(currentUpdateChannelIndex != -1 ? currentUpdateChannelIndex : 0);
         connect(_ui->updateChannel, &QComboBox::currentTextChanged, this, &GeneralSettings::slotUpdateChannelChanged);
     }
 }

diff --git a/src/gui/settingsdialog.cpp b/src/gui/settingsdialog.cpp
index 429808d66ee1ac3b3703744ec65e907d59676e5a..261526e11ac2767295169ddb5bb04b7f9e892ebb 100644 (file)
--- a/src/gui/settingsdialog.cpp
+++ b/src/gui/settingsdialog.cpp
@@ -140,7 +140,8 @@ SettingsDialog::SettingsDialog(ownCloudGui *gui, QWidget *parent)
     _actionGroupWidgets.insert(generalAction, generalSettings);
     _actionGroupWidgets.insert(networkAction, networkSettings);
 
-    foreach(auto account, AccountManager::instance()->accounts()) {
+    const auto accountsList = AccountManager::instance()->accounts();
+    for (const auto &account : accountsList) {
         accountAdded(account.data());
     }