firmware: Remove redundant log messages from drivers
authorBen Hutchings <ben@decadent.org.uk>
Sun, 9 Dec 2012 16:40:31 +0000 (16:40 +0000)
committerSalvatore Bonaccorso <carnil@debian.org>
Tue, 20 Mar 2018 08:31:07 +0000 (08:31 +0000)
Now that firmware_class logs every success and failure consistently,
many other log messages can be removed from drivers.

This will probably need to be split up into multiple patches prior to
upstream submission.

Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name firmware-remove-redundant-log-messages-from-drivers.patch

157 files changed:
arch/arm/mach-netx/xc.c
arch/cris/arch-v32/drivers/iop_fw_load.c
arch/x86/kernel/cpu/microcode/amd.c
drivers/atm/ambassador.c
drivers/atm/fore200e.c
drivers/bluetooth/ath3k.c
drivers/bluetooth/bcm203x.c
drivers/bluetooth/bfusb.c
drivers/bluetooth/bt3c_cs.c
drivers/bluetooth/btmrvl_sdio.c
drivers/char/dsp56k.c
drivers/dma/imx-sdma.c
drivers/gpu/drm/mga/mga_warp.c
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
drivers/gpu/drm/r128/r128_cce.c
drivers/gpu/drm/radeon/ni.c
drivers/gpu/drm/radeon/r100.c
drivers/gpu/drm/radeon/r600.c
drivers/infiniband/hw/qib/qib_sd7220.c
drivers/input/touchscreen/atmel_mxt_ts.c
drivers/isdn/hardware/mISDN/speedfax.c
drivers/media/common/siano/smscoreapi.c
drivers/media/dvb-frontends/af9013.c
drivers/media/dvb-frontends/bcm3510.c
drivers/media/dvb-frontends/cx24116.c
drivers/media/dvb-frontends/drxd_hard.c
drivers/media/dvb-frontends/drxk_hard.c
drivers/media/dvb-frontends/ds3000.c
drivers/media/dvb-frontends/nxt200x.c
drivers/media/dvb-frontends/or51132.c
drivers/media/dvb-frontends/or51211.c
drivers/media/dvb-frontends/sp8870.c
drivers/media/dvb-frontends/sp887x.c
drivers/media/dvb-frontends/tda10048.c
drivers/media/dvb-frontends/tda1004x.c
drivers/media/dvb-frontends/tda10071.c
drivers/media/i2c/cx25840/cx25840-firmware.c
drivers/media/pci/bt8xx/bttv-cards.c
drivers/media/pci/cx18/cx18-av-firmware.c
drivers/media/pci/cx18/cx18-dvb.c
drivers/media/pci/cx18/cx18-firmware.c
drivers/media/pci/cx23885/cx23885-417.c
drivers/media/pci/cx23885/cx23885-cards.c
drivers/media/pci/cx88/cx88-blackbird.c
drivers/media/pci/ivtv/ivtv-firmware.c
drivers/media/pci/ngene/ngene-core.c
drivers/media/pci/saa7164/saa7164-fw.c
drivers/media/pci/ttpci/av7110.c
drivers/media/pci/ttpci/av7110_hw.c
drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
drivers/media/radio/radio-wl1273.c
drivers/media/radio/wl128x/fmdrv_common.c
drivers/media/tuners/tuner-xc2028.c
drivers/media/usb/cpia2/cpia2_core.c
drivers/media/usb/cx231xx/cx231xx-417.c
drivers/media/usb/dvb-usb/dib0700_devices.c
drivers/media/usb/dvb-usb/dvb-usb-firmware.c
drivers/media/usb/dvb-usb/gp8psk.c
drivers/media/usb/dvb-usb/opera1.c
drivers/media/usb/go7007/go7007-driver.c
drivers/media/usb/go7007/go7007-fw.c
drivers/media/usb/go7007/go7007-loader.c
drivers/media/usb/gspca/vicam.c
drivers/media/usb/pvrusb2/pvrusb2-hdw.c
drivers/media/usb/s2255/s2255drv.c
drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c
drivers/media/usb/ttusb-dec/ttusb_dec.c
drivers/misc/ti-st/st_kim.c
drivers/net/can/softing/softing_fw.c
drivers/net/ethernet/3com/typhoon.c
drivers/net/ethernet/adaptec/starfire.c
drivers/net/ethernet/alacritech/slicoss.c
drivers/net/ethernet/alteon/acenic.c
drivers/net/ethernet/broadcom/bnx2.c
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
drivers/net/ethernet/broadcom/tg3.c
drivers/net/ethernet/brocade/bna/cna_fwimg.c
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
drivers/net/ethernet/intel/e100.c
drivers/net/ethernet/myricom/myri10ge/myri10ge.c
drivers/net/ethernet/smsc/smc91c92_cs.c
drivers/net/ethernet/sun/cassini.c
drivers/net/hamradio/yam.c
drivers/net/usb/kaweth.c
drivers/net/wimax/i2400m/fw.c
drivers/net/wireless/ath/ath9k/hif_usb.c
drivers/net/wireless/ath/carl9170/usb.c
drivers/net/wireless/atmel/at76c50x-usb.c
drivers/net/wireless/atmel/atmel.c
drivers/net/wireless/broadcom/b43/main.c
drivers/net/wireless/broadcom/b43legacy/main.c
drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c
drivers/net/wireless/intel/ipw2x00/ipw2100.c
drivers/net/wireless/intel/ipw2x00/ipw2200.c
drivers/net/wireless/intel/iwlegacy/3945-mac.c
drivers/net/wireless/intel/iwlwifi/iwl-drv.c
drivers/net/wireless/intersil/orinoco/fw.c
drivers/net/wireless/intersil/orinoco/orinoco_usb.c
drivers/net/wireless/intersil/p54/p54pci.c
drivers/net/wireless/intersil/p54/p54spi.c
drivers/net/wireless/intersil/p54/p54usb.c
drivers/net/wireless/intersil/prism54/islpci_dev.c
drivers/net/wireless/marvell/libertas_tf/if_usb.c
drivers/net/wireless/marvell/mwifiex/main.c
drivers/net/wireless/marvell/mwl8k.c
drivers/net/wireless/ralink/rt2x00/rt2x00firmware.c
drivers/net/wireless/realtek/rtlwifi/core.c
drivers/net/wireless/realtek/rtlwifi/rtl8192se/sw.c
drivers/net/wireless/ti/wl1251/main.c
drivers/net/wireless/ti/wlcore/main.c
drivers/net/wireless/zydas/zd1201.c
drivers/net/wireless/zydas/zd1211rw/zd_usb.c
drivers/scsi/advansys.c
drivers/scsi/aic94xx/aic94xx_init.c
drivers/scsi/aic94xx/aic94xx_seq.c
drivers/scsi/bfa/bfad.c
drivers/scsi/ipr.c
drivers/scsi/pm8001/pm8001_ctl.c
drivers/scsi/qla1280.c
drivers/scsi/qla2xxx/qla_init.c
drivers/scsi/qla2xxx/qla_nx.c
drivers/scsi/qla2xxx/qla_os.c
drivers/scsi/qlogicpti.c
drivers/staging/media/lirc/lirc_zilog.c
drivers/staging/rtl8192u/r819xU_firmware.c
drivers/staging/rtl8712/hal_init.c
drivers/staging/vt6656/firmware.c
drivers/tty/cyclades.c
drivers/tty/moxa.c
drivers/tty/serial/icom.c
drivers/tty/serial/ucc_uart.c
drivers/usb/atm/cxacru.c
drivers/usb/atm/ueagle-atm.c
drivers/usb/misc/emi26.c
drivers/usb/misc/ezusb.c
drivers/usb/misc/isight_firmware.c
drivers/usb/serial/io_edgeport.c
drivers/usb/serial/io_ti.c
drivers/usb/serial/ti_usb_3410_5052.c
drivers/video/fbdev/broadsheetfb.c
drivers/video/fbdev/metronomefb.c
sound/drivers/vx/vx_hwdep.c
sound/isa/msnd/msnd_pinnacle.c
sound/isa/sscape.c
sound/isa/wavefront/wavefront_synth.c
sound/pci/asihpi/hpidspcd.c
sound/pci/cs46xx/cs46xx_lib.c
sound/pci/echoaudio/echoaudio.c
sound/pci/emu10k1/emu10k1_main.c
sound/pci/hda/hda_intel.c
sound/pci/korg1212/korg1212.c
sound/pci/mixart/mixart_hwdep.c
sound/pci/pcxhr/pcxhr_hwdep.c
sound/pci/riptide/riptide.c
sound/pci/rme9652/hdsp.c
sound/soc/codecs/wm2000.c
sound/usb/6fire/firmware.c

index f1c972d87bacc164b297b6e7f8088818a09aa168..496778446b14e2295ed2e2df33c9759ae5e7245c 100644 (file)
@@ -127,10 +127,8 @@ int xc_request_firmware(struct xc *x)
 
        ret = request_firmware(&fw, name, x->dev);
 
-       if (ret < 0) {
-               dev_err(x->dev, "request_firmware failed\n");
+       if (ret)
                return ret;
-       }
 
        head = (struct fw_header *)fw->data;
        if (head->magic != 0x4e657458) {
index 2f8ea0f7a63c30e77f7948b404bc74618cc6e421..4b8e651935fe3ed49b00b8ce5c6dcd605a4d7270 100644 (file)
@@ -74,12 +74,7 @@ int iop_fw_load_spu(const unsigned char *fw_name, unsigned int spu_inst)
                                  fw_name,
                                  &iop_spu_device[spu_inst]);
        if (retval != 0)
-       {
-               printk(KERN_ERR
-                      "iop_load_spu: Failed to load firmware \"%s\"\n",
-                      fw_name);
                return retval;
-       }
        data = (u32 *) fw_entry->data;
 
        /* acquire ownership of memory controller */
@@ -137,12 +132,7 @@ int iop_fw_load_mpu(unsigned char *fw_name)
        /* get firmware */
        retval = request_firmware(&fw_entry, fw_name, &iop_mpu_device);
        if (retval != 0)
-       {
-               printk(KERN_ERR
-                      "iop_load_spu: Failed to load firmware \"%s\"\n",
-                      fw_name);
                return retval;
-       }
        data = (u32 *) fw_entry->data;
 
        /* disable MPU */
index 330b8462d426faad0dccdc480f34eec34cd8b92f..f27e8c1028cef170f1f202c4a110119901956e2c 100644 (file)
@@ -739,10 +739,8 @@ static enum ucode_state request_microcode_amd(int cpu, struct device *device,
        if (c->x86 >= 0x15)
                snprintf(fw_name, sizeof(fw_name), "amd-ucode/microcode_amd_fam%.2xh.bin", c->x86);
 
-       if (request_firmware_direct(&fw, (const char *)fw_name, device)) {
-               pr_debug("failed to load file %s\n", fw_name);
+       if (request_firmware_direct(&fw, (const char *)fw_name, device))
                goto out;
-       }
 
        ret = UCODE_ERROR;
        if (*(u32 *)fw->data != UCODE_MAGIC) {
index 9287ec958b7095f0385c33c095ed14ac9feba445..081c8cce239faecb0793169dce97fb15b47b0f3f 100644 (file)
@@ -1929,10 +1929,8 @@ static int ucode_init(loader_block *lb, amb_dev *dev)
   int res;
 
   res = request_ihex_firmware(&fw, "atmsar11.fw", &dev->pci_dev->dev);
-  if (res) {
-    PRINTK (KERN_ERR, "Cannot load microcode data");
+  if (res)
     return res;
-  }
 
   /* First record contains just the start address */
   rec = (const struct ihex_binrec *)fw->data;
index 6ebc4e4820fc4b267351970047e29a7c700902cc..ada7d090cd5813e20721956862f251c9c53c265f 100644 (file)
@@ -2504,10 +2504,9 @@ static int fore200e_load_and_start_fw(struct fore200e *fore200e)
        return err;
 
     sprintf(buf, "%s%s", fore200e->bus->proc_name, FW_EXT);
-    if ((err = request_firmware(&firmware, buf, device)) < 0) {
-       printk(FORE200E "problem loading firmware image %s\n", fore200e->bus->model_name);
+    err = request_firmware(&firmware, buf, device);
+    if (err)
        return err;
-    }
 
     fw_data = (const __le32 *)firmware->data;
     fw_size = firmware->size / sizeof(u32);
index 204afe66de92ed42aaf8c9d1c015161f60429f33..196846274f535060a1356cd419bb89c642877bcc 100644 (file)
@@ -425,10 +425,8 @@ static int ath3k_load_patch(struct usb_device *udev)
                 le32_to_cpu(fw_version.rom_version));
 
        ret = request_firmware(&firmware, filename, &udev->dev);
-       if (ret < 0) {
-               BT_ERR("Patch file not found %s", filename);
+       if (ret)
                return ret;
-       }
 
        pt_rom_version = get_unaligned_le32(firmware->data +
                                            firmware->size - 8);
@@ -488,10 +486,8 @@ static int ath3k_load_syscfg(struct usb_device *udev)
                le32_to_cpu(fw_version.rom_version), clk_value, ".dfu");
 
        ret = request_firmware(&firmware, filename, &udev->dev);
-       if (ret < 0) {
-               BT_ERR("Configuration file not found %s", filename);
+       if (ret)
                return ret;
-       }
 
        ret = ath3k_load_fwfile(udev, firmware);
        release_firmware(firmware);
index 8e9547f195effe4801e25f195d53f4a0a6457897..0aebe43f1c9b36f64a2ff0106c6bb93785c97118 100644 (file)
@@ -189,7 +189,6 @@ static int bcm203x_probe(struct usb_interface *intf, const struct usb_device_id
                return -ENOMEM;
 
        if (request_firmware(&firmware, "BCM2033-MD.hex", &udev->dev) < 0) {
-               BT_ERR("Mini driver request failed");
                usb_free_urb(data->urb);
                return -EIO;
        }
@@ -214,7 +213,6 @@ static int bcm203x_probe(struct usb_interface *intf, const struct usb_device_id
        release_firmware(firmware);
 
        if (request_firmware(&firmware, "BCM2033-FW.bin", &udev->dev) < 0) {
-               BT_ERR("Firmware request failed");
                usb_free_urb(data->urb);
                kfree(data->buffer);
                return -EIO;
index ab090a313a5f1c2218ab46072e17f5d8bd54ca90..ee4fada037986429bba2725dd905f6ece163eabe 100644 (file)
@@ -652,10 +652,8 @@ static int bfusb_probe(struct usb_interface *intf, const struct usb_device_id *i
        skb_queue_head_init(&data->pending_q);
        skb_queue_head_init(&data->completed_q);
 
-       if (request_firmware(&firmware, "bfubase.frm", &udev->dev) < 0) {
-               BT_ERR("Firmware request failed");
+       if (request_firmware(&firmware, "bfubase.frm", &udev->dev))
                goto done;
-       }
 
        BT_DBG("firmware data %p size %zu", firmware->data, firmware->size);
 
index 25b0cf952b91757fcfa9abb85ab9cc2a74545218..9048a7a9e4dd1d012ef97c403b34253167fa84b7 100644 (file)
@@ -566,10 +566,8 @@ static int bt3c_open(struct bt3c_info *info)
 
        /* Load firmware */
        err = request_firmware(&firmware, "BT3CPCC.bin", &info->p_dev->dev);
-       if (err < 0) {
-               BT_ERR("Firmware request failed");
+       if (err)
                goto error;
-       }
 
        err = bt3c_load_firmware(info, firmware->data, firmware->size);
 
index 7dbb4463b53979cffcebd741926c3c2a1b4978a0..2f7d40d7b4480f8e6f99b79859ead8f9d8b0c551 100644 (file)
@@ -455,8 +455,6 @@ static int btmrvl_sdio_download_helper(struct btmrvl_sdio_card *card)
        ret = request_firmware(&fw_helper, card->helper,
                                                &card->func->dev);
        if ((ret < 0) || !fw_helper) {
-               BT_ERR("request_firmware(helper) failed, error code = %d",
-                                                                       ret);
                ret = -ENOENT;
                goto done;
        }
@@ -555,8 +553,6 @@ static int btmrvl_sdio_download_fw_w_helper(struct btmrvl_sdio_card *card)
        ret = request_firmware(&fw_firmware, card->firmware,
                                                        &card->func->dev);
        if ((ret < 0) || !fw_firmware) {
-               BT_ERR("request_firmware(firmware) failed, error code = %d",
-                                                                       ret);
                ret = -ENOENT;
                goto done;
        }
index 0d7b577e0ff0ee5d654b22e3d3bd78644395301b..d05e641abf1842847d036ef9ba2a539536b4b82b 100644 (file)
@@ -140,11 +140,8 @@ static int dsp56k_upload(u_char __user *bin, int len)
        }
        err = request_firmware(&fw, fw_name, &pdev->dev);
        platform_device_unregister(pdev);
-       if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fw_name, err);
+       if (err)
                return err;
-       }
        if (fw->size % 3) {
                printk(KERN_ERR "Bogus length %d in image \"%s\"\n",
                       fw->size, fw_name);
index 2184881afe76be5840f9adaff908c91e0626c2db..3c3c583838a8ba1fd4be9ed6861f81fe0f42de41 100644 (file)
@@ -1461,11 +1461,8 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)
        const struct sdma_script_start_addrs *addr;
        unsigned short *ram_code;
 
-       if (!fw) {
-               dev_info(sdma->dev, "external firmware not found, using ROM firmware\n");
-               /* In this case we just use the ROM firmware. */
+       if (!fw)
                return;
-       }
 
        if (fw->size < sizeof(*header))
                goto err_firmware;
index 0b76352260a9fbef3c7a4115299ca130a86b22e1..06953a711525e61c5acbc37efcd2735b84a94d59 100644 (file)
@@ -79,11 +79,8 @@ int mga_warp_install_microcode(drm_mga_private_t *dev_priv)
        }
        rc = request_ihex_firmware(&fw, firmware_name, &pdev->dev);
        platform_device_unregister(pdev);
-       if (rc) {
-               DRM_ERROR("mga: Failed to load microcode \"%s\"\n",
-                         firmware_name);
+       if (rc)
                return rc;
-       }
 
        size = 0;
        where = 0;
index 2f8dc107047dc8c14b91f60af01304f189ce68c1..476fa106d69dab8490acf52b5d3901aad0722947 100644 (file)
@@ -1839,10 +1839,8 @@ gf100_gr_ctor_fw_legacy(struct gf100_gr *gr, const char *fwname,
        if (ret) {
                snprintf(f, sizeof(f), "nouveau/%s", fwname);
                ret = request_firmware(&fw, f, device->dev);
-               if (ret) {
-                       nvkm_error(subdev, "failed to load %s\n", fwname);
+               if (ret)
                        return ret;
-               }
        }
 
        fuc->size = fw->size;
index c9890afe69d6b0376c686c2442045b91c657f6a3..1a4752287abc8c2a61cf4ae91851a22d8db359aa 100644 (file)
@@ -154,11 +154,8 @@ static int r128_cce_load_microcode(drm_r128_private_t *dev_priv)
        }
        rc = request_firmware(&fw, FIRMWARE_NAME, &pdev->dev);
        platform_device_unregister(pdev);
-       if (rc) {
-               pr_err("r128_cce: Failed to load firmware \"%s\"\n",
-                      FIRMWARE_NAME);
+       if (rc)
                return rc;
-       }
 
        if (fw->size != 256 * 8) {
                pr_err("r128_cce: Bogus length %zu in firmware \"%s\"\n",
index 9eccd0c81d8815fc30a16da28b2e6360b3a69e8f..df0043625250612ac5c87c67c73b5c16a1ff3845 100644 (file)
@@ -830,9 +830,6 @@ int ni_init_microcode(struct radeon_device *rdev)
 
 out:
        if (err) {
-               if (err != -EINVAL)
-                       pr_err("ni_cp: Failed to load firmware \"%s\"\n",
-                              fw_name);
                release_firmware(rdev->pfp_fw);
                rdev->pfp_fw = NULL;
                release_firmware(rdev->me_fw);
index 7d39ed63e5be755e7d3de41899b46663086bf52b..ec5ea1a490c4a33013394a82c43e4556086b389a 100644 (file)
@@ -1041,9 +1041,7 @@ static int r100_cp_init_microcode(struct radeon_device *rdev)
        }
 
        err = request_firmware(&rdev->me_fw, fw_name, rdev->dev);
-       if (err) {
-               pr_err("radeon_cp: Failed to load firmware \"%s\"\n", fw_name);
-       } else if (rdev->me_fw->size % 8) {
+       if (err == 0 && rdev->me_fw->size % 8) {
                pr_err("radeon_cp: Bogus length %zu in firmware \"%s\"\n",
                       rdev->me_fw->size, fw_name);
                err = -EINVAL;
index e06e2d8feab397822361ba18a3e4b420cc2f0c4d..0c5220080ddf14dbde507740a2f38aed6ec93aac 100644 (file)
@@ -2593,9 +2593,6 @@ int r600_init_microcode(struct radeon_device *rdev)
 
 out:
        if (err) {
-               if (err != -EINVAL)
-                       pr_err("r600_cp: Failed to load firmware \"%s\"\n",
-                              fw_name);
                release_firmware(rdev->pfp_fw);
                rdev->pfp_fw = NULL;
                release_firmware(rdev->me_fw);
index 12caf3db8c349c6121ead1fa5dac808ee91fd29a..531eb5bb7794d67f8399da18c4d8d0a387201e63 100644 (file)
@@ -406,10 +406,8 @@ int qib_sd7220_init(struct qib_devdata *dd)
        }
 
        ret = request_firmware(&fw, SD7220_FW_NAME, &dd->pcidev->dev);
-       if (ret) {
-               qib_dev_err(dd, "Failed to load IB SERDES image\n");
+       if (ret)
                goto done;
-       }
 
        /* Substitute our deduced value for was_reset */
        ret = qib_ibsd_ucode_loaded(dd->pport, fw);
index 7659bc48f1db8e76490e2451ad552aa1b7e17fcb..ba768ad7e05992fa4c944caf8176122733daa82b 100644 (file)
@@ -2717,10 +2717,8 @@ static int mxt_load_fw(struct device *dev, const char *fn)
        int ret;
 
        ret = request_firmware(&fw, fn, dev);
-       if (ret) {
-               dev_err(dev, "Unable to open firmware %s\n", fn);
+       if (ret)
                return ret;
-       }
 
        /* Check for incorrect enc file */
        ret = mxt_check_firmware_format(dev, fw);
index 1f1446ed8d5f328506e71bce312862a8473c15c9..8ae86d29b32b77bc0ce985c1f26fd40dcabbc474 100644 (file)
@@ -392,11 +392,8 @@ setup_instance(struct sfax_hw *card)
        card->isar.owner = THIS_MODULE;
 
        err = request_firmware(&firmware, "isdn/ISAR.BIN", &card->pdev->dev);
-       if (err < 0) {
-               pr_info("%s: firmware request failed %d\n",
-                       card->name, err);
+       if (err)
                goto error_fw;
-       }
        if (debug & DEBUG_HW)
                pr_notice("%s: got firmware %zu bytes\n",
                          card->name, firmware->size);
index c5c827e11b640dc40a762550be7677f5ac6db5b6..8f4adb7814d36dd4d63a9b7a41d5d0f9de5287a5 100644 (file)
@@ -1156,10 +1156,8 @@ static int smscore_load_firmware_from_file(struct smscore_device_t *coredev,
                return -EINVAL;
 
        rc = request_firmware(&fw, fw_filename, coredev->device);
-       if (rc < 0) {
-               pr_err("failed to open firmware file '%s'\n", fw_filename);
+       if (rc < 0)
                return rc;
-       }
        pr_debug("read fw %s, buffer size=0x%zx\n", fw_filename, fw->size);
        fw_buf = kmalloc(ALIGN(fw->size + sizeof(struct sms_firmware),
                         SMS_ALLOC_ALIGNMENT), GFP_KERNEL | GFP_DMA);
index b8f3ebfc3e272af4979cca68a10f0eb993127785..81395e2bd5c3152cd832e00961d8aa57b093e58a 100644 (file)
@@ -1140,14 +1140,8 @@ static int af9013_download_firmware(struct af9013_state *state)
 
        /* Request the firmware, will block and timeout */
        ret = request_firmware(&firmware, name, &client->dev);
-       if (ret) {
-               dev_info(&client->dev, "firmware file '%s' not found %d\n",
-                        name, ret);
+       if (ret)
                goto err;
-       }
-
-       dev_info(&client->dev, "downloading firmware from file '%s'\n",
-                name);
 
        /* Write firmware checksum & size */
        for (i = 0; i < firmware->size; i++)
index ba63ad170d3c3301e3d2ce7b13c2f20eb14908bb..9a139a0d63832e4069ba868d1df37b4a7d759e5b 100644 (file)
@@ -636,10 +636,9 @@ static int bcm3510_download_firmware(struct dvb_frontend* fe)
        int ret,i;
 
        deb_info("requesting firmware\n");
-       if ((ret = st->config->request_firmware(fe, &fw, BCM3510_DEFAULT_FIRMWARE)) < 0) {
-               err("could not load firmware (%s): %d",BCM3510_DEFAULT_FIRMWARE,ret);
+       ret = st->config->request_firmware(fe, &fw, BCM3510_DEFAULT_FIRMWARE);
+       if (ret)
                return ret;
-       }
        deb_info("got firmware: %zu\n", fw->size);
 
        b = fw->data;
index 8fb3f095e21cc8f38dd683e14218c1d57beacf54..e6d9fc6ac49f71a5d0d587f4d604186ddb04bbd2 100644 (file)
@@ -491,13 +491,8 @@ static int cx24116_firmware_ondemand(struct dvb_frontend *fe)
                        __func__, CX24116_DEFAULT_FIRMWARE);
                ret = request_firmware(&fw, CX24116_DEFAULT_FIRMWARE,
                        state->i2c->dev.parent);
-               printk(KERN_INFO "%s: Waiting for firmware upload(2)...\n",
-                       __func__);
-               if (ret) {
-                       printk(KERN_ERR "%s: No firmware uploaded (timeout or file not found?)\n",
-                              __func__);
+               if (ret)
                        return ret;
-               }
 
                /* Make sure we don't recurse back through here
                 * during loading */
index 0696bc62dcc90784bc3d9c6cfa945de7ec410bba..53013785e8abfd670c26433791ce678376e78b4e 100644 (file)
@@ -903,10 +903,8 @@ static int load_firmware(struct drxd_state *state, const char *fw_name)
 {
        const struct firmware *fw;
 
-       if (request_firmware(&fw, fw_name, state->dev) < 0) {
-               printk(KERN_ERR "drxd: firmware load failure [%s]\n", fw_name);
+       if (request_firmware(&fw, fw_name, state->dev))
                return -EIO;
-       }
 
        state->microcode = kmemdup(fw->data, fw->size, GFP_KERNEL);
        if (!state->microcode) {
index f59ac2e91c5995fa205d12d428575619323b61e4..3ff39301eea200822c9cefa62b3431e57baa5cc3 100644 (file)
@@ -6287,10 +6287,6 @@ static void load_firmware_cb(const struct firmware *fw,
 
        dprintk(1, ": %s\n", fw ? "firmware loaded" : "firmware not loaded");
        if (!fw) {
-               pr_err("Could not load firmware file %s.\n",
-                       state->microcode_name);
-               pr_info("Copy %s to your hotplug directory!\n",
-                       state->microcode_name);
                state->microcode_name = NULL;
 
                /*
index bd4f8278c90660076235e44cdc1bd5ca8e8f48ec..15390792b39944d3952165d21b31bc91f8a8de4e 100644 (file)
@@ -360,12 +360,8 @@ static int ds3000_firmware_ondemand(struct dvb_frontend *fe)
                                DS3000_DEFAULT_FIRMWARE);
        ret = request_firmware(&fw, DS3000_DEFAULT_FIRMWARE,
                                state->i2c->dev.parent);
-       printk(KERN_INFO "%s: Waiting for firmware upload(2)...\n", __func__);
-       if (ret) {
-               printk(KERN_ERR "%s: No firmware uploaded (timeout or file not found?)\n",
-                      __func__);
+       if (ret)
                return ret;
-       }
 
        ret = ds3000_load_firmware(fe, fw);
        if (ret)
index bf6e5cd572c55f831eb10fdaef0ad927a2688489..c9d2da0c3de5751cf13d683ec625dcf27e9c3373 100644 (file)
@@ -886,12 +886,8 @@ static int nxt2002_init(struct dvb_frontend* fe)
                 __func__, NXT2002_DEFAULT_FIRMWARE);
        ret = request_firmware(&fw, NXT2002_DEFAULT_FIRMWARE,
                               state->i2c->dev.parent);
-       pr_debug("%s: Waiting for firmware upload(2)...\n", __func__);
-       if (ret) {
-               pr_err("%s: No firmware uploaded (timeout or file not found?)\n",
-                      __func__);
+       if (ret)
                return ret;
-       }
 
        ret = nxt2002_load_firmware(fe, fw);
        release_firmware(fw);
@@ -953,12 +949,8 @@ static int nxt2004_init(struct dvb_frontend* fe)
                 __func__, NXT2004_DEFAULT_FIRMWARE);
        ret = request_firmware(&fw, NXT2004_DEFAULT_FIRMWARE,
                               state->i2c->dev.parent);
-       pr_debug("%s: Waiting for firmware upload(2)...\n", __func__);
-       if (ret) {
-               pr_err("%s: No firmware uploaded (timeout or file not found?)\n",
-                      __func__);
+       if (ret)
                return ret;
-       }
 
        ret = nxt2004_load_firmware(fe, fw);
        release_firmware(fw);
index 5f2549c48eb04d0b3131e4e95e23fa7462acf3b3..203b63534a6ee1970733545d710e1df10f148dc7 100644 (file)
@@ -337,10 +337,8 @@ static int or51132_set_parameters(struct dvb_frontend *fe)
                printk("or51132: Waiting for firmware upload(%s)...\n",
                       fwname);
                ret = request_firmware(&fw, fwname, state->i2c->dev.parent);
-               if (ret) {
-                       printk(KERN_WARNING "or51132: No firmware uploaded(timeout or file not found?)\n");
+               if (ret)
                        return ret;
-               }
                ret = or51132_load_firmware(fe, fw);
                release_firmware(fw);
                if (ret) {
index d14fa9736ae526c848e785887742db2dac847ab4..57dda0b6f9259cd0bba1cfcaf05142a06301c573 100644 (file)
@@ -371,11 +371,8 @@ static int or51211_init(struct dvb_frontend* fe)
                        OR51211_DEFAULT_FIRMWARE);
                ret = config->request_firmware(fe, &fw,
                                               OR51211_DEFAULT_FIRMWARE);
-               pr_info("Got Hotplug firmware\n");
-               if (ret) {
-                       pr_warn("No firmware uploaded (timeout or file not found?)\n");
+               if (ret)
                        return ret;
-               }
 
                ret = or51211_load_firmware(fe, fw);
                release_firmware(fw);
index 04454cb7846761d7a625aef1efacc335981bfaa7..b0d2a0194eef38924d68774fd9c4a7a6111c6276 100644 (file)
@@ -315,10 +315,8 @@ static int sp8870_init (struct dvb_frontend* fe)
 
        /* request the firmware, this will block until someone uploads it */
        printk("sp8870: waiting for firmware upload (%s)...\n", SP8870_DEFAULT_FIRMWARE);
-       if (state->config->request_firmware(fe, &fw, SP8870_DEFAULT_FIRMWARE)) {
-               printk("sp8870: no firmware upload (timeout or file not found?)\n");
+       if (state->config->request_firmware(fe, &fw, SP8870_DEFAULT_FIRMWARE))
                return -EIO;
-       }
 
        if (sp8870_firmware_upload(state, fw)) {
                printk("sp8870: writing firmware to device failed\n");
index d2c402b52c6ef9c18b9f88340c489b9b850d0720..bee68e57d660d2b00cd2915dd7ce9745fa402f76 100644 (file)
@@ -526,10 +526,8 @@ static int sp887x_init(struct dvb_frontend* fe)
                /* request the firmware, this will block until someone uploads it */
                printk("sp887x: waiting for firmware upload (%s)...\n", SP887X_DEFAULT_FIRMWARE);
                ret = state->config->request_firmware(fe, &fw, SP887X_DEFAULT_FIRMWARE);
-               if (ret) {
-                       printk("sp887x: no firmware upload (timeout or file not found?)\n");
+               if (ret)
                        return ret;
-               }
 
                ret = sp887x_initial_setup(fe, fw);
                release_firmware(fw);
index 143b39b5f6c9c2a47a1b710db075c5852f76bcaa..aef91340ef417b33b50d4f86f6eb28b8a6ec0809 100644 (file)
@@ -495,8 +495,6 @@ static int tda10048_firmware_upload(struct dvb_frontend *fe)
        ret = request_firmware(&fw, TDA10048_DEFAULT_FIRMWARE,
                state->i2c->dev.parent);
        if (ret) {
-               printk(KERN_ERR "%s: Upload failed. (file not found?)\n",
-                       __func__);
                return -EIO;
        } else {
                printk(KERN_INFO "%s: firmware read %zu bytes.\n",
index e674508c349c7595f23b28cd9e63089620ed6d9c..fe4858f3297ced79e3d6cc7b41ac81c6632f9dd3 100644 (file)
@@ -401,10 +401,8 @@ static int tda10045_fwupload(struct dvb_frontend* fe)
        /* request the firmware, this will block until someone uploads it */
        printk(KERN_INFO "tda1004x: waiting for firmware upload (%s)...\n", TDA10045_DEFAULT_FIRMWARE);
        ret = state->config->request_firmware(fe, &fw, TDA10045_DEFAULT_FIRMWARE);
-       if (ret) {
-               printk(KERN_ERR "tda1004x: no firmware upload (timeout or file not found?)\n");
+       if (ret)
                return ret;
-       }
 
        /* reset chip */
        tda1004x_write_mask(state, TDA1004X_CONFC4, 0x10, 0);
@@ -545,7 +543,6 @@ static int tda10046_fwupload(struct dvb_frontend* fe)
                        /* remain compatible to old bug: try to load with tda10045 image name */
                        ret = state->config->request_firmware(fe, &fw, TDA10045_DEFAULT_FIRMWARE);
                        if (ret) {
-                               printk(KERN_ERR "tda1004x: no firmware upload (timeout or file not found?)\n");
                                return ret;
                        } else {
                                printk(KERN_INFO "tda1004x: please rename the firmware file to %s\n",
index a59f4fd09df605d3568fea54706da363a6ea92bf..d440699a8260c346a1eb45b61ab7ab48c7d2d63e 100644 (file)
@@ -850,12 +850,8 @@ static int tda10071_init(struct dvb_frontend *fe)
 
                /* request the firmware, this will block and timeout */
                ret = request_firmware(&fw, fw_file, &client->dev);
-               if (ret) {
-                       dev_err(&client->dev,
-                               "did not find the firmware file. (%s) Please see linux/Documentation/dvb/ for more details on firmware-problems. (%d)\n",
-                               fw_file, ret);
+               if (ret)
                        goto error;
-               }
 
                /* init */
                for (i = 0; i < ARRAY_SIZE(tab2); i++) {
index a7819c4636740a1087965753a9dda006d4bed29c..897c49b23e5a14ff4902497fafc6b7245b1d8373 100644 (file)
@@ -122,10 +122,8 @@ int cx25840_loadfw(struct i2c_client *client)
        if (is_cx231xx(state) && max_buf_size > 16)
                max_buf_size = 16;
 
-       if (request_firmware(&fw, fwname, FWDEV(client)) != 0) {
-               v4l_err(client, "unable to open firmware %s\n", fwname);
+       if (request_firmware(&fw, fwname, FWDEV(client)) != 0)
                return -EINVAL;
-       }
 
        start_fw_load(client);
 
index 5cc42b426715841ef2cf7c3d94972106e6e1ff72..14db901abb745188181d9a83ac063e032dcb3405 100644 (file)
@@ -3909,10 +3909,8 @@ static int pvr_boot(struct bttv *btv)
        int rc;
 
        rc = request_firmware(&fw_entry, "hcwamc.rbf", &btv->c.pci->dev);
-       if (rc != 0) {
-               pr_warn("%d: no altera firmware [via hotplug]\n", btv->c.nr);
+       if (rc != 0)
                return rc;
-       }
        rc = pvr_altera_load(btv, fw_entry->data, fw_entry->size);
        pr_info("%d: altera firmware upload %s\n",
                btv->c.nr, (rc < 0) ? "failed" : "ok");
index 543ace7a481a4a61661e28f065d542ee1a57f8de..a3f6b6271e3390095a4f41eed833b52935f89d85 100644 (file)
@@ -79,10 +79,8 @@ int cx18_av_loadfw(struct cx18 *cx)
        int i;
        int retries1 = 0;
 
-       if (request_firmware(&fw, FWFILE, &cx->pci_dev->dev) != 0) {
-               CX18_ERR_DEV(sd, "unable to open firmware %s\n", FWFILE);
+       if (request_firmware(&fw, FWFILE, &cx->pci_dev->dev) != 0)
                return -EINVAL;
-       }
 
        /* The firmware load often has byte errors, so allow for several
           retries, both at byte level and at the firmware load level. */
index 53f4d6bf81fb3aa6baa8ca307f68fdfd0c7b1f71..166379257f198a20dd57fc3c5bfd94b668e35662 100644 (file)
@@ -137,9 +137,7 @@ static int yuan_mpc718_mt352_reqfw(struct cx18_stream *stream,
        int ret;
 
        ret = request_firmware(fw, fn, &cx->pci_dev->dev);
-       if (ret)
-               CX18_ERR("Unable to open firmware file %s\n", fn);
-       else {
+       if (!ret) {
                size_t sz = (*fw)->size;
                if (sz < 2 || sz > 64 || (sz % 2) != 0) {
                        CX18_ERR("Firmware %s has a bad size: %lu bytes\n",
index 1b34ea1c3730561c5b24d6c6283072c3cb2dafbd..332299d46b50c716efeefcea363fb4ff6af327ce 100644 (file)
@@ -101,11 +101,8 @@ static int load_cpu_fw_direct(const char *fn, u8 __iomem *mem, struct cx18 *cx)
        u32 __iomem *dst = (u32 __iomem *)mem;
        const u32 *src;
 
-       if (request_firmware(&fw, fn, &cx->pci_dev->dev)) {
-               CX18_ERR("Unable to open firmware %s\n", fn);
-               CX18_ERR("Did you put the firmware in the hotplug firmware directory?\n");
+       if (request_firmware(&fw, fn, &cx->pci_dev->dev))
                return -ENOMEM;
-       }
 
        src = (const u32 *)fw->data;
 
@@ -146,8 +143,6 @@ static int load_apu_fw_direct(const char *fn, u8 __iomem *dst, struct cx18 *cx,
        int sz;
 
        if (request_firmware(&fw, fn, &cx->pci_dev->dev)) {
-               CX18_ERR("unable to open firmware %s\n", fn);
-               CX18_ERR("did you put the firmware in the hotplug firmware directory?\n");
                cx18_setup_page(cx, 0);
                return -ENOMEM;
        }
index a71f3c7569ce3fb9b331cc5f0ba8a1298816b54f..adf7ee5e8e4491f73e3a385a696f1db27633a06f 100644 (file)
@@ -929,12 +929,8 @@ static int cx23885_load_firmware(struct cx23885_dev *dev)
        retval = request_firmware(&firmware, CX23885_FIRM_IMAGE_NAME,
                                  &dev->pci->dev);
 
-       if (retval != 0) {
-               pr_err("ERROR: Hotplug firmware request failed (%s).\n",
-                      CX23885_FIRM_IMAGE_NAME);
-               pr_err("Please fix your hotplug setup, the board will not work without firmware loaded!\n");
+       if (retval != 0)
                return -1;
-       }
 
        if (firmware->size != CX23885_FIRM_IMAGE_SIZE) {
                pr_err("ERROR: Firmware size mismatch (have %zu, expected %d)\n",
index 28eab9c518c52418548a04d5045102c4d290d31b..e5070c9c1ee1559bf0115e259362c4a8fc0941a4 100644 (file)
@@ -2345,10 +2345,7 @@ void cx23885_card_setup(struct cx23885_dev *dev)
                        cinfo.rev, filename);
 
                ret = request_firmware(&fw, filename, &dev->pci->dev);
-               if (ret != 0)
-                       pr_err("did not find the firmware file. (%s) Please see linux/Documentation/dvb/ for more details on firmware-problems.",
-                              filename);
-               else
+               if (ret == 0)
                        altera_init(&netup_config, fw);
 
                release_firmware(fw);
index e3101f04941c0887b9ef6da3c30bbe98611f45ec..39534484a4e9482144773d986dc748b7640e4827 100644 (file)
@@ -471,12 +471,8 @@ static int blackbird_load_firmware(struct cx8802_dev *dev)
        retval = request_firmware(&firmware, CX2341X_FIRM_ENC_FILENAME,
                                  &dev->pci->dev);
 
-       if (retval != 0) {
-               pr_err("Hotplug firmware request failed (%s).\n",
-                      CX2341X_FIRM_ENC_FILENAME);
-               pr_err("Please fix your hotplug setup, the board will not work without firmware loaded!\n");
+       if (retval != 0)
                return -EIO;
-       }
 
        if (firmware->size != BLACKBIRD_FIRM_IMAGE_SIZE) {
                pr_err("Firmware size mismatch (have %zd, expected %d)\n",
index ba279fdb3df8c8f07f0b5b17a1f692f6e614da28..3928499f4682820f99a291d43abde00c2976a219 100644 (file)
@@ -80,8 +80,6 @@ retry:
                release_firmware(fw);
                return size;
        }
-       IVTV_ERR("Unable to open firmware %s (must be %ld bytes)\n", fn, size);
-       IVTV_ERR("Did you put the firmware in the hotplug firmware directory?\n");
        return -ENOMEM;
 }
 
index 8c92cb7f7e72f7af8ca6411ec60db81c8b95bbaa..e95cae1755ec457544f784006e02d6e3f3946c9a 100644 (file)
@@ -1252,13 +1252,8 @@ static int ngene_load_firm(struct ngene *dev)
                break;
        }
 
-       if (request_firmware(&fw, fw_name, &dev->pci_dev->dev) < 0) {
-               printk(KERN_ERR DEVICE_NAME
-                       ": Could not load firmware file %s.\n", fw_name);
-               printk(KERN_INFO DEVICE_NAME
-                       ": Copy %s to your hotplug directory!\n", fw_name);
+       if (request_firmware(&fw, fw_name, &dev->pci_dev->dev))
                return -1;
-       }
        if (size == 0)
                size = fw->size;
        if (size != fw->size) {
@@ -1266,8 +1261,6 @@ static int ngene_load_firm(struct ngene *dev)
                        ": Firmware %s has invalid size!", fw_name);
                err = -1;
        } else {
-               printk(KERN_INFO DEVICE_NAME
-                       ": Loading firmware file %s.\n", fw_name);
                ngene_fw = (u8 *) fw->data;
                err = ngene_command_load_firmware(dev, ngene_fw, size);
        }
index ef4906406ebf9aa67f527c9ac81707a1a786c373..5de3225e3c8848bae22a2ac1d68eab6f7443e283 100644 (file)
@@ -416,11 +416,8 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev)
                        __func__, fwname);
 
                ret = request_firmware(&fw, fwname, &dev->pci->dev);
-               if (ret) {
-                       printk(KERN_ERR "%s() Upload failed. (file not found?)\n",
-                              __func__);
+               if (ret)
                        return -ENOMEM;
-               }
 
                printk(KERN_INFO "%s() firmware read %zu bytes.\n",
                        __func__, fw->size);
index 6d415bdeef1877e274cf4f803370afa2d4779732..3f1b0e03ae4f9a23f4ffac2cd92212ab9d064b4d 100644 (file)
@@ -1515,13 +1515,8 @@ static int get_firmware(struct av7110* av7110)
        /* request the av7110 firmware, this will block until someone uploads it */
        ret = request_firmware(&fw, "dvb-ttpci-01.fw", &av7110->dev->pci->dev);
        if (ret) {
-               if (ret == -ENOENT) {
-                       printk(KERN_ERR "dvb-ttpci: could not load firmware, file not found: dvb-ttpci-01.fw\n");
-                       printk(KERN_ERR "dvb-ttpci: usually this should be in /usr/lib/hotplug/firmware or /lib/firmware\n");
-                       printk(KERN_ERR "dvb-ttpci: and can be downloaded from https://linuxtv.org/download/dvb/firmware/\n");
-               } else
-                       printk(KERN_ERR "dvb-ttpci: cannot request firmware (error %i)\n",
-                              ret);
+               if (ret == -ENOENT)
+                       printk(KERN_ERR "dvb-ttpci: firmware can be downloaded from https://linuxtv.org/download/dvb/firmware/\n");
                return -EINVAL;
        }
 
index b2b79bb739176c019aae693cc63de96690d47aad..a9c5230b55bfe3a3a433256110297046a58eb264 100644 (file)
@@ -247,11 +247,8 @@ int av7110_bootarm(struct av7110 *av7110)
        //saa7146_setgpio(dev, 3, SAA7146_GPIO_INPUT);
 
        ret = request_firmware(&fw, fw_name, &dev->pci->dev);
-       if (ret) {
-               printk(KERN_ERR "dvb-ttpci: Failed to load firmware \"%s\"\n",
-                       fw_name);
+       if (ret)
                return ret;
-       }
 
        mwdebi(av7110, DEBISWAB, DPRAM_BASE, fw->data, fw->size);
        release_firmware(fw);
index 69ef9c23a99aed111ec7632b8c5cecd194188ec6..242108154cdf30de81d257720091ce1f890e488e 100644 (file)
@@ -66,10 +66,8 @@ int s5p_mfc_load_firmware(struct s5p_mfc_dev *dev)
                }
        }
 
-       if (err != 0) {
-               mfc_err("Firmware is not present in the /lib/firmware directory nor compiled in kernel\n");
+       if (err != 0)
                return -EINVAL;
-       }
        if (fw_blob->size > dev->fw_buf.size) {
                mfc_err("MFC firmware is too big to be loaded\n");
                release_firmware(fw_blob);
index 3cbdc085c65df309dc5e43ec97e95806af21aa99..e12944c964f13877804de126f59956747033fa48 100644 (file)
@@ -510,11 +510,8 @@ static int wl1273_fm_upload_firmware_patch(struct wl1273_device *radio)
         * Uploading the firmware patch is not always necessary,
         * so we only print an info message.
         */
-       if (request_firmware(&fw_p, fw_name, dev)) {
-               dev_info(dev, "%s - %s not found\n", __func__, fw_name);
-
+       if (request_firmware(&fw_p, fw_name, dev))
                return 0;
-       }
 
        ptr = (__u8 *) fw_p->data;
        packet_num = ptr[0];
index 800d69c3f80b8677fb3e609198beb1a3ba251cee..b4fe26ee5f6f2636389b31b08bf3fc722003beb6 100644 (file)
@@ -1242,10 +1242,8 @@ static int fm_download_firmware(struct fmdev *fmdev, const u8 *fw_name)
 
        ret = request_firmware(&fw_entry, fw_name,
                                &fmdev->radio_dev->dev);
-       if (ret < 0) {
-               fmerr("Unable to read firmware(%s) content\n", fw_name);
+       if (ret)
                return ret;
-       }
        fmdbg("Firmware(%s) length : %zu bytes\n", fw_name, fw_entry->size);
 
        fw_data = (void *)fw_entry->data;
index b5b62b08159e0059d309283a7a7f9a1be20d3fd8..0dd3e339b4fe50c0230e3aca5abf6e96f61536f2 100644 (file)
@@ -1370,7 +1370,6 @@ static void load_firmware_cb(const struct firmware *fw,
 
        tuner_dbg("request_firmware_nowait(): %s\n", fw ? "OK" : "error");
        if (!fw) {
-               tuner_err("Could not load firmware %s.\n", priv->fname);
                priv->state = XC2028_NODEV;
                return;
        }
index 0efba0da0a451b93fbe7309ad49e391a40fd7fb2..3d66721a02787e903907121ffd066318e2d728e2 100644 (file)
@@ -921,11 +921,8 @@ static int apply_vp_patch(struct camera_data *cam)
        struct cpia2_command cmd;
 
        ret = request_firmware(&fw, fw_name, &cam->dev->dev);
-       if (ret) {
-               printk(KERN_ERR "cpia2: failed to load VP patch \"%s\"\n",
-                      fw_name);
+       if (ret)
                return ret;
-       }
 
        cmd.req_mode = CAMERAACCESS_TYPE_REPEAT | CAMERAACCESS_VP;
        cmd.direction = TRANSFER_WRITE;
index d538fa4077429a6f8dd95714d61ccb9824e58890..5222a98894f6129c81b53c56be66f4ac49647637 100644 (file)
@@ -995,11 +995,6 @@ static int cx231xx_load_firmware(struct cx231xx *dev)
                                  dev->dev);
 
        if (retval != 0) {
-               dev_err(dev->dev,
-                       "ERROR: Hotplug firmware request failed (%s).\n",
-                       CX231xx_FIRM_IMAGE_NAME);
-               dev_err(dev->dev,
-                       "Please fix your hotplug setup, the board will not work without firmware loaded!\n");
                vfree(p_current_fw);
                vfree(p_buffer);
                return retval;
index a9968fb1e8e4c8b28d962929e4f0124305d9c003..8b2aaa33f6983060a7354e80423a9bfd6f1d8c9f 100644 (file)
@@ -2412,12 +2412,9 @@ static int stk9090m_frontend_attach(struct dvb_usb_adapter *adap)
 
        dib9000_i2c_enumeration(&adap->dev->i2c_adap, 1, 0x10, 0x80);
 
-       if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev)) {
-               deb_info("%s: Upload failed. (file not found?)\n", __func__);
+       if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev))
                return -ENODEV;
-       } else {
-               deb_info("%s: firmware read %zu bytes.\n", __func__, state->frontend_firmware->size);
-       }
+       deb_info("%s: firmware read %zu bytes.\n", __func__, state->frontend_firmware->size);
        stk9090m_config.microcode_B_fe_size = state->frontend_firmware->size;
        stk9090m_config.microcode_B_fe_buffer = state->frontend_firmware->data;
 
@@ -2478,12 +2475,9 @@ static int nim9090md_frontend_attach(struct dvb_usb_adapter *adap)
        msleep(20);
        dib0700_set_gpio(adap->dev, GPIO0, GPIO_OUT, 1);
 
-       if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev)) {
-               deb_info("%s: Upload failed. (file not found?)\n", __func__);
+       if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev))
                return -EIO;
-       } else {
-               deb_info("%s: firmware read %zu bytes.\n", __func__, state->frontend_firmware->size);
-       }
+       deb_info("%s: firmware read %zu bytes.\n", __func__, state->frontend_firmware->size);
        nim9090md_config[0].microcode_B_fe_size = state->frontend_firmware->size;
        nim9090md_config[0].microcode_B_fe_buffer = state->frontend_firmware->data;
        nim9090md_config[1].microcode_B_fe_size = state->frontend_firmware->size;
index 15c153e49382d0c878e76d53cdd35789672ccdd3..95ca570054647fb72d4385e962f1531fbf73f4c8 100644 (file)
@@ -89,13 +89,9 @@ int dvb_usb_download_firmware(struct usb_device *udev, struct dvb_usb_device_pro
        int ret;
        const struct firmware *fw = NULL;
 
-       if ((ret = request_firmware(&fw, props->firmware, &udev->dev)) != 0) {
-               err("did not find the firmware file. (%s) Please see linux/Documentation/dvb/ for more details on firmware-problems. (%d)",
-                       props->firmware,ret);
+       ret = request_firmware(&fw, props->firmware, &udev->dev);
+       if (ret)
                return ret;
-       }
-
-       info("downloading firmware from file '%s'",props->firmware);
 
        switch (props->usb_ctrl) {
                case CYPRESS_AN2135:
index 37f062225ed213a00f54ed6dc551971a41c8f5c5..799dd015e4fbba79bfe273b03cac5663121ea5a8 100644 (file)
@@ -134,19 +134,14 @@ static int gp8psk_load_bcm4500fw(struct dvb_usb_device *d)
        const u8 *ptr;
        u8 *buf;
        if ((ret = request_firmware(&fw, bcm4500_firmware,
-                                       &d->udev->dev)) != 0) {
-               err("did not find the bcm4500 firmware file. (%s) Please see linux/Documentation/dvb/ for more details on firmware-problems. (%d)",
-                       bcm4500_firmware,ret);
+                                       &d->udev->dev)) != 0)
                return ret;
-       }
 
        ret = -EINVAL;
 
        if (gp8psk_usb_out_op(d, LOAD_BCM4500,1,0,NULL, 0))
                goto out_rel_fw;
 
-       info("downloading bcm4500 firmware from file '%s'",bcm4500_firmware);
-
        ptr = fw->data;
        buf = kmalloc(64, GFP_KERNEL | GFP_DMA);
        if (!buf) {
index 946a5ccc8f1a97e8117292810b5d9146bec96d79..4c557bff8aeae16e8c509c21b6dad0ac7b6fb6fa 100644 (file)
@@ -453,8 +453,6 @@ static int opera1_xilinx_load_firmware(struct usb_device *dev,
        info("start downloading fpga firmware %s",filename);
 
        if ((ret = request_firmware(&fw, filename, &dev->dev)) != 0) {
-               err("did not find the firmware file. (%s) Please see linux/Documentation/dvb/ for more details on firmware-problems.",
-                       filename);
                return ret;
        } else {
                p = kmalloc(fw->size, GFP_KERNEL);
index 05b1126f263ef234015261b010439f9fc6e75bc8..fc3f4dfaf67578ef08634640f9364efc1bdfe91d 100644 (file)
@@ -92,10 +92,8 @@ static int go7007_load_encoder(struct go7007 *go)
        u16 intr_val, intr_data;
 
        if (go->boot_fw == NULL) {
-               if (request_firmware(&fw_entry, fw_name, go->dev)) {
-                       v4l2_err(go, "unable to load firmware from file \"%s\"\n", fw_name);
+               if (request_firmware(&fw_entry, fw_name, go->dev))
                        return -1;
-               }
                if (fw_entry->size < 16 || memcmp(fw_entry->data, "WISGO7007FW", 11)) {
                        v4l2_err(go, "file \"%s\" does not appear to be go7007 firmware\n", fw_name);
                        release_firmware(fw_entry);
index 60bf5f0644d116f9d73e06b320740c0acaf5f786..23dc15d0a716cdfdeaa64efd3d2fea401d41bd7d 100644 (file)
@@ -1570,12 +1570,8 @@ int go7007_construct_fw_image(struct go7007 *go, u8 **fw, int *fwlen)
        default:
                return -1;
        }
-       if (request_firmware(&fw_entry, GO7007_FW_NAME, go->dev)) {
-               dev_err(go->dev,
-                       "unable to load firmware from file \"%s\"\n",
-                       GO7007_FW_NAME);
+       if (request_firmware(&fw_entry, GO7007_FW_NAME, go->dev))
                return -1;
-       }
        code = kzalloc(codespace * 2, GFP_KERNEL);
        if (code == NULL)
                goto fw_failed;
index 042f78a3128302f6615af845d6282f4b76d979e3..5623c5d550a960ee5435d7069ebcebeca17f3f03 100644 (file)
@@ -75,11 +75,8 @@ static int go7007_loader_probe(struct usb_interface *interface,
 
        dev_info(&interface->dev, "loading firmware %s\n", fw1);
 
-       if (request_firmware(&fw, fw1, &usbdev->dev)) {
-               dev_err(&interface->dev,
-                       "unable to load firmware from file \"%s\"\n", fw1);
+       if (request_firmware(&fw, fw1, &usbdev->dev))
                goto failed2;
-       }
        ret = cypress_load_firmware(usbdev, fw, CYPRESS_FX2);
        release_firmware(fw);
        if (0 != ret) {
@@ -90,11 +87,8 @@ static int go7007_loader_probe(struct usb_interface *interface,
        if (fw2 == NULL)
                return 0;
 
-       if (request_firmware(&fw, fw2, &usbdev->dev)) {
-               dev_err(&interface->dev,
-                       "unable to load firmware from file \"%s\"\n", fw2);
+       if (request_firmware(&fw, fw2, &usbdev->dev))
                goto failed2;
-       }
        ret = cypress_load_firmware(usbdev, fw, CYPRESS_FX2);
        release_firmware(fw);
        if (0 != ret) {
index 554b90ef2200bf928686e83bec938d8d4f6588a1..9272f83c66666d227233435dc576e835f4ad1c02 100644 (file)
@@ -239,10 +239,8 @@ static int sd_init(struct gspca_dev *gspca_dev)
 
        ret = request_ihex_firmware(&fw, VICAM_FIRMWARE,
                                    &gspca_dev->dev->dev);
-       if (ret) {
-               pr_err("Failed to load \"vicam/firmware.fw\": %d\n", ret);
+       if (ret)
                return ret;
-       }
 
        firmware_buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
        if (!firmware_buf) {
index 09bd6c6c176cb43f858da0dc2f83d3f0f8b52545..1f389790284597d22795a11c7ad06766f6a6cfb8 100644 (file)
@@ -1377,25 +1377,6 @@ static int pvr2_locate_firmware(struct pvr2_hdw *hdw,
                           "request_firmware fatal error with code=%d",ret);
                return ret;
        }
-       pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                  "***WARNING*** Device %s firmware seems to be missing.",
-                  fwtypename);
-       pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                  "Did you install the pvrusb2 firmware files in their proper location?");
-       if (fwcount == 1) {
-               pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                          "request_firmware unable to locate %s file %s",
-                          fwtypename,fwnames[0]);
-       } else {
-               pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                          "request_firmware unable to locate one of the following %s files:",
-                          fwtypename);
-               for (idx = 0; idx < fwcount; idx++) {
-                       pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                                  "request_firmware: Failed to find %s",
-                                  fwnames[idx]);
-               }
-       }
        return ret;
 }
 
index 7fee5766587a7c9660679882e4ca2060a6ee6700..b5a27d63abbddee606b9e2f648a9a95cc5eec66d 100644 (file)
@@ -2307,10 +2307,8 @@ static int s2255_probe(struct usb_interface *interface,
        }
        /* load the first chunk */
        if (request_firmware(&dev->fw_data->fw,
-                            FIRMWARE_FILE_NAME, &dev->udev->dev)) {
-               dev_err(&interface->dev, "sensoray 2255 failed to get firmware\n");
+                            FIRMWARE_FILE_NAME, &dev->udev->dev))
                goto errorREQFW;
-       }
        /* check the firmware is valid */
        fw_size = dev->fw_data->fw->size;
        pdata = (__le32 *) &dev->fw_data->fw->data[fw_size - 8];
index a142b9dc0feb2bb99be8cc728dc369710a5825a4..e4a8e7f45095f5d9e02742f42aacb6ff42919012 100644 (file)
@@ -296,10 +296,8 @@ static int ttusb_boot_dsp(struct ttusb *ttusb)
 
        err = request_firmware(&fw, "ttusb-budget/dspbootcode.bin",
                               &ttusb->dev->dev);
-       if (err) {
-               printk(KERN_ERR "ttusb-budget: failed to request firmware\n");
+       if (err)
                return err;
-       }
 
        /* BootBlock */
        b[0] = 0xaa;
index cdefb5dfbbdcda39fbe1bbc840c5042836d3bc15..3c02fe34baaab0fcd7c128c0d5d93c1bed4c0c56 100644 (file)
@@ -1344,11 +1344,8 @@ static int ttusb_dec_boot_dsp(struct ttusb_dec *dec)
        dprintk("%s\n", __func__);
 
        result = request_firmware(&fw_entry, dec->firmware_name, &dec->udev->dev);
-       if (result) {
-               printk(KERN_ERR "%s: Firmware (%s) unavailable.\n",
-                      __func__, dec->firmware_name);
+       if (result)
                return result;
-       }
 
        firmware = fw_entry->data;
        firmware_size = fw_entry->size;
index b77aacafc3fcd96bd52af1bb55a60123b22bdcf6..354d5b9c05717e4ce3c2cc0760150b12b398da41 100644 (file)
@@ -302,11 +302,8 @@ static long download_firmware(struct kim_data_s *kim_gdata)
            request_firmware(&kim_gdata->fw_entry, bts_scr_name,
                             &kim_gdata->kim_pdev->dev);
        if (unlikely((err != 0) || (kim_gdata->fw_entry->data == NULL) ||
-                    (kim_gdata->fw_entry->size == 0))) {
-               pr_err(" request_firmware failed(errno %ld) for %s", err,
-                          bts_scr_name);
+                    (kim_gdata->fw_entry->size == 0)))
                return -EINVAL;
-       }
        ptr = (void *)kim_gdata->fw_entry->data;
        len = kim_gdata->fw_entry->size;
        /* bts_header to remove out magic number and
index aac58ce6e371a806c4725be00108c7ac024bc0ae..7794c81c18179ae94343627e82780f31264e2891 100644 (file)
@@ -237,11 +237,8 @@ int softing_load_app_fw(const char *file, struct softing *card)
        int8_t type_end = 0, type_entrypoint = 0;
 
        ret = request_firmware(&fw, file, &card->pdev->dev);
-       if (ret) {
-               dev_alert(&card->pdev->dev, "request_firmware(%s) got %i\n",
-                       file, ret);
+       if (ret)
                return ret;
-       }
        dev_dbg(&card->pdev->dev, "firmware(%s) got %lu bytes\n",
                file, (unsigned long)fw->size);
        /* parse the firmware */
index be823c186517a54e6d0317263008267f30bfce9b..32b09d7ac69c79db332cac0890e1ba3a2cfb3ae4 100644 (file)
@@ -1283,11 +1283,8 @@ typhoon_request_firmware(struct typhoon *tp)
                return 0;
 
        err = request_firmware(&typhoon_fw, FIRMWARE_NAME, &tp->pdev->dev);
-       if (err) {
-               netdev_err(tp->dev, "Failed to load firmware \"%s\"\n",
-                          FIRMWARE_NAME);
+       if (err)
                return err;
-       }
 
        image_data = typhoon_fw->data;
        remaining = typhoon_fw->size;
index 3872ab96b80a39eecbb1d0b8150a2e8288915e46..5c09a2bfbd44580b6a4f0b735c2134a716dc6084 100644 (file)
@@ -1015,11 +1015,8 @@ static int netdev_open(struct net_device *dev)
 #endif /* VLAN_SUPPORT */
 
        retval = request_firmware(&fw_rx, FIRMWARE_RX, &np->pci_dev->dev);
-       if (retval) {
-               printk(KERN_ERR "starfire: Failed to load firmware \"%s\"\n",
-                      FIRMWARE_RX);
+       if (retval)
                goto out_init;
-       }
        if (fw_rx->size % 4) {
                printk(KERN_ERR "starfire: bogus length %zu in \"%s\"\n",
                       fw_rx->size, FIRMWARE_RX);
@@ -1027,11 +1024,8 @@ static int netdev_open(struct net_device *dev)
                goto out_rx;
        }
        retval = request_firmware(&fw_tx, FIRMWARE_TX, &np->pci_dev->dev);
-       if (retval) {
-               printk(KERN_ERR "starfire: Failed to load firmware \"%s\"\n",
-                      FIRMWARE_TX);
+       if (retval)
                goto out_rx;
-       }
        if (fw_tx->size % 4) {
                printk(KERN_ERR "starfire: bogus length %zu in \"%s\"\n",
                       fw_tx->size, FIRMWARE_TX);
index 0b60921c392f4d08c74c4cc8e8f0e72575b5853e..38e555d469c0829c2bcadb3461f273659316c231 100644 (file)
@@ -1063,11 +1063,8 @@ static int slic_load_rcvseq_firmware(struct slic_device *sdev)
        file = (sdev->model == SLIC_MODEL_OASIS) ?  SLIC_RCV_FIRMWARE_OASIS :
                                                    SLIC_RCV_FIRMWARE_MOJAVE;
        err = request_firmware(&fw, file, &sdev->pdev->dev);
-       if (err) {
-               dev_err(&sdev->pdev->dev,
-                       "failed to load receive sequencer firmware %s\n", file);
+       if (err)
                return err;
-       }
        /* Do an initial sanity check concerning firmware size now. A further
         * check follows below.
         */
@@ -1138,10 +1135,8 @@ static int slic_load_firmware(struct slic_device *sdev)
        file = (sdev->model == SLIC_MODEL_OASIS) ?  SLIC_FIRMWARE_OASIS :
                                                    SLIC_FIRMWARE_MOJAVE;
        err = request_firmware(&fw, file, &sdev->pdev->dev);
-       if (err) {
-               dev_err(&sdev->pdev->dev, "failed to load firmware %s\n", file);
+       if (err)
                return err;
-       }
        /* Do an initial sanity check concerning firmware size now. A further
         * check follows below.
         */
index a1a52eb53b145b1af7b0f414be3f8510a398f420..d8f3fc29f816ca82cf95b4a2de52b2fbce54c273 100644 (file)
@@ -2892,11 +2892,8 @@ static int ace_load_firmware(struct net_device *dev)
                fw_name = "acenic/tg1.bin";
 
        ret = request_firmware(&fw, fw_name, &ap->pdev->dev);
-       if (ret) {
-               printk(KERN_ERR "%s: Failed to load firmware \"%s\"\n",
-                      ap->name, fw_name);
+       if (ret)
                return ret;
-       }
 
        fw_data = (void *)fw->data;
 
index 7919f6112ecf95786e9f9a180fa248ef258428a5..c880aadbdf7bdd4c39737b77ebf45abbfa23d476 100644 (file)
@@ -3719,16 +3719,13 @@ static int bnx2_request_uncached_firmware(struct bnx2 *bp)
        }
 
        rc = request_firmware(&bp->mips_firmware, mips_fw_file, &bp->pdev->dev);
-       if (rc) {
-               pr_err("Can't load firmware file \"%s\"\n", mips_fw_file);
+       if (rc)
                goto out;
-       }
 
        rc = request_firmware(&bp->rv2p_firmware, rv2p_fw_file, &bp->pdev->dev);
-       if (rc) {
-               pr_err("Can't load firmware file \"%s\"\n", rv2p_fw_file);
+       if (rc)
                goto err_release_mips_firmware;
-       }
+
        mips_fw = (const struct bnx2_mips_fw_file *) bp->mips_firmware->data;
        rv2p_fw = (const struct bnx2_rv2p_fw_file *) bp->rv2p_firmware->data;
        if (bp->mips_firmware->size < sizeof(*mips_fw) ||
index ddd5d3ebd20111f667536aac61141b10e5bb2e7c..80d59b00b18dd1944ac9c779da1bb0f85cc52ece 100644 (file)
@@ -13504,11 +13504,8 @@ static int bnx2x_init_firmware(struct bnx2x *bp)
        BNX2X_DEV_INFO("Loading %s\n", fw_file_name);
 
        rc = request_firmware(&bp->firmware, fw_file_name, &bp->pdev->dev);
-       if (rc) {
-               BNX2X_ERR("Can't load firmware file %s\n",
-                         fw_file_name);
+       if (rc)
                goto request_firmware_exit;
-       }
 
        rc = bnx2x_check_firmware(bp);
        if (rc) {
index 8995cfefbfcf1aa1a46f1cbd2f1bdb6722dca7bb..f24e08711e4afb4b8c6bf8c4a8e1dfd89ded657e 100644 (file)
@@ -11367,11 +11367,8 @@ static int tg3_request_firmware(struct tg3 *tp)
 {
        const struct tg3_firmware_hdr *fw_hdr;
 
-       if (request_firmware(&tp->fw, tp->fw_needed, &tp->pdev->dev)) {
-               netdev_err(tp->dev, "Failed to load firmware \"%s\"\n",
-                          tp->fw_needed);
+       if (request_firmware(&tp->fw, tp->fw_needed, &tp->pdev->dev))
                return -ENOENT;
-       }
 
        fw_hdr = (struct tg3_firmware_hdr *)tp->fw->data;
 
index 2e7fb97883dc739959af77d9c0567b69da5d38c9..0f9ae5be8b6f476792f4e39d258fa8dd0208493e 100644 (file)
@@ -32,10 +32,8 @@ cna_read_firmware(struct pci_dev *pdev, u32 **bfi_image,
        const struct firmware *fw;
        u32 n;
 
-       if (request_firmware(&fw, fw_name, &pdev->dev)) {
-               dev_alert(&pdev->dev, "can't load firmware %s\n", fw_name);
+       if (request_firmware(&fw, fw_name, &pdev->dev))
                goto error;
-       }
 
        *bfi_image = (u32 *)fw->data;
        *bfi_image_size = fw->size/sizeof(u32);
index 6a015362c34066bf054aeb0f5f7168fbee190858..b008de119faf4752f134e0dce3af5abf96db1818 100644 (file)
@@ -1037,12 +1037,8 @@ int t3_get_edc_fw(struct cphy *phy, int edc_idx, int size)
        fw_name = get_edc_fw_name(edc_idx);
        if (fw_name)
                ret = request_firmware(&fw, fw_name, &adapter->pdev->dev);
-       if (ret < 0) {
-               dev_err(&adapter->pdev->dev,
-                       "could not upgrade firmware: unable to load %s\n",
-                       fw_name);
+       if (ret)
                return ret;
-       }
 
        /* check size, take checksum in account */
        if (fw->size > size + 4) {
@@ -1079,11 +1075,8 @@ static int upgrade_fw(struct adapter *adap)
        struct device *dev = &adap->pdev->dev;
 
        ret = request_firmware(&fw, FW_FNAME, dev);
-       if (ret < 0) {
-               dev_err(dev, "could not upgrade firmware: unable to load %s\n",
-                       FW_FNAME);
+       if (ret)
                return ret;
-       }
        ret = t3_load_fw(adap, fw->data, fw->size);
        release_firmware(fw);
 
@@ -1128,11 +1121,8 @@ static int update_tpsram(struct adapter *adap)
        snprintf(buf, sizeof(buf), TPSRAM_NAME, rev);
 
        ret = request_firmware(&tpsram, buf, dev);
-       if (ret < 0) {
-               dev_err(dev, "could not load TP SRAM: unable to load %s\n",
-                       buf);
+       if (ret)
                return ret;
-       }
 
        ret = t3_check_tpsram(adap, tpsram->data, tpsram->size);
        if (ret)
index 44b3937f7e81a43469553afbcae7f14becbf6316..096b8930b83e7b75c02290a272a3f47305fe0139 100644 (file)
@@ -1290,9 +1290,6 @@ static const struct firmware *e100_request_firmware(struct nic *nic)
 
        if (err) {
                if (required) {
-                       netif_err(nic, probe, nic->netdev,
-                                 "Failed to load firmware \"%s\": %d\n",
-                                 fw_name, err);
                        return ERR_PTR(err);
                } else {
                        netif_info(nic, probe, nic->netdev,
index 2521c8c40015de32abbb3f30dbf8f9d527126b6f..23737a39608b724e260f21becca5ad413ba9cbb1 100644 (file)
@@ -581,8 +581,6 @@ static int myri10ge_load_hotplug_firmware(struct myri10ge_priv *mgp, u32 * size)
        unsigned i;
 
        if ((status = request_firmware(&fw, mgp->fw_name, dev)) < 0) {
-               dev_err(dev, "Unable to load %s firmware image via hotplug\n",
-                       mgp->fw_name);
                status = -EINVAL;
                goto abort_with_nothing;
        }
index a55f430f6a7bcc9b9bba0fca597f821530d0c8e9..274701640961c1966b69e8bde305832d0f4d026c 100644 (file)
@@ -647,10 +647,8 @@ static int osi_load_firmware(struct pcmcia_device *link)
        int i, err;
 
        err = request_firmware(&fw, FIRMWARE_NAME, &link->dev);
-       if (err) {
-               pr_err("Failed to load firmware \"%s\"\n", FIRMWARE_NAME);
+       if (err)
                return err;
-       }
 
        /* Download the Seven of Diamonds firmware */
        for (i = 0; i < fw->size; i++) {
index 113bd57e2ea04188ce3bee349dc40522a4839832..b316675612b5fb4a05866109c6c2032050eb74fe 100644 (file)
@@ -817,11 +817,8 @@ static void cas_saturn_firmware_init(struct cas *cp)
                return;
 
        err = request_firmware(&fw, fw_name, &cp->pdev->dev);
-       if (err) {
-               pr_err("Failed to load firmware \"%s\"\n",
-                      fw_name);
+       if (err)
                return;
-       }
        if (fw->size < 2) {
                pr_err("bogus length %zu in \"%s\"\n",
                       fw->size, fw_name);
index 14c3632b8cde3cc95a25d98bc3ff826ed529205e..8f21ca19cfa6b7fa88d173dd88f2fafcc69bc50f 100644 (file)
@@ -372,11 +372,8 @@ static unsigned char *add_mcs(unsigned char *bits, int bitrate,
                }
                err = request_firmware(&fw, fw_name[predef], &pdev->dev);
                platform_device_unregister(pdev);
-               if (err) {
-                       printk(KERN_ERR "Failed to load firmware \"%s\"\n",
-                              fw_name[predef]);
+               if (err)
                        return NULL;
-               }
                if (fw->size != YAM_FPGA_SIZE) {
                        printk(KERN_ERR "Bogus length %zu in firmware \"%s\"\n",
                               fw->size, fw_name[predef]);
index f1605833c5cf1d7eebe5f7189f0c4e43ba32e5ad..bd8920a748ebee4781e78ab3ccd5eb310cbc432f 100644 (file)
@@ -390,10 +390,8 @@ static int kaweth_download_firmware(struct kaweth_device *kaweth,
        int ret;
 
        ret = request_firmware(&fw, fwname, &kaweth->dev->dev);
-       if (ret) {
-               dev_err(&kaweth->intf->dev, "Firmware request failed\n");
+       if (ret)
                return ret;
-       }
 
        if (fw->size > KAWETH_FIRMWARE_BUF_SIZE) {
                dev_err(&kaweth->intf->dev, "Firmware too big: %zu\n",
index a89b5685e68b36d5735bc9591f97f621440cb424..30e662e9bfaebe833f846e07afb9bb283d7eacb9 100644 (file)
@@ -1582,11 +1582,8 @@ int i2400m_dev_bootstrap(struct i2400m *i2400m, enum i2400m_bri flags)
                }
                d_printf(1, dev, "trying firmware %s (%d)\n", fw_name, itr);
                ret = request_firmware(&fw, fw_name, dev);
-               if (ret < 0) {
-                       dev_err(dev, "fw %s: cannot load file: %d\n",
-                               fw_name, ret);
+               if (ret)
                        continue;
-               }
                i2400m->fw_name = fw_name;
                ret = i2400m_fw_bootstrap(i2400m, fw, flags);
                release_firmware(fw);
@@ -1629,8 +1626,6 @@ void i2400m_fw_cache(struct i2400m *i2400m)
        kref_init(&i2400m_fw->kref);
        result = request_firmware(&i2400m_fw->fw, i2400m->fw_name, dev);
        if (result < 0) {
-               dev_err(dev, "firmware %s: failed to cache: %d\n",
-                       i2400m->fw_name, result);
                kfree(i2400m_fw);
                i2400m_fw = (void *) ~0;
        } else
index 56676eaff24c186f323fc79330b061e3d74e6ae5..075c90b61a85e6920719b1fbbd9638178a96172a 100644 (file)
@@ -1162,9 +1162,6 @@ static void ath9k_hif_usb_firmware_cb(const struct firmware *fw, void *context)
                if (!ret)
                        return;
 
-               dev_err(&hif_dev->udev->dev,
-                       "ath9k_htc: Failed to get firmware %s\n",
-                       hif_dev->fw_name);
                goto err_fw;
        }
 
index e7c3f3b8457dfda3d03652b3e2b838c8133e5306..460f20f6649ddafadb871fe3cff272f31e2a95b8 100644 (file)
@@ -1031,7 +1031,6 @@ static void carl9170_usb_firmware_step2(const struct firmware *fw,
                return;
        }
 
-       dev_err(&ar->udev->dev, "firmware not found.\n");
        carl9170_usb_firmware_failed(ar);
 }
 
index e99e766a302851e36b34f338cd819b6eaf616637..37bf3bb9d5bce06102bcd5493d538470f187b52a 100644 (file)
@@ -1622,13 +1622,8 @@ static struct fwentry *at76_load_firmware(struct usb_device *udev,
 
        at76_dbg(DBG_FW, "downloading firmware %s", fwe->fwname);
        ret = request_firmware(&fwe->fw, fwe->fwname, &udev->dev);
-       if (ret < 0) {
-               dev_err(&udev->dev, "firmware %s not found!\n",
-                       fwe->fwname);
-               dev_err(&udev->dev,
-                       "you may need to download the firmware from http://developer.berlios.de/projects/at76c503a/\n");
+       if (ret)
                goto exit;
-       }
 
        at76_dbg(DBG_FW, "got it.");
        fwh = (struct at76_fw_header *)(fwe->fw->data);
index c9dd5e44c9c6de6df122492fdac8eb30b2980c49..79396b7156d73749b143554d74c8530c31f1bd77 100644 (file)
@@ -3908,12 +3908,8 @@ static int reset_atmel_card(struct net_device *dev)
                                        strcpy(priv->firmware_id, "atmel_at76c502.bin");
                                }
                                err = request_firmware(&fw_entry, priv->firmware_id, priv->sys_dev);
-                               if (err != 0) {
-                                       printk(KERN_ALERT
-                                              "%s: firmware %s is missing, cannot continue.\n",
-                                              dev->name, priv->firmware_id);
+                               if (err != 0)
                                        return err;
-                               }
                        } else {
                                int fw_index = 0;
                                int success = 0;
index b37e7391f55defb4ded9635bdc15f55117789ba2..792e59cf140d26ab6fedb50d71d4417a27abdfe6 100644 (file)
@@ -2263,19 +2263,8 @@ int b43_do_request_fw(struct b43_request_fw_context *ctx,
        }
        err = request_firmware(&ctx->blob, ctx->fwname,
                               ctx->dev->dev->dev);
-       if (err == -ENOENT) {
-               snprintf(ctx->errors[ctx->req_type],
-                        sizeof(ctx->errors[ctx->req_type]),
-                        "Firmware file \"%s\" not found\n",
-                        ctx->fwname);
-               return err;
-       } else if (err) {
-               snprintf(ctx->errors[ctx->req_type],
-                        sizeof(ctx->errors[ctx->req_type]),
-                        "Firmware file \"%s\" request failed (err=%d)\n",
-                        ctx->fwname, err);
+       if (err)
                return err;
-       }
 fw_ready:
        if (ctx->blob->size < sizeof(struct b43_fw_header))
                goto err_format;
index f1e3dad576292ef5b8e2f03a01a8c185c927a101..dc5edad561000ae386bc4410bd2b40faf12824f7 100644 (file)
@@ -1554,11 +1554,8 @@ static int do_request_fw(struct b43legacy_wldev *dev,
        } else {
                err = request_firmware(fw, path, dev->dev->dev);
        }
-       if (err) {
-               b43legacyerr(dev->wl, "Firmware file \"%s\" not found "
-                      "or load failed.\n", path);
+       if (err)
                return err;
-       }
        if ((*fw)->size < sizeof(struct b43legacy_fw_header))
                goto err_format;
        hdr = (struct b43legacy_fw_header *)((*fw)->data);
index ddfdfe177e245cae6396145bc18500ed672f087f..e9a7709bd2d20ac08ca198287ec097af659ceada 100644 (file)
@@ -378,19 +378,13 @@ static int brcms_request_fw(struct brcms_info *wl, struct bcma_device *pdev)
                sprintf(fw_name, "%s-%d.fw", brcms_firmwares[i],
                        UCODE_LOADER_API_VER);
                status = request_firmware(&wl->fw.fw_bin[i], fw_name, device);
-               if (status) {
-                       wiphy_err(wl->wiphy, "%s: fail to load firmware %s\n",
-                                 KBUILD_MODNAME, fw_name);
+               if (status)
                        return status;
-               }
                sprintf(fw_name, "%s_hdr-%d.fw", brcms_firmwares[i],
                        UCODE_LOADER_API_VER);
                status = request_firmware(&wl->fw.fw_hdr[i], fw_name, device);
-               if (status) {
-                       wiphy_err(wl->wiphy, "%s: fail to load firmware %s\n",
-                                 KBUILD_MODNAME, fw_name);
+               if (status)
                        return status;
-               }
                wl->fw.hdr_num_entries[i] =
                    wl->fw.fw_hdr[i]->size / (sizeof(struct firmware_hdr));
        }
index 19c442cb93e4af2b50e72fe1c7b972cd0827c2f6..6ca5a3fd7acc2d02fe5d0f4dbbc8f7fcf1c7952b 100644 (file)
@@ -8417,12 +8417,8 @@ static int ipw2100_get_firmware(struct ipw2100_priv *priv,
 
        rc = request_firmware(&fw->fw_entry, fw_name, &priv->pci_dev->dev);
 
-       if (rc < 0) {
-               printk(KERN_ERR DRV_NAME ": "
-                      "%s: Firmware '%s' not available or load failed.\n",
-                      priv->net_dev->name, fw_name);
+       if (rc)
                return rc;
-       }
        IPW_DEBUG_INFO("firmware data %p size %zd\n", fw->fw_entry->data,
                       fw->fw_entry->size);
 
index 8da87496cb587f2ed92977649c6c31d12f1f32e8..d13e862f63578b32cd11c4b80aad21a36b5625c5 100644 (file)
@@ -3417,10 +3417,8 @@ static int ipw_get_fw(struct ipw_priv *priv,
 
        /* ask firmware_class module to get the boot firmware off disk */
        rc = request_firmware(raw, name, &priv->pci_dev->dev);
-       if (rc < 0) {
-               IPW_ERROR("%s request_firmware failed: Reason %d\n", name, rc);
+       if (rc)
                return rc;
-       }
 
        if ((*raw)->size < sizeof(*fw)) {
                IPW_ERROR("%s is too small (%zd)\n", name, (*raw)->size);
index 4b53ebf00c7ff195c3668679bced4c9adecdccf1..132d9406c1f4166cf9953d65b95271c39bcb7da8 100644 (file)
@@ -1861,7 +1861,6 @@ il3945_read_ucode(struct il_priv *il)
                sprintf(buf, "%s%u%s", name_pre, idx, ".ucode");
                ret = request_firmware(&ucode_raw, buf, &il->pci_dev->dev);
                if (ret < 0) {
-                       IL_ERR("%s firmware file req failed: %d\n", buf, ret);
                        if (ret == -ENOENT)
                                continue;
                        else
index 4b224d7d967cc3192a649778b5045f29429e43af..b211b1f7dda68f0c64f245c9f5c8b92ea8a4958b 100644 (file)
@@ -235,8 +235,6 @@ static int iwl_request_firmware(struct iwl_drv *drv, bool first)
        }
 
        if (drv->fw_index < cfg->ucode_api_min) {
-               IWL_ERR(drv, "no suitable firmware found!\n");
-
                if (cfg->ucode_api_min == cfg->ucode_api_max) {
                        IWL_ERR(drv, "%s%d is required\n", fw_pre_name,
                                cfg->ucode_api_max);
index 400a3521764406df48dbde06c5074ee298dd6c69..2559f7f1252c2bb8ba601bf0c780216c116659f5 100644 (file)
@@ -132,7 +132,6 @@ orinoco_dl_firmware(struct orinoco_private *priv,
                err = request_firmware(&fw_entry, firmware, priv->dev);
 
                if (err) {
-                       dev_err(dev, "Cannot find firmware %s\n", firmware);
                        err = -ENOENT;
                        goto free;
                }
@@ -292,10 +291,8 @@ symbol_dl_firmware(struct orinoco_private *priv,
        const struct firmware *fw_entry;
 
        if (!orinoco_cached_fw_get(priv, true)) {
-               if (request_firmware(&fw_entry, fw->pri_fw, priv->dev) != 0) {
-                       dev_err(dev, "Cannot find firmware: %s\n", fw->pri_fw);
+               if (request_firmware(&fw_entry, fw->pri_fw, priv->dev) != 0)
                        return -ENOENT;
-               }
        } else
                fw_entry = orinoco_cached_fw_get(priv, true);
 
@@ -311,10 +308,8 @@ symbol_dl_firmware(struct orinoco_private *priv,
        }
 
        if (!orinoco_cached_fw_get(priv, false)) {
-               if (request_firmware(&fw_entry, fw->sta_fw, priv->dev) != 0) {
-                       dev_err(dev, "Cannot find firmware: %s\n", fw->sta_fw);
+               if (request_firmware(&fw_entry, fw->sta_fw, priv->dev) != 0)
                        return -ENOENT;
-               }
        } else
                fw_entry = orinoco_cached_fw_get(priv, false);
 
index 94ad6fe29e69bdf199157e78023e15595e22daa9..67f1bcbe1d4fb3b0a22fda7153531615c25dfd65 100644 (file)
@@ -1677,7 +1677,6 @@ static int ezusb_probe(struct usb_interface *interface,
                if (ezusb_firmware_download(upriv, &firmware) < 0)
                        goto error;
        } else {
-               err("No firmware to download");
                goto error;
        }
 
index 27a49068d32d0a71e90b69c3a3b0289be956ff94..a12c388e3723f2becf21b769c0ad538fd8da9997 100644 (file)
@@ -499,7 +499,6 @@ static void p54p_firmware_step2(const struct firmware *fw,
        int err;
 
        if (!fw) {
-               dev_err(&pdev->dev, "Cannot find firmware (isl3886pci)\n");
                err = -ENOENT;
                goto out;
        }
index e41bf042352edbee19cb08efa0e34d7a8218fb9f..a004c27882675cd447b3b5822294bc765547724c 100644 (file)
@@ -170,10 +170,8 @@ static int p54spi_request_firmware(struct ieee80211_hw *dev)
        /* FIXME: should driver use it's own struct device? */
        ret = request_firmware(&priv->firmware, "3826.arm", &priv->spi->dev);
 
-       if (ret < 0) {
-               dev_err(&priv->spi->dev, "request_firmware() failed: %d", ret);
+       if (ret)
                return ret;
-       }
 
        ret = p54_parse_firmware(dev, priv->firmware);
        if (ret) {
index b0b86f7010610d1d89e37530f58ac7ea4a1fa137..4a82b47b4ab880e6eddb08df7fa5f8c0ee2f4d79 100644 (file)
@@ -929,7 +929,6 @@ static void p54u_load_firmware_cb(const struct firmware *firmware,
                err = p54u_start_ops(priv);
        } else {
                err = -ENOENT;
-               dev_err(&udev->dev, "Firmware not found.\n");
        }
 
        if (err) {
index 325176d4d796a6041488b0e2cd7fdffe3b2c4a08..1e33e0a9c1c41b2f06513c8d78b5ecfdff2b4a9a 100644 (file)
@@ -92,12 +92,9 @@ isl_upload_firmware(islpci_private *priv)
                const u32 *fw_ptr;
 
                rc = request_firmware(&fw_entry, priv->firmware, PRISM_FW_PDEV);
-               if (rc) {
-                       printk(KERN_ERR
-                              "%s: request_firmware() failed for '%s'\n",
-                              "prism54", priv->firmware);
+               if (rc)
                        return rc;
-               }
+
                /* prepare the Direct Memory Base register */
                reg = ISL38XX_DEV_FIRMWARE_ADDRES;
 
index 5153922e7ce180cfcbdce18e97ed569e79b3f14e..3bbb45a91be87b553fc0e9bd8625a03a29d78b70 100644 (file)
@@ -818,8 +818,6 @@ static int if_usb_prog_firmware(struct if_usb_card *cardp)
        kernel_param_lock(THIS_MODULE);
        ret = request_firmware(&cardp->fw, lbtf_fw_name, &cardp->udev->dev);
        if (ret < 0) {
-               pr_err("request_firmware() failed with %#x\n", ret);
-               pr_err("firmware %s not found\n", lbtf_fw_name);
                kernel_param_unlock(THIS_MODULE);
                goto done;
        }
index a96bd7e653bf739931865cbd172607da3ab2a0e8..b164442c22c27b92e942c71d9180f91b70e46997 100644 (file)
@@ -525,11 +525,8 @@ static int _mwifiex_fw_dpc(const struct firmware *firmware, void *context)
        struct wireless_dev *wdev;
        struct completion *fw_done = adapter->fw_done;
 
-       if (!firmware) {
-               mwifiex_dbg(adapter, ERROR,
-                           "Failed to get firmware %s\n", adapter->fw_name);
+       if (!firmware)
                goto err_dnld_fw;
-       }
 
        memset(&fw, 0, sizeof(struct mwifiex_fw_image));
        adapter->firmware = firmware;
index e813b2ca740c26ae6460ebe258c3280cb9cb2472..9353f019c43840cfedf857593e75b453c6209b7c 100644 (file)
@@ -5714,16 +5714,12 @@ static int mwl8k_firmware_load_success(struct mwl8k_priv *priv);
 static void mwl8k_fw_state_machine(const struct firmware *fw, void *context)
 {
        struct mwl8k_priv *priv = context;
-       struct mwl8k_device_info *di = priv->device_info;
        int rc;
 
        switch (priv->fw_state) {
        case FW_STATE_INIT:
-               if (!fw) {
-                       printk(KERN_ERR "%s: Error requesting helper fw %s\n",
-                              pci_name(priv->pdev), di->helper_image);
+               if (!fw)
                        goto fail;
-               }
                priv->fw_helper = fw;
                rc = mwl8k_request_fw(priv, priv->fw_pref, &priv->fw_ucode,
                                      true);
@@ -5758,11 +5754,8 @@ static void mwl8k_fw_state_machine(const struct firmware *fw, void *context)
                break;
 
        case FW_STATE_LOADING_ALT:
-               if (!fw) {
-                       printk(KERN_ERR "%s: Error requesting alt fw %s\n",
-                              pci_name(priv->pdev), di->helper_image);
+               if (!fw)
                        goto fail;
-               }
                priv->fw_ucode = fw;
                rc = mwl8k_firmware_load_success(priv);
                if (rc)
@@ -5800,10 +5793,8 @@ retry:
 
        /* Ask userland hotplug daemon for the device firmware */
        rc = mwl8k_request_firmware(priv, fw_image, nowait);
-       if (rc) {
-               wiphy_err(hw->wiphy, "Firmware files not found\n");
+       if (rc)
                return rc;
-       }
 
        if (nowait)
                return rc;
index 5813300f68a2c5b9cf58ec2cbdf74d70e68c1bb7..ecebea6f53874878c9dc47087354525fa42ee9c0 100644 (file)
@@ -49,10 +49,8 @@ static int rt2x00lib_request_firmware(struct rt2x00_dev *rt2x00dev)
        rt2x00_info(rt2x00dev, "Loading firmware file '%s'\n", fw_name);
 
        retval = request_firmware(&fw, fw_name, device);
-       if (retval) {
-               rt2x00_err(rt2x00dev, "Failed to request Firmware\n");
+       if (retval)
                return retval;
-       }
 
        if (!fw || !fw->size || !fw->data) {
                rt2x00_err(rt2x00dev, "Failed to read Firmware\n");
index 3cb88825473eccf9e3d41eacee39418b951c208d..f2947eec501365b24306fbece583362421d74c2b 100644 (file)
@@ -111,7 +111,6 @@ static void rtl_fw_do_work(const struct firmware *firmware, void *context,
                        if (!err)
                                goto found_alt;
                }
-               pr_err("Selected firmware is not available\n");
                rtlpriv->max_fw_size = 0;
                return;
        }
index d55554b7fa9a7835e54b9ca78737b30635002841..889c496ed6bfd6db3e570ba4e4ab7d48bb64a8dd 100644 (file)
@@ -92,7 +92,6 @@ static void rtl92se_fw_cb(const struct firmware *firmware, void *context)
                         "Firmware callback routine entered!\n");
        complete(&rtlpriv->firmware_loading_complete);
        if (!firmware) {
-               pr_err("Firmware %s not available\n", fw_name);
                rtlpriv->max_fw_size = 0;
                return;
        }
index 6d02c660b4ab785db914889c9819691c84b9a372..768824f8b76d1d7c507723a65bd12e8038ce6cdd 100644 (file)
@@ -71,10 +71,8 @@ static int wl1251_fetch_firmware(struct wl1251 *wl)
 
        ret = request_firmware(&fw, WL1251_FW_NAME, dev);
 
-       if (ret < 0) {
-               wl1251_error("could not get firmware: %d", ret);
+       if (ret)
                return ret;
-       }
 
        if (fw->size % 4) {
                wl1251_error("firmware size is not multiple of 32 bits: %zu",
@@ -110,10 +108,8 @@ static int wl1251_fetch_nvs(struct wl1251 *wl)
 
        ret = request_firmware(&fw, WL1251_NVS_NAME, dev);
 
-       if (ret < 0) {
-               wl1251_error("could not get nvs file: %d", ret);
+       if (ret)
                return ret;
-       }
 
        if (fw->size % 4) {
                wl1251_error("nvs size is not multiple of 32 bits: %zu",
index d47921a845098815652a46f7fc16cdf8bccf3488..47a8a4dfabf9df9651ecf7103de6b646370100bd 100644 (file)
@@ -756,10 +756,8 @@ static int wl12xx_fetch_firmware(struct wl1271 *wl, bool plt)
 
        ret = request_firmware(&fw, fw_name, wl->dev);
 
-       if (ret < 0) {
-               wl1271_error("could not get firmware %s: %d", fw_name, ret);
+       if (ret)
                return ret;
-       }
 
        if (fw->size % 4) {
                wl1271_error("firmware size is not multiple of 32 bits: %zu",
index 253403899fe98bf6b1f7588e9591a2ea8ae24bc7..0a886b35eb3ecb47771b1498993b031ffc22c2a6 100644 (file)
@@ -65,8 +65,6 @@ static int zd1201_fw_upload(struct usb_device *dev, int apfw)
 
        err = request_firmware(&fw_entry, fwfile, &dev->dev);
        if (err) {
-               dev_err(&dev->dev, "Failed to load %s firmware file!\n", fwfile);
-               dev_err(&dev->dev, "Make sure the hotplug firmware loader is installed.\n");
                dev_err(&dev->dev, "Goto http://linux-lc100020.sourceforge.net for more info.\n");
                return err;
        }
index c30bf118c67d81beced03f28279b11a838e02ad2..38450f37210e994eeb7214e39c9a56574e7f9dfd 100644 (file)
@@ -120,16 +120,9 @@ static void int_urb_complete(struct urb *urb);
 static int request_fw_file(
        const struct firmware **fw, const char *name, struct device *device)
 {
-       int r;
-
        dev_dbg_f(device, "fw name %s\n", name);
 
-       r = request_firmware(fw, name, device);
-       if (r)
-               dev_err(device,
-                      "Could not load firmware file %s. Error number %d\n",
-                      name, r);
-       return r;
+       return request_firmware(fw, name, device);
 }
 
 static inline u16 get_bcdDevice(const struct usb_device *udev)
index 24e57e770432ba7b4a40442505fafd5c3ffa9352..cd69f998a87ec1f3b0cc06a9f18d655db0f9924e 100644 (file)
@@ -4107,8 +4107,6 @@ static int AscInitAsc1000Driver(ASC_DVC_VAR *asc_dvc)
 
        err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                asc_dvc->err_code |= ASC_IERR_MCODE_CHKSUM;
                return err;
        }
@@ -4473,8 +4471,6 @@ static int AdvInitAsc3550Driver(ADV_DVC_VAR *asc_dvc)
 
        err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                asc_dvc->err_code = ASC_IERR_MCODE_CHKSUM;
                return err;
        }
@@ -4973,8 +4969,6 @@ static int AdvInitAsc38C0800Driver(ADV_DVC_VAR *asc_dvc)
 
        err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                asc_dvc->err_code = ASC_IERR_MCODE_CHKSUM;
                return err;
        }
@@ -5461,8 +5455,6 @@ static int AdvInitAsc38C1600Driver(ADV_DVC_VAR *asc_dvc)
 
        err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                asc_dvc->err_code = ASC_IERR_MCODE_CHKSUM;
                return err;
        }
index 6c838865ac5a7b32fd853aa36a07611e9809adc3..9e78670b7b768955c31a9cbdf48b5433db0a2097 100644 (file)
@@ -384,8 +384,6 @@ static ssize_t asd_store_update_bios(struct device *dev,
                                   filename_ptr,
                                   &asd_ha->pcidev->dev);
        if (err) {
-               asd_printk("Failed to load bios image file %s, error %d\n",
-                          filename_ptr, err);
                err = FAIL_OPEN_BIOS_FILE;
                goto out1;
        }
index da1e0568510d573877c891c56e9776bbb254525e..694cd0d7712123d62e87bee002a440af16ff1b48 100644 (file)
@@ -1317,11 +1317,8 @@ int asd_init_seqs(struct asd_ha_struct *asd_ha)
 
        err = asd_request_firmware(asd_ha);
 
-       if (err) {
-               asd_printk("Failed to load sequencer firmware file %s, error %d\n",
-                          SAS_RAZOR_SEQUENCER_FW_FILE, err);
+       if (err)
                return err;
-       }
 
        err = asd_seq_download_seqs(asd_ha);
        if (err) {
index cf04666868045d6e632dfda9a6fff39c4e8d88b1..1c2fec2bb5a3133784e6837ed742a41095b09279 100644 (file)
@@ -1756,7 +1756,6 @@ bfad_read_firmware(struct pci_dev *pdev, u32 **bfi_image,
        const struct firmware *fw;
 
        if (request_firmware(&fw, fw_name, &pdev->dev)) {
-               printk(KERN_ALERT "Can't locate firmware %s\n", fw_name);
                *bfi_image = NULL;
                goto out;
        }
index cc0187965eee95fe242ab853469ed21f92546d66..5da1dc787cbee6f4f5ff8eed49e8d70053df67a6 100644 (file)
@@ -4094,10 +4094,8 @@ static ssize_t ipr_store_update_fw(struct device *dev,
        if (endline)
                *endline = '\0';
 
-       if (request_firmware(&fw_entry, fname, &ioa_cfg->pdev->dev)) {
-               dev_err(&ioa_cfg->pdev->dev, "Firmware file %s not found\n", fname);
+       if (request_firmware(&fw_entry, fname, &ioa_cfg->pdev->dev))
                return -EIO;
-       }
 
        image_hdr = (struct ipr_ucode_image_header *)fw_entry->data;
 
index 596f3ff965f5bd9a3eea4beb0a9567b70b6543ac..1957bad62cab83963208371f680138135c62f5ba 100644 (file)
@@ -737,10 +737,6 @@ static ssize_t pm8001_store_update_fw(struct device *cdev,
                               pm8001_ha->dev);
 
        if (ret) {
-               PM8001_FAIL_DBG(pm8001_ha,
-                       pm8001_printk(
-                       "Failed to load firmware image file %s, error %d\n",
-                       filename_ptr, ret));
                pm8001_ha->fw_status = FAIL_OPEN_BIOS_FILE;
                goto out;
        }
index 390775d5c91888361ebaad09a5425a02217baaed..6ba21ca9b65ffa0f375056fc4a9f8f2c3d8618c3 100644 (file)
@@ -1552,8 +1552,6 @@ qla1280_request_firmware(struct scsi_qla_host *ha)
        err = request_firmware(&fw, fwname, &ha->pdev->dev);
 
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                fw = ERR_PTR(err);
                goto unlock;
        }
index 6082389f25c3dcfa221e33614c379b8811083802..10fc6189a7f4430876ef95c261f6470fcc3577dc 100644 (file)
@@ -6954,8 +6954,6 @@ qla2x00_load_risc(scsi_qla_host_t *vha, uint32_t *srisc_addr)
        /* Load firmware blob. */
        blob = qla2x00_request_firmware(vha);
        if (!blob) {
-               ql_log(ql_log_info, vha, 0x0083,
-                   "Firmware image unavailable.\n");
                ql_log(ql_log_info, vha, 0x0084,
                    "Firmware images can be retrieved from: "QLA_FW_URL ".\n");
                return QLA_FUNCTION_FAILED;
@@ -7057,8 +7055,6 @@ qla24xx_load_risc_blob(scsi_qla_host_t *vha, uint32_t *srisc_addr)
        /* Load firmware blob. */
        blob = qla2x00_request_firmware(vha);
        if (!blob) {
-               ql_log(ql_log_warn, vha, 0x0090,
-                   "Firmware image unavailable.\n");
                ql_log(ql_log_warn, vha, 0x0091,
                    "Firmware images can be retrieved from: "
                    QLA_FW_URL ".\n");
index a77c33987703678e07f05022c0fcd67844c09de8..05cceb9272111f90b93559dc9321e49dc8310f07 100644 (file)
@@ -2465,11 +2465,8 @@ try_blob_fw:
 
        /* Load firmware blob. */
        blob = ha->hablob = qla2x00_request_firmware(vha);
-       if (!blob) {
-               ql_log(ql_log_fatal, vha, 0x00a3,
-                   "Firmware image not present.\n");
+       if (!blob)
                goto fw_load_failed;
-       }
 
        /* Validating firmware blob */
        if (qla82xx_validate_firmware_blob(vha,
index 1f69e89b950f57130596e309a9648d81ad05e704..85d4ffbb2c836c640a67697c19d6fd6665477188 100644 (file)
@@ -6306,8 +6306,6 @@ qla2x00_request_firmware(scsi_qla_host_t *vha)
                goto out;
 
        if (request_firmware(&blob->fw, blob->name, &ha->pdev->dev)) {
-               ql_log(ql_log_warn, vha, 0x0063,
-                   "Failed to load firmware image (%s).\n", blob->name);
                blob->fw = NULL;
                blob = NULL;
                goto out;
index cec9a14982e6a3720afaf18633a8f39314a0c1e0..32ac993a3114492e8790049e0c60d08c2f559849 100644 (file)
@@ -475,11 +475,8 @@ static int qlogicpti_load_firmware(struct qlogicpti *qpti)
        int i, timeout;
 
        err = request_firmware(&fw, fwname, &qpti->op->dev);
-       if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
+       if (err)
                return err;
-       }
        if (fw->size % 2) {
                printk(KERN_ERR "Bogus length %zu in image \"%s\"\n",
                       fw->size, fwname);
index 6bd0717bf76e5519cc7f3d24fbadae43ba826ada..159e3daf1f569c8987bd12ca9d7fa2a7d5283b3c 100644 (file)
@@ -752,9 +752,6 @@ static int fw_load(struct IR_tx *tx)
        /* Request codeset data file */
        ret = request_firmware(&fw_entry, "haup-ir-blaster.bin", tx->ir->dev);
        if (ret != 0) {
-               dev_err(tx->ir->dev,
-                       "firmware haup-ir-blaster.bin not available (%d)\n",
-                       ret);
                ret = ret < 0 ? ret : -EFAULT;
                goto out;
        }
index 9c7e19aedff141cced9ecf80cc17d5ecbe9a4b22..0426ba201d5628528d6cc2fc08ffb9eca724ff94 100644 (file)
@@ -245,10 +245,8 @@ bool init_firmware(struct net_device *dev)
                 */
                if (rst_opt == OPT_SYSTEM_RESET) {
                        rc = request_firmware(&fw_entry, fw_name[init_step], &priv->udev->dev);
-                       if (rc < 0) {
-                               RT_TRACE(COMP_ERR, "request firmware fail!\n");
+                       if (rc)
                                goto download_firmware_fail;
-                       }
 
                        if (fw_entry->size > sizeof(pfirmware->firmware_buf)) {
                                RT_TRACE(COMP_ERR, "img file size exceed the container buffer fail!\n");
index de832b0b5eecf350b648be32302b629f6e3f3a1d..f43770b82ecf1e64c6d2dfd3f9fb22e112583c94 100644 (file)
@@ -67,8 +67,6 @@ int rtl871x_load_fw(struct _adapter *padapter)
        dev_info(dev, "r8712u: Loading firmware from \"%s\"\n", firmware_file);
        rc = request_firmware_nowait(THIS_MODULE, 1, firmware_file, dev,
                                     GFP_KERNEL, padapter, rtl871x_load_fw_cb);
-       if (rc)
-               dev_err(dev, "r8712u: Firmware request error %d\n", rc);
        return rc;
 }
 MODULE_FIRMWARE("rtlwifi/rtl8712u.bin");
index 093a6048bd223f0fb9898b17f3f51be3bfd88421..ebd33c3d05440376ae49940f2ff8f092b5775cf6 100644 (file)
@@ -49,11 +49,8 @@ int vnt_download_firmware(struct vnt_private *priv)
        dev_dbg(dev, "---->Download firmware\n");
 
        rc = request_firmware(&fw, FIRMWARE_NAME, dev);
-       if (rc) {
-               dev_err(dev, "firmware file %s request failed (%d)\n",
-                       FIRMWARE_NAME, rc);
-                       goto out;
-       }
+       if (rc)
+               goto out;
 
        buffer = kmalloc(FIRMWARE_CHUNK_SIZE, GFP_KERNEL);
        if (!buffer)
index cf0bde3bb927439a126913935d89bcdbc5fb6941..f53778f94aaa8be7fd503a64fb9e221026a407f9 100644 (file)
@@ -3489,10 +3489,8 @@ static int cyz_load_fw(struct pci_dev *pdev, void __iomem *base_addr,
        int retval;
 
        retval = request_firmware(&fw, "cyzfirm.bin", &pdev->dev);
-       if (retval) {
-               dev_err(&pdev->dev, "can't get firmware\n");
+       if (retval)
                goto err;
-       }
 
        /* Check whether the firmware is already loaded and running. If
           positive, skip this board */
index 68cbc03aab4b86e49a3f1f8904de52ef91f4b5c3..de45535e89b7a4ef2e4d0ebab1f9000ee4536b7e 100644 (file)
@@ -862,13 +862,8 @@ static int moxa_init_board(struct moxa_board_conf *brd, struct device *dev)
        }
 
        ret = request_firmware(&fw, file, dev);
-       if (ret) {
-               printk(KERN_ERR "MOXA: request_firmware failed. Make sure "
-                               "you've placed '%s' file into your firmware "
-                               "loader directory (e.g. /lib/firmware)\n",
-                               file);
+       if (ret)
                goto err_free;
-       }
 
        ret = moxa_load_fw(brd, fw);
 
index ad374f7c476d2f9ee56ab6aa2c025bb76e1f48aa..ff1dbcaab748a2956ec09f717de4e782f2e87570 100644 (file)
@@ -360,7 +360,6 @@ static void load_code(struct icom_port *icom_port)
 
        /* Load Call Setup into Adapter */
        if (request_firmware(&fw, "icom_call_setup.bin", &dev->dev) < 0) {
-               dev_err(&dev->dev,"Unable to load icom_call_setup.bin firmware image\n");
                status = -1;
                goto load_code_exit;
        }
@@ -380,7 +379,6 @@ static void load_code(struct icom_port *icom_port)
 
        /* Load Resident DCE portion of Adapter */
        if (request_firmware(&fw, "icom_res_dce.bin", &dev->dev) < 0) {
-               dev_err(&dev->dev,"Unable to load icom_res_dce.bin firmware image\n");
                status = -1;
                goto load_code_exit;
        }
@@ -425,7 +423,6 @@ static void load_code(struct icom_port *icom_port)
        }
 
        if (request_firmware(&fw, "icom_asc.bin", &dev->dev) < 0) {
-               dev_err(&dev->dev,"Unable to load icom_asc.bin firmware image\n");
                status = -1;
                goto load_code_exit;
        }
index 2b6376e6e5ad49ca89f5594cf387934bc560f227..d46635f7dbc0c7628d00cc8f779d396ee8fbe278 100644 (file)
@@ -1165,10 +1165,8 @@ static void uart_firmware_cont(const struct firmware *fw, void *context)
        struct device *dev = context;
        int ret;
 
-       if (!fw) {
-               dev_err(dev, "firmware not found\n");
+       if (!fw)
                return;
-       }
 
        firmware = (struct qe_firmware *) fw->data;
 
index 8af797252af206c9ad70aef7d65ee8106df2107f..3f1c105a04318aee29472b5d885708c75ab8ef6d 100644 (file)
@@ -1082,8 +1082,6 @@ static int cxacru_find_firmware(struct cxacru_data *instance,
                return -ENOENT;
        }
 
-       usb_info(usbatm, "found firmware %s\n", buf);
-
        return 0;
 }
 
index ab75690044bbd3b126609b971d109be20c9d5b24..e1f9f98f3bff11bc93f894ef3fb718636c0c8add 100644 (file)
@@ -650,10 +650,8 @@ static void uea_upload_pre_firmware(const struct firmware *fw_entry,
        int ret, size;
 
        uea_enters(usb);
-       if (!fw_entry) {
-               uea_err(usb, "firmware is not available\n");
+       if (!fw_entry)
                goto err;
-       }
 
        pfw = fw_entry->data;
        size = fw_entry->size;
@@ -748,10 +746,6 @@ static int uea_load_firmware(struct usb_device *usb, unsigned int ver)
        ret = request_firmware_nowait(THIS_MODULE, 1, fw_name, &usb->dev,
                                        GFP_KERNEL, usb,
                                        uea_upload_pre_firmware);
-       if (ret)
-               uea_err(usb, "firmware %s is not available\n", fw_name);
-       else
-               uea_info(usb, "loading firmware %s\n", fw_name);
 
        uea_leaves(usb);
        return ret;
@@ -913,12 +907,8 @@ static int request_dsp(struct uea_softc *sc)
        }
 
        ret = request_firmware(&sc->dsp_firm, dsp_name, &sc->usb_dev->dev);
-       if (ret < 0) {
-               uea_err(INS_TO_USBDEV(sc),
-                      "requesting firmware %s failed with error %d\n",
-                       dsp_name, ret);
+       if (ret)
                return ret;
-       }
 
        if (UEA_CHIP_VERSION(sc) == EAGLE_IV)
                ret = check_dsp_e4(sc->dsp_firm->data, sc->dsp_firm->size);
@@ -1631,12 +1621,8 @@ static int request_cmvs_old(struct uea_softc *sc,
 
        cmvs_file_name(sc, cmv_name, 1);
        ret = request_firmware(fw, cmv_name, &sc->usb_dev->dev);
-       if (ret < 0) {
-               uea_err(INS_TO_USBDEV(sc),
-                      "requesting firmware %s failed with error %d\n",
-                      cmv_name, ret);
+       if (ret)
                return ret;
-       }
 
        data = (u8 *) (*fw)->data;
        size = (*fw)->size;
@@ -1673,9 +1659,6 @@ static int request_cmvs(struct uea_softc *sc,
                                "try to get older cmvs\n", cmv_name);
                        return request_cmvs_old(sc, cmvs, fw);
                }
-               uea_err(INS_TO_USBDEV(sc),
-                      "requesting firmware %s failed with error %d\n",
-                      cmv_name, ret);
                return ret;
        }
 
@@ -1958,11 +1941,8 @@ static int load_XILINX_firmware(struct uea_softc *sc)
        uea_enters(INS_TO_USBDEV(sc));
 
        ret = request_firmware(&fw_entry, fw_name, &sc->usb_dev->dev);
-       if (ret) {
-               uea_err(INS_TO_USBDEV(sc), "firmware %s is not available\n",
-                      fw_name);
+       if (ret)
                goto err0;
-       }
 
        pfw = fw_entry->data;
        size = fw_entry->size;
index 24d841850e0561cb8ccf52fc9fcc896eccdeaffa..84e62e60c8a51e479d46bfa994e6d54430356aea 100644 (file)
@@ -85,21 +85,17 @@ static int emi26_load_firmware (struct usb_device *dev)
 
        err = request_ihex_firmware(&loader_fw, "emi26/loader.fw", &dev->dev);
        if (err)
-               goto nofw;
+               goto wraperr;
 
        err = request_ihex_firmware(&bitstream_fw, "emi26/bitstream.fw",
                                    &dev->dev);
        if (err)
-               goto nofw;
+               goto wraperr;
 
        err = request_ihex_firmware(&firmware_fw, "emi26/firmware.fw",
                                    &dev->dev);
-       if (err) {
-       nofw:
-               dev_err(&dev->dev, "%s - request_firmware() failed\n",
-                       __func__);
+       if (err)
                goto wraperr;
-       }
 
        /* Assert reset (stop the CPU in the EMI) */
        err = emi26_set_reset(dev,1);
index f058d80297616889a38813d05d4ed478a5e060ef..4457095c5ddea7585477f6fc73c3b80d825e1cb4 100644 (file)
@@ -76,12 +76,8 @@ static int ezusb_ihex_firmware_download(struct usb_device *dev,
        const struct ihex_binrec *record;
 
        if (request_ihex_firmware(&firmware, firmware_path,
-                                 &dev->dev)) {
-               dev_err(&dev->dev,
-                       "%s - request \"%s\" failed\n",
-                       __func__, firmware_path);
+                                 &dev->dev))
                goto out;
-       }
 
        ret = ezusb_set_reset(dev, fx.cpucs_reg, 0);
        if (ret < 0)
index 4d30095d6ad2193a6d6064891b67dda2a19ebb75..e217999b192385be1edbb6bf7101845b8a840369 100644 (file)
@@ -45,7 +45,6 @@ static int isight_firmware_load(struct usb_interface *intf,
                return -ENOMEM;
 
        if (request_firmware(&firmware, "isight.fw", &dev->dev) != 0) {
-               printk(KERN_ERR "Unable to load isight firmware\n");
                ret = -ENODEV;
                goto out;
        }
index 17283f4b4779719f0d7092febbc2649052bf595b..93a94e64e362ac071c7ae5b41408fab0018ba10a 100644 (file)
@@ -375,11 +375,8 @@ static void update_edgeport_E2PROM(struct edgeport_serial *edge_serial)
 
        response = request_ihex_firmware(&fw, fw_name,
                                         &edge_serial->serial->dev->dev);
-       if (response) {
-               dev_err(dev, "Failed to load image \"%s\" err %d\n",
-                      fw_name, response);
+       if (response)
                return;
-       }
 
        rec = (const struct ihex_binrec *)fw->data;
        BootMajorVersion = rec->data[0];
index 0fbadb37c1044b2ed6d19dfee45a9978d28a0267..96d7efe572f68bf5cf9ff44c2b2a312d9abfd291 100644 (file)
@@ -1010,8 +1010,6 @@ static int download_fw(struct edgeport_serial *serial)
 
        status = request_firmware(&fw, fw_name, dev);
        if (status) {
-               dev_err(dev, "Failed to load image \"%s\" err %d\n",
-                               fw_name, status);
                return status;
        }
 
index 6b22857f6e5212bfb7db7fd599cbde7e049f690d..71a2c669db798db56b9c49b403d614bbd2f5c70d 100644 (file)
@@ -1692,10 +1692,8 @@ static int ti_download_firmware(struct ti_device *tdev)
        }
 
 check_firmware:
-       if (status) {
-               dev_err(&dev->dev, "%s - firmware not found\n", __func__);
+       if (status)
                return -ENOENT;
-       }
        if (fw_p->size > TI_FIRMWARE_BUF_SIZE) {
                dev_err(&dev->dev, "%s - firmware too large %zu\n", __func__, fw_p->size);
                release_firmware(fw_p);
index 9f9a7bef1ff6d46d80fe8cb6dcfeea5a3e26729d..4b67783b3a56b20d39eccaaf24d654eb67d5ea6f 100644 (file)
@@ -743,10 +743,8 @@ static ssize_t broadsheet_loadstore_waveform(struct device *dev,
                return -EINVAL;
 
        err = request_firmware(&fw_entry, "broadsheet.wbf", dev);
-       if (err < 0) {
-               dev_err(dev, "Failed to get broadsheet waveform\n");
+       if (err)
                goto err_failed;
-       }
 
        /* try to enforce reasonable min max on waveform */
        if ((fw_entry->size < 8*1024) || (fw_entry->size > 64*1024)) {
index 9085e9525341e8c811e6e1432d4138d5194776a3..28b2751f454fc12c4e5ca35eb5a48d05c6b2bc3b 100644 (file)
@@ -679,10 +679,8 @@ static int metronomefb_probe(struct platform_device *dev)
                a) request the waveform file from userspace
                b) process waveform and decode into metromem */
        retval = request_firmware(&fw_entry, "metronome.wbf", &dev->dev);
-       if (retval < 0) {
-               dev_err(&dev->dev, "Failed to get waveform\n");
+       if (retval)
                goto err_csum_table;
-       }
 
        retval = load_waveform((u8 *) fw_entry->data, fw_entry->size, 3, 31,
                                par);
index 3014b86362bdcaff723bc45b3567fb7d5fb02e83..671cdfa7f310ff0d8de1eff04c67cada94be37ad 100644 (file)
@@ -71,10 +71,8 @@ int snd_vx_setup_firmware(struct vx_core *chip)
                if (! fw_files[chip->type][i])
                        continue;
                sprintf(path, "vx/%s", fw_files[chip->type][i]);
-               if (request_firmware(&fw, path, chip->dev)) {
-                       snd_printk(KERN_ERR "vx: can't load firmware %s\n", path);
+               if (request_firmware(&fw, path, chip->dev))
                        return -ENOENT;
-               }
                err = chip->ops->load_dsp(chip, i, fw);
                if (err < 0) {
                        release_firmware(fw);
index 45e561c425bfbdc02b89a090961b333facad898f..967dc809fc8bcf8e173e88989352af5b6d572bc8 100644 (file)
@@ -390,15 +390,11 @@ static int upload_dsp_code(struct snd_card *card)
        outb(HPBLKSEL_0, chip->io + HP_BLKS);
 
        err = request_firmware(&init_fw, INITCODEFILE, card->dev);
-       if (err < 0) {
-               printk(KERN_ERR LOGNAME ": Error loading " INITCODEFILE);
+       if (err)
                goto cleanup1;
-       }
        err = request_firmware(&perm_fw, PERMCODEFILE, card->dev);
-       if (err < 0) {
-               printk(KERN_ERR LOGNAME ": Error loading " PERMCODEFILE);
+       if (err)
                goto cleanup;
-       }
 
        memcpy_toio(chip->mappedbase, perm_fw->data, perm_fw->size);
        if (snd_msnd_upload_host(chip, init_fw->data, init_fw->size) < 0) {
index 733adee5afbf94915b2460a82723e8cf9a1dcf19..ed82489714e4cce5f594b8e436d536b757b5004a 100644 (file)
@@ -544,10 +544,8 @@ static int sscape_upload_bootblock(struct snd_card *card)
        int ret;
 
        ret = request_firmware(&init_fw, "scope.cod", card->dev);
-       if (ret < 0) {
-               snd_printk(KERN_ERR "sscape: Error loading scope.cod");
+       if (ret)
                return ret;
-       }
        ret = upload_dma_data(sscape, init_fw->data, init_fw->size);
 
        release_firmware(init_fw);
@@ -584,11 +582,8 @@ static int sscape_upload_microcode(struct snd_card *card, int version)
        snprintf(name, sizeof(name), "sndscape.co%d", version);
 
        err = request_firmware(&init_fw, name, card->dev);
-       if (err < 0) {
-               snd_printk(KERN_ERR "sscape: Error loading sndscape.co%d",
-                               version);
+       if (err)
                return err;
-       }
        err = upload_dma_data(sscape, init_fw->data, init_fw->size);
        if (err == 0)
                snd_printk(KERN_INFO "sscape: MIDI firmware loaded %zu KBs\n",
index 0b1e4b34b29965360843fd26994a034530b54725..ba260063af19ae22ee609620185174cf2aa51fd4 100644 (file)
@@ -1957,10 +1957,8 @@ wavefront_download_firmware (snd_wavefront_t *dev, char *path)
        const struct firmware *firmware;
 
        err = request_firmware(&firmware, path, dev->card->dev);
-       if (err < 0) {
-               snd_printk(KERN_ERR "firmware (%s) download failed!!!\n", path);
+       if (err)
                return 1;
-       }
 
        len = 0;
        buf = firmware->data;
index 3603c24f34d2d9a632223480fd5ec0d06023dd8b..bb748e14533e5af824e9eebae1e95239701dfb12 100644 (file)
@@ -46,8 +46,6 @@ short hpi_dsp_code_open(u32 adapter, void *os_data, struct dsp_code *dsp_code,
        err = request_firmware(&firmware, fw_name, &dev->dev);
 
        if (err || !firmware) {
-               dev_err(&dev->dev, "%d, request_firmware failed for %s\n",
-                       err, fw_name);
                goto error1;
        }
        if (firmware->size < sizeof(header)) {
index 0020fd0efc466b46e4482a106d80c23d33546504..f8366844c304054fc0a1ee6a1aa6abba6833d233 100644 (file)
@@ -3253,11 +3253,8 @@ int snd_cs46xx_start_dsp(struct snd_cs46xx *chip)
 #ifdef CONFIG_SND_CS46XX_NEW_DSP
        for (i = 0; i < CS46XX_DSP_MODULES; i++) {
                err = load_firmware(chip, &chip->modules[i], module_names[i]);
-               if (err < 0) {
-                       dev_err(chip->card->dev, "firmware load error [%s]\n",
-                                  module_names[i]);
+               if (err < 0)
                        return err;
-               }
                err = cs46xx_dsp_load_module(chip, chip->modules[i]);
                if (err < 0) {
                        dev_err(chip->card->dev, "image download error [%s]\n",
index d68f99e076a879def2241365e0dd78b3aeaa5611..ff0a1eeba612e9c76b4f21ac8e371b7265cfb8e2 100644 (file)
@@ -60,11 +60,8 @@ static int get_firmware(const struct firmware **fw_entry,
                "firmware requested: %s\n", card_fw[fw_index].data);
        snprintf(name, sizeof(name), "ea/%s", card_fw[fw_index].data);
        err = request_firmware(fw_entry, name, pci_device(chip));
-       if (err < 0)
-               dev_err(chip->card->dev,
-                       "get_firmware(): Firmware not available (%d)\n", err);
 #ifdef CONFIG_PM_SLEEP
-       else
+       if (!err)
                chip->fw_cache[fw_index] = *fw_entry;
 #endif
        return err;
index ccf4415a1c7b8461dea3ed1c9d69f67408b750e2..44482318308422527635ef235976ff70e2ec77c7 100644 (file)
@@ -887,10 +887,8 @@ static int snd_emu10k1_emu1010_init(struct snd_emu10k1 *emu)
        dev_info(emu->card->dev, "emu1010: EMU_HANA_ID = 0x%x\n", reg);
 
        err = snd_emu1010_load_firmware(emu, 0, &emu->firmware);
-       if (err < 0) {
-               dev_info(emu->card->dev, "emu1010: Loading Firmware failed\n");
+       if (err < 0)
                return err;
-       }
 
        /* ID, should read & 0x7f = 0x55 when FPGA programmed. */
        snd_emu1010_fpga_read(emu, EMU_HANA_ID, &reg);
index 96143df19b2150884fdea3d6eb26ea49fd65a874..d0b3a5d13cb899fed44ef2cdfdf6b9885956e455 100644 (file)
@@ -1959,10 +1959,8 @@ static void azx_firmware_cb(const struct firmware *fw, void *context)
        struct azx *chip = card->private_data;
        struct pci_dev *pci = chip->pci;
 
-       if (!fw) {
-               dev_err(card->dev, "Cannot load firmware, aborting\n");
+       if (!fw)
                goto error;
-       }
 
        chip->fw = fw;
        if (!chip->disabled) {
index c7b007164c991abad63026be35c6948bd44893ab..6f123fcd3e01c2645c8d50b133f507218b4ccc93 100644 (file)
@@ -2349,7 +2349,6 @@ static int snd_korg1212_create(struct snd_card *card, struct pci_dev *pci,
        err = request_firmware(&dsp_code, "korg/k1212.dsp", &pci->dev);
        if (err < 0) {
                release_firmware(dsp_code);
-               snd_printk(KERN_ERR "firmware not available\n");
                snd_korg1212_free(korg1212);
                return err;
        }
index 5bfd3ac80db5a24505a54fb133def69c13da5166..8dd77059a565bb26ba2d5066ed3b705d624ca0af 100644 (file)
@@ -571,11 +571,8 @@ int snd_mixart_setup_firmware(struct mixart_mgr *mgr)
 
        for (i = 0; i < 3; i++) {
                sprintf(path, "mixart/%s", fw_files[i]);
-               if (request_firmware(&fw_entry, path, &mgr->pci->dev)) {
-                       dev_err(&mgr->pci->dev,
-                               "miXart: can't load firmware %s\n", path);
+               if (request_firmware(&fw_entry, path, &mgr->pci->dev))
                        return -ENOENT;
-               }
                /* fake hwdep dsp record */
                err = mixart_dsp_load(mgr, i, fw_entry);
                release_firmware(fw_entry);
index a99808ab01fe58718787865984ffd5cbb50c841c..ec52c151c23548b54d11b15494e7f4b283af28bf 100644 (file)
@@ -385,12 +385,8 @@ int pcxhr_setup_firmware(struct pcxhr_mgr *mgr)
                if (!fw_files[fw_set][i])
                        continue;
                sprintf(path, "pcxhr/%s", fw_files[fw_set][i]);
-               if (request_firmware(&fw_entry, path, &mgr->pci->dev)) {
-                       dev_err(&mgr->pci->dev,
-                               "pcxhr: can't load firmware %s\n",
-                                  path);
+               if (request_firmware(&fw_entry, path, &mgr->pci->dev))
                        return -ENOENT;
-               }
                /* fake hwdep dsp record */
                err = pcxhr_dsp_load(mgr, i, fw_entry);
                release_firmware(fw_entry);
index 44f3b48d47b1000bafaa209752c30cac2c26b164..abb8e138d1c59dbcaca2da8bccdb08be4100c82b 100644 (file)
@@ -1231,11 +1231,8 @@ static int try_to_load_firmware(struct cmdif *cif, struct snd_riptide *chip)
        if (!chip->fw_entry) {
                err = request_firmware(&chip->fw_entry, "riptide.hex",
                                       &chip->pci->dev);
-               if (err) {
-                       snd_printk(KERN_ERR
-                                  "Riptide: Firmware not available %d\n", err);
+               if (err)
                        return -EIO;
-               }
        }
        err = loadfirmware(cif, chip->fw_entry->data, chip->fw_entry->size);
        if (err) {
index 1bff4b1b39cd04651f16efa1e151ca87c2804d9c..bd8aa49697cb0bd4959546c7540315eef73ee4b8 100644 (file)
@@ -5132,11 +5132,8 @@ static int hdsp_request_fw_loader(struct hdsp *hdsp)
                return -EINVAL;
        }
 
-       if (request_firmware(&fw, fwfile, &hdsp->pci->dev)) {
-               dev_err(hdsp->card->dev,
-                       "cannot load firmware %s\n", fwfile);
+       if (request_firmware(&fw, fwfile, &hdsp->pci->dev))
                return -ENOENT;
-       }
        if (fw->size < HDSP_FIRMWARE_SIZE) {
                dev_err(hdsp->card->dev,
                        "too short firmware size %d (expected %d)\n",
index 23cde3a0dc112427cdc5eec64619eb32b43a4595..a030693e7ea455a2801873142d1373b7dee1d5e1 100644 (file)
@@ -891,10 +891,8 @@ static int wm2000_i2c_probe(struct i2c_client *i2c,
        }
 
        ret = request_firmware(&fw, filename, &i2c->dev);
-       if (ret != 0) {
-               dev_err(&i2c->dev, "Failed to acquire ANC data: %d\n", ret);
+       if (ret != 0)
                goto err_supplies;
-       }
 
        /* Pre-cook the concatenation of the register address onto the image */
        wm2000->anc_download_size = fw->size + 2;
index 9520b4cd703853cf4f5672c37da344ee3b214cbc..858ad4dd36d1348051ecd75c6746809a5ef9762f 100644 (file)
@@ -219,8 +219,6 @@ static int usb6fire_fw_ezusb_upload(
        ret = request_firmware(&fw, fwname, &device->dev);
        if (ret < 0) {
                kfree(rec);
-               dev_err(&intf->dev,
-                       "error requesting ezusb firmware %s.\n", fwname);
                return ret;
        }
        ret = usb6fire_fw_ihex_init(fw, rec);
@@ -296,8 +294,6 @@ static int usb6fire_fw_fpga_upload(
 
        ret = request_firmware(&fw, fwname, &device->dev);
        if (ret < 0) {
-               dev_err(&intf->dev, "unable to get fpga firmware %s.\n",
-                               fwname);
                kfree(buffer);
                return -EIO;
        }