Icontheme: Clean up gtk_icon_info_load_async
authorTimm Bäder <mail@baedert.org>
Sun, 8 Sep 2019 09:10:01 +0000 (11:10 +0200)
committerTimm Bäder <mail@baedert.org>
Mon, 9 Sep 2019 15:36:27 +0000 (17:36 +0200)
gtk/gtkicontheme.c

index cee105f9c2c835f220521f146a67d00837cd9894..6a8d638313dc8de27d2ae88eecc2de72b8a465ac 100644 (file)
@@ -3677,28 +3677,27 @@ gtk_icon_info_load_icon_async (GtkIconInfo         *icon_info,
                                gpointer             user_data)
 {
   GTask *task;
-  GtkIconInfo *dup;
-  GError *error = NULL;
 
   task = g_task_new (icon_info, cancellable, callback, user_data);
 
   if (icon_info_get_pixbuf_ready (icon_info))
     {
+      GError *error = NULL;
       GdkPaintable *paintable = gtk_icon_info_load_icon (icon_info, &error);
 
       if (paintable == NULL)
         g_task_return_error (task, error);
       else
         g_task_return_pointer (task, paintable, g_object_unref);
-      g_object_unref (task);
     }
   else
     {
-      dup = icon_info_dup (icon_info);
+      GtkIconInfo *dup = icon_info_dup (icon_info);
       g_task_set_task_data (task, dup, g_object_unref);
       g_task_run_in_thread (task, load_icon_thread);
-      g_object_unref (task);
     }
+
+  g_object_unref (task);
 }
 
 /**