gdkcontext: Make has_unpack_subimage() do the version check
authorBenjamin Otte <otte@redhat.com>
Sat, 12 Aug 2023 20:13:07 +0000 (22:13 +0200)
committerMatthias Clasen <mclasen@redhat.com>
Thu, 24 Aug 2023 14:19:41 +0000 (10:19 -0400)
Makes the code look simpler when we actually use that function.

gdk/gdkglcontext.c
gsk/gl/gskglcommandqueue.c

index 43d644051000c7be17fee7bae6fd2e304bb47741..31c39467e5b51bb5b303ef70857c0b293d87bcac 100644 (file)
@@ -1528,7 +1528,8 @@ gdk_gl_context_check_extensions (GdkGLContext *context)
 
   if (gdk_gl_context_get_use_es (context))
     {
-      priv->has_unpack_subimage = epoxy_has_gl_extension ("GL_EXT_unpack_subimage");
+      priv->has_unpack_subimage = gdk_gl_version_greater_equal (&priv->gl_version, &GDK_GL_VERSION_INIT (3, 0)) ||
+                                  epoxy_has_gl_extension ("GL_EXT_unpack_subimage");
       priv->has_khr_debug = epoxy_has_gl_extension ("GL_KHR_debug");
     }
   else
index 4dd222b5d0b58aa0c5ba629c0c35cd3220433b7f..1cbd36850066641ee4fb36e8f1bec9056467e86b 100644 (file)
@@ -1595,8 +1595,7 @@ gsk_gl_command_queue_do_upload_texture_chunk (GskGLCommandQueue *self,
     {
       glTexSubImage2D (GL_TEXTURE_2D, 0, x, y, width, height, gl_format, gl_type, data);
     }
-  else if (stride % bpp == 0 &&
-           (gdk_gl_context_check_version (self->context, NULL, "3.0") || gdk_gl_context_has_unpack_subimage (self->context)))
+  else if (stride % bpp == 0 && gdk_gl_context_has_unpack_subimage (self->context))
     {
       glPixelStorei (GL_UNPACK_ROW_LENGTH, stride / bpp);