Fix macOS notification talk replies by avoiding early dealloc
authorClaudio Cambra <claudio.cambra@nextcloud.com>
Thu, 7 Sep 2023 06:28:47 +0000 (14:28 +0800)
committerbackportbot-nextcloud[bot] <backportbot-nextcloud[bot]@users.noreply.github.com>
Thu, 7 Sep 2023 11:48:58 +0000 (11:48 +0000)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
src/gui/systray.mm

index 505d18ec9955a7a7e66439905013a1dc8bac4eb7..707e3269fd429b388b0a23188a7ce655c7880e5d 100644 (file)
@@ -58,8 +58,8 @@ void sendTalkReply(UNNotificationResponse *response, UNNotificationContent* cont
                             << "Token:" << qToken
                             << "Account:" << qAccount;
 
-    const auto talkReply = QSharedPointer<OCC::TalkReply>::create(
-        accountState.data(), OCC::Systray::instance());
+    // OCC::TalkReply deletes itself once it's done, fire and forget
+    const auto talkReply = new OCC::TalkReply(accountState.data(), OCC::Systray::instance());
     talkReply->sendReplyMessage(qToken, qReply, qReplyTo);
 }