vulkan: Remove unneeded argument
authorBenjamin Otte <otte@redhat.com>
Tue, 9 May 2023 22:17:01 +0000 (00:17 +0200)
committerBenjamin Otte <otte@redhat.com>
Sun, 4 Jun 2023 17:42:01 +0000 (19:42 +0200)
The initial matrix can be computed as needed, so we don't need to
precompute it.

gsk/vulkan/gskvulkanrender.c
gsk/vulkan/gskvulkanrenderpass.c
gsk/vulkan/gskvulkanrenderpassprivate.h

index 20ee28a218918c1a5e3d7ee3b92a1abc2d4c6d20..8fc5bb777637596e38c83e181b7d1caabea228ba 100644 (file)
@@ -338,15 +338,11 @@ gsk_vulkan_render_add_node (GskVulkanRender *self,
                             GskRenderNode   *node)
 {
   GskVulkanRenderPass *pass;
-  graphene_matrix_t mv;
-
-  graphene_matrix_init_scale (&mv, self->scale, self->scale, 1.0);
 
   pass = gsk_vulkan_render_pass_new (self->vulkan,
                                      self->target,
                                      self->scale,
                                      self->scale,
-                                     &mv,
                                      &self->viewport,
                                      self->clip,
                                      VK_NULL_HANDLE);
index ac30272848f5c15a91b2005ba17dfdcb7b13eddd..47daaced16815903ebee8d4dc932a4b34f9a2734 100644 (file)
@@ -137,7 +137,6 @@ gsk_vulkan_render_pass_new (GdkVulkanContext  *context,
                             GskVulkanImage    *target,
                             float              scale_x,
                             float              scale_y,
-                            graphene_matrix_t *mv,
                             graphene_rect_t   *viewport,
                             cairo_region_t    *clip,
                             VkSemaphore        signal_semaphore)
@@ -155,7 +154,7 @@ gsk_vulkan_render_pass_new (GdkVulkanContext  *context,
   self->scale_x = scale_x;
   self->scale_y = scale_y;
 
-  self->mv = *mv;
+  graphene_matrix_init_scale (&self->mv, self->scale_x, self->scale_y, 1.0);
   graphene_matrix_init_ortho (&self->p,
                               viewport->origin.x, viewport->origin.x + viewport->size.width,
                               viewport->origin.y, viewport->origin.y + viewport->size.height,
@@ -1025,7 +1024,6 @@ gsk_vulkan_render_pass_render_offscreen (GdkVulkanContext      *vulkan,
   graphene_rect_t view;
   cairo_region_t *clip;
   GskVulkanRenderPass *pass;
-  graphene_matrix_t mv;
   GskVulkanImage *result;
 
   view = GRAPHENE_RECT_INIT (viewport->origin.x,
@@ -1052,13 +1050,10 @@ gsk_vulkan_render_pass_render_offscreen (GdkVulkanContext      *vulkan,
                                           gsk_vulkan_image_get_height (result)
                                         });
 
-  graphene_matrix_init_identity (&mv);
-
   pass = gsk_vulkan_render_pass_new (vulkan,
                                      result,
                                      1,
                                      1,
-                                     &mv,
                                      &view,
                                      clip,
                                      semaphore);
index e41418e1157c9290ff6de1c050df58f1990ea662..b1a5e90cfc1ab4589fdec22d6c7a8c7b5bfd5179 100644 (file)
@@ -14,7 +14,6 @@ GskVulkanRenderPass *   gsk_vulkan_render_pass_new                      (GdkVulk
                                                                          GskVulkanImage         *target,
                                                                          float                   scale_x,
                                                                          float                   scale_y,
-                                                                         graphene_matrix_t      *mv,
                                                                          graphene_rect_t        *viewport,
                                                                          cairo_region_t         *clip,
                                                                          VkSemaphore             signal_semaphore);