Jenkinsfile: Some comments

diff --git a/Jenkinsfile b/Jenkinsfile
index fc0acb898b882daa248ff4faf558e05709dfd9e6..f8d6f9dd72c458278e5e3ffcea814debc7c0aa22 100644 (file)
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -1,5 +1,12 @@
 #!groovy
 
+//
+// We now run the tests in Debug mode so that ASSERTs are triggered.
+// Ideally we should run the tests in both Debug and Release so we catch
+// all possible error combinations.
+// See also the top comment in syncenginetestutils.h
+//
+
 node('CLIENT') {
     stage 'Checkout'
         checkout scm
@@ -37,6 +44,8 @@ node('CLIENT') {
                ctest .
                '''
        }
+
+   // Stage 'macOS' TODO
 }
 
 

diff --git a/test/syncenginetestutils.h b/test/syncenginetestutils.h
index ee15d8e33bd6e789297c3e6e7327209bcbb7eb3c..997e5054e5419e2e1f9f671880e3db83f5c25326 100644 (file)
--- a/test/syncenginetestutils.h
+++ b/test/syncenginetestutils.h
@@ -17,6 +17,12 @@
 #include <QMap>
 #include <QtTest>
 
+/*
+ * TODO: In theory we should use QVERIFY instead of Q_ASSERT for testing, but this
+ * only works when directly called from a QTest :-(
+ */
+
+
 static const QUrl sRootUrl("owncloud://somehost/owncloud/remote.php/webdav/");
 static const QUrl sRootUrl2("owncloud://somehost/owncloud/remote.php/dav/files/admin/");
 static const QUrl sUploadUrl("owncloud://somehost/owncloud/remote.php/dav/uploads/admin/");