lib/repo: do no return a NULL on failure
authorLuca BRUNO <luca.bruno@coreos.com>
Tue, 7 Dec 2021 16:20:49 +0000 (16:20 +0000)
committerLuca BRUNO <luca.bruno@coreos.com>
Tue, 7 Dec 2021 16:24:56 +0000 (16:24 +0000)
This turns an existing check into an assert. The previously returned
NULL may result in confusing callers, as none of them is checking for
that.

src/libostree/ostree-repo.c

index f07d223508f5c326340fffbe809a8334510f0cb8..16636d709c140b016575c0c9e153da4b919b4a45 100644 (file)
@@ -1599,7 +1599,8 @@ _ostree_repo_update_mtime (OstreeRepo        *self,
 GKeyFile *
 ostree_repo_get_config (OstreeRepo *self)
 {
-  g_return_val_if_fail (self->inited, NULL);
+  g_assert (self != NULL);
+  g_assert (self->inited);
 
   return self->config;
 }
@@ -1617,7 +1618,8 @@ ostree_repo_copy_config (OstreeRepo *self)
   char *data;
   gsize len;
 
-  g_return_val_if_fail (self->inited, NULL);
+  g_assert (self != NULL);
+  g_assert (self->inited);
 
   copy = g_key_file_new ();
   data = g_key_file_to_data (self->config, &len, NULL);