SyncEngine: Don't duplicate fatal errors

Previously fatal error texts were duplicated: Once they entered the
SyncResult via the SyncFileItem and once via syncError().

syncError is intended for folder-wide sync issues that are not pinned
to particular files. Thus that duplicated path is removed.

For #5088

diff --git a/src/libsync/syncengine.cpp b/src/libsync/syncengine.cpp
index b5eef406f6180ebc89b83f292025e1caaab372a3..4e75da8e0e16497d9779a05c924020b2cceb2bf2 100644 (file)
--- a/src/libsync/syncengine.cpp
+++ b/src/libsync/syncengine.cpp
@@ -827,10 +827,6 @@ void SyncEngine::slotItemCompleted(const SyncFileItemPtr &item)
 {
     _progressInfo->setProgressComplete(*item);
 
-    if (item->_status == SyncFileItem::FatalError) {
-        syncError(item->_errorString);
-    }
-
     emit transmissionProgress(*_progressInfo);
     emit itemCompleted(item);
 }