Adwaita: Fix ineffective theming of switch slider

in a specific case, which was applying .slider as a class on the parent
switch, instead of correctly selecting on its child node named slider.

This makes the border on the outside of a switch in a selected listbox
row look better in the light variant. Since the code was never removed,
it was clearly meant to work, and making it work is a clear improvement.

diff --git a/gtk/theme/Adwaita/_common.scss b/gtk/theme/Adwaita/_common.scss
index d86eea49b4e9b389d8bb831a0f01532e32af0f42..041a60bcce243779eb97c1995d0041d1ab960bd5 100644 (file)
--- a/gtk/theme/Adwaita/_common.scss
+++ b/gtk/theme/Adwaita/_common.scss
@@ -2642,10 +2642,10 @@ switch {
 
       &:backdrop { border-color: $selected_borders_color; }
 
-      &.slider:dir(rtl) { border-left-color: $borders_color; }
-      &.slider:dir(ltr) { border-right-color: $borders_color; }
+      slider:dir(rtl) { border-left-color: $borders_color; }
+      slider:dir(ltr) { border-right-color: $borders_color; }
 
-      &.slider { &:checked, & { border-color: $selected_borders_color; } }
+      slider { &:checked, & { border-color: $selected_borders_color; } }
     }
   }
 }

diff --git a/gtk/theme/Adwaita/gtk-contained.css b/gtk/theme/Adwaita/gtk-contained.css
index e2fdc5d6319d971c33c0bc57720d7d24a37975b1..df03679afd3514a42deaeb633af5eb8fe4e30b25 100644 (file)
--- a/gtk/theme/Adwaita/gtk-contained.css
+++ b/gtk/theme/Adwaita/gtk-contained.css
@@ -1085,11 +1085,11 @@ row:selected switch { box-shadow: none; border-color: #184472; }
 
 row:selected switch:backdrop { border-color: #184472; }
 
-row:selected switch.slider:dir(rtl) { border-left-color: #b6b6b3; }
+row:selected switch slider:dir(rtl) { border-left-color: #b6b6b3; }
 
-row:selected switch.slider:dir(ltr) { border-right-color: #b6b6b3; }
+row:selected switch slider:dir(ltr) { border-right-color: #b6b6b3; }
 
-row:selected switch.slider:checked, row:selected switch.slider { border-color: #184472; }
+row:selected switch slider:checked, row:selected switch slider { border-color: #184472; }
 
 /************************* Check and Radio items * */
 .view.content-view.check:not(list), iconview.content-view.check:not(list), .content-view .tile check:not(list) { -gtk-icon-shadow: none; -gtk-icon-source: -gtk-scaled(url("assets/checkbox-selectionmode.png"), url("assets/checkbox-selectionmode@2.png")); background-color: transparent; min-width: 40px; min-height: 40px; background-image: none; transition: none; box-shadow: none; border-width: 0; }