libxl: Do not provide arbitrary string as format specifier to printf.
authorKeir Fraser <keir.fraser@citrix.com>
Thu, 27 May 2010 07:26:52 +0000 (08:26 +0100)
committerKeir Fraser <keir.fraser@citrix.com>
Thu, 27 May 2010 07:26:52 +0000 (08:26 +0100)
Original patch from Dulloor <dulloor@gmail.com>
Signed-off-by: Keir Fraser <keir.fraser@citrix.com>
tools/libxl/xl_cmdimpl.c

index 0fe6be9116944025bc15add792ebc4d043e6b6ce..85c6e1b1297d8e09ead926f44a5f3bf6e456e713 100644 (file)
@@ -3267,13 +3267,8 @@ int main_dmesg(int argc, char **argv)
     if (!cr)
         goto finish;
 
-    while (1) {
-        ret = libxl_xen_console_read_line(&ctx, cr, &line);
-        if (ret > 0)
-            printf(line);
-        else
-            break;
-    }
+    while ((ret = libxl_xen_console_read_line(&ctx, cr, &line)) > 0)
+        printf("%s", line);
 
 finish:
     libxl_xen_console_read_finish(&ctx, cr);