Don't use int literals for bools

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>

diff --git a/src/common/syncjournaldb.cpp b/src/common/syncjournaldb.cpp
index 412b21810f80241a0bb6657e544c964062ffa58b..7a1de154d8b070041ff24d4de86c1ae3474937c0 100644 (file)
--- a/src/common/syncjournaldb.cpp
+++ b/src/common/syncjournaldb.cpp
@@ -665,7 +665,7 @@ bool SyncJournalDb::updateMetadataTableStructure()
         commitInternal("update database structure: add filesize col");
     }
 
-    if (1) {
+    if (true) {
         SqlQuery query(_db);
         query.prepare("CREATE INDEX IF NOT EXISTS metadata_inode ON metadata(inode);");
         if (!query.exec()) {
@@ -675,7 +675,7 @@ bool SyncJournalDb::updateMetadataTableStructure()
         commitInternal("update database structure: add inode index");
     }
 
-    if (1) {
+    if (true) {
         SqlQuery query(_db);
         query.prepare("CREATE INDEX IF NOT EXISTS metadata_path ON metadata(path);");
         if (!query.exec()) {

diff --git a/src/csync/csync.cpp b/src/csync/csync.cpp
index caee4146df28a60ff2545fab548fea32080b7377..eea6322c0afb0a402ca168e501c900c84ecb0035 100644 (file)
--- a/src/csync/csync.cpp
+++ b/src/csync/csync.cpp
@@ -234,7 +234,7 @@ int csync_s::reinitialize() {
 
   status_code = CSYNC_STATUS_OK;
 
-  remote.read_from_db = 0;
+  remote.read_from_db = false;
   read_remote_from_db = true;
 
   local.files.clear();

diff --git a/test/testutility.cpp b/test/testutility.cpp
index 6f5070cb63e4af474e3c59537a4168dd343705a6..620548ba36568f9bee01f09a68f1acf84c882250 100644 (file)
--- a/test/testutility.cpp
+++ b/test/testutility.cpp
@@ -156,9 +156,9 @@ private slots:
     {
         QVERIFY(isMac() || isWindows() ? fsCasePreserving() : ! fsCasePreserving());
         QScopedValueRollback<bool> scope(OCC::fsCasePreserving_override);
-        OCC::fsCasePreserving_override = 1;
+        OCC::fsCasePreserving_override = true;
         QVERIFY(fsCasePreserving());
-        OCC::fsCasePreserving_override = 0;
+        OCC::fsCasePreserving_override = false;
         QVERIFY(! fsCasePreserving());
     }