build: Fix build when using -fno-inline
authorAndrew Cooper <andrew.cooper3@citrix.com>
Tue, 9 Oct 2012 11:41:46 +0000 (12:41 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Tue, 9 Oct 2012 11:41:46 +0000 (12:41 +0100)
struct task_slice.migrated is not initialised by this function, and
subsequently returned by value, leading to the error:

sched_sedf.c: In function ‘sedf_do_extra_schedule’:
sched_sedf.c:711: error: ‘ret.migrated’ may be used uninitialised in
this function

for both gcc 4.1.2 and 4.4.3 (which are the two I have easily to hand)
when combined with the -fno-inline compile option.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Committed-by: Keir Fraser <keir@xen.org>
xen/common/sched_sedf.c

index 644787bc7fede2ba98893f0be0ee7d785d08deeb..66c6d68ada564085065562cf23a311a25c7857c7 100644 (file)
@@ -667,7 +667,7 @@ static void desched_extra_dom(s_time_t now, struct vcpu *d)
 static struct task_slice sedf_do_extra_schedule(
     s_time_t now, s_time_t end_xt, struct list_head *extraq[], int cpu)
 {
-    struct task_slice   ret;
+    struct task_slice   ret = { 0 };
     struct sedf_vcpu_info *runinf;
     ASSERT(end_xt > now);