a11y atspi: Fix reporting table cell pos at index (0,0)
authorMichael Weghorn <m.weghorn@posteo.de>
Fri, 7 Jul 2023 13:23:06 +0000 (15:23 +0200)
committerSimon McVittie <smcv@debian.org>
Wed, 8 Nov 2023 16:30:21 +0000 (16:30 +0000)
Table (cell) row and column indices both start at 0, so
an index of 0 is valid.

Adapt the check accordingly and check for non-negative
indices instead of positive ones.

(`gtk_cell_accessible_parent_get_cell_position` sets -1
in the fallback case, so that's still handled as it used
to be.)

This fixes reporting the position of the table cell at
index (0,0) via AT-SPI.

Bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/5161
Forwarded: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/6173
Origin: 3.24.39, commit:89517775183fa17f77c2cfc413dec86e751c3496

Gbp-Pq: Name a11y-atspi-Fix-reporting-table-cell-pos-at-index-0-0.patch

gtk/a11y/gtkcellaccessible.c

index 239032331ef99134061209aae85423f6459946c5..cdae20f00c500b51fd7c43c2c0f6164362ba58d4 100644 (file)
@@ -401,7 +401,7 @@ gtk_cell_accessible_get_position (AtkTableCell *table_cell,
   gtk_cell_accessible_parent_get_cell_position (GTK_CELL_ACCESSIBLE_PARENT (parent),
                                                 cell,
                                                 row, column);
-  return ((row && *row > 0) || (column && *column > 0));
+  return ((row && *row >= 0) || (column && *column >= 0));
 }
 
 static int