cmd/snap-seccomp: skip tests that use -m32
authorZygmunt Krynicki <me@zygoon.pl>
Thu, 17 Jan 2019 15:21:22 +0000 (17:21 +0200)
committerZygmunt Krynicki <me@zygoon.pl>
Thu, 19 Sep 2024 12:43:40 +0000 (14:43 +0200)
Apparently Debian's amd64 compiler somehow cannot compile -m32 mode
binaries. The compilation error is:

multipass@debian-10:~/packaging/snapd/cmd/snap-seccomp$ go test
cannot build multi-lib syscall runner: exit status 1
In file included from /usr/include/errno.h:25,
 from /tmp/check-3806730340354206876/1/seccomp_syscall_runner.c:3:
/usr/include/features.h:424:12: fatal error: sys/cdefs.h: No such file or directory
 #  include <sys/cdefs.h>
    ^~~~~~~~~~~~~
compilation terminated.
OK: 2 passed, 11 skipped

I was unable to resolve this issue, let's disable this test until we can get to
the bottom of it.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
Gbp-Pq: Name 0003-cmd-snap-seccomp-skip-tests-that-use-m32.patch

cmd/snap-seccomp/main_test.go

index 0706c0ee1b7b75457582139726b5801739a63d07..9f98c3930c5c9f224a2b900f6a89afcc90e2da45 100644 (file)
@@ -226,6 +226,14 @@ func (s *snapSeccompSuite) SetUpSuite(c *C) {
        // Ideally we would build for ppc64el->powerpc and arm64->armhf but
        // it seems tricky to find the right gcc-multilib for this.
        if arch.DpkgArchitecture() == "amd64" && s.canCheckCompatArch {
+               // This test fails on Debian amd64
+               // cannot build multi-lib syscall runner: exit status 1
+               // In file included from /usr/include/errno.h:25,
+               //                  from /tmp/check-3806730340354206876/1/seccomp_syscall_runner.c:3:
+               // /usr/include/features.h:424:12: fatal error: sys/cdefs.h: No such file or directory
+               //  #  include <sys/cdefs.h>
+               //             ^~~~~~~~~~~~~
+               c.Skip(`This test fails to build on Debian amd64`)
                cmd = exec.Command(cmd.Args[0], cmd.Args[1:]...)
                cmd.Args = append(cmd.Args, "-m32")
                for i, k := range cmd.Args {