Fix ruby-mode.el command injection vulnerability (CVE-2022-48338)
authorXi Lu <lx@shellcodes.org>
Fri, 23 Dec 2022 04:52:48 +0000 (12:52 +0800)
committerSean Whitton <spwhitton@spwhitton.name>
Wed, 22 Feb 2023 17:50:42 +0000 (10:50 -0700)
This upstream patch has been incorporated to fix the problem:

  Fix ruby-mode.el local command injection vulnerability (bug#60268)

  * lisp/progmodes/ruby-mode.el
  (ruby-find-library-file): Fix local command injection vulnerability.

Origin: upstream, commit 22fb5ff5126dc8bb01edaa0252829d853afb284f
Bug: https://debbugs.gnu.org/60268
Bug-Debian: https://bugs.debian.org/1031730
Forwarded: not-needed

lisp/progmodes/ruby-mode.el

index 72631a6557fc50ba1367066d423f5aa3e0265432..9b05b04a52cf333d54ef5b786643ab1324ccf510 100644 (file)
@@ -1819,7 +1819,7 @@ or `gem' statement around point."
       (setq feature-name (read-string "Feature name: " init))))
   (let ((out
          (substring
-          (shell-command-to-string (concat "gem which " feature-name))
+          (shell-command-to-string (concat "gem which " (shell-quote-argument feature-name)))
           0 -1)))
     (if (string-match-p "\\`ERROR" out)
         (user-error "%s" out)