Let checksumType() read the config to destinguish checksum type.
authorKlaas Freitag <freitag@owncloud.com>
Thu, 21 May 2015 12:30:21 +0000 (14:30 +0200)
committerKlaas Freitag <freitag@owncloud.com>
Thu, 21 May 2015 12:30:21 +0000 (14:30 +0200)
src/libsync/transmissionchecksumvalidator.cpp

index b01f9e09a5c70d264d79f25793f4679e5008e46a..8d1fdb9521a47eaaf798eac391af88a3d282425d 100644 (file)
@@ -34,13 +34,7 @@ void TransmissionChecksumValidator::setChecksumType( const QByteArray& type )
     _checksumType = type;
 }
 
-QString TransmissionChecksumValidator::checksumType()
-{
-    return _checksumType;
-}
-
-
-void TransmissionChecksumValidator::uploadValidation( SyncFileItem *item )
+QString TransmissionChecksumValidator::checksumType() const
 {
     QString checksumType = _checksumType;
     if( checksumType.isEmpty() ) {
@@ -48,26 +42,34 @@ void TransmissionChecksumValidator::uploadValidation( SyncFileItem *item )
         checksumType = cfg.transmissionChecksum();
     }
 
-    if( checksumType.isEmpty() || !item ) {
+    return checksumType;
+}
+
+void TransmissionChecksumValidator::uploadValidation( SyncFileItem *item )
+{
+    const QString csType = checksumType();
+
+    if( csType.isEmpty() || !item ) {
         // if there is no checksum defined, continue to upload
         emit validated();
     } else {
         _item = item;
         // Calculate the checksum in a different thread first.
+
         connect( &_watcher, SIGNAL(finished()),
                  this, SLOT(slotUploadChecksumCalculated()));
-        if( checksumType == checkSumMD5C ) {
+        if( csType == checkSumMD5C ) {
             item->_checksum = checkSumMD5C;
             item->_checksum += ":";
             _watcher.setFuture(QtConcurrent::run(FileSystem::calcMd5, _filePath));
 
-        } else if( checksumType == checkSumSHA1C ) {
+        } else if( csType == checkSumSHA1C ) {
             item->_checksum = checkSumSHA1C;
             item->_checksum += ":";
             _watcher.setFuture(QtConcurrent::run( FileSystem::calcSha1, _filePath));
         }
 #ifdef ZLIB_FOUND
-        else if( checksumType == checkSumAdlerC) {
+        else if( csType == checkSumAdlerC) {
             item->_checksum = checkSumAdlerC;
             item->_checksum += ":";
             _watcher.setFuture(QtConcurrent::run(FileSystem::calcAdler32, _filePath));