Enable RVO (return value optimization).

Signed-off-by: Camila Ayres <hello@camilasan.com>

diff --git a/src/libsync/configfile.cpp b/src/libsync/configfile.cpp
index 01e8df7af97357a7dba17bbac6702a115adced88..59629f91caec08f0a57e40d3221be460dfa6af31 100644 (file)
--- a/src/libsync/configfile.cpp
+++ b/src/libsync/configfile.cpp
@@ -705,14 +705,15 @@ QString ConfigFile::defaultUpdateChannel() const
 
 QString ConfigFile::currentUpdateChannel() const
 {
+    auto updateChannel = defaultUpdateChannel();
     QSettings settings(configFile(), QSettings::IniFormat);
-    if (const auto configUpdateChannel = settings.value(QLatin1String(updateChannelC), defaultUpdateChannel()).toString();
+    if (const auto configUpdateChannel = settings.value(QLatin1String(updateChannelC), updateChannel).toString();
         validUpdateChannels().contains(configUpdateChannel)) {
         qCWarning(lcConfigFile()) << "Config file has a valid update channel:" << configUpdateChannel;
-        return configUpdateChannel;
+        updateChannel = configUpdateChannel;
     }
 
-    return defaultUpdateChannel();
+    return updateChannel;
 }
 
 void ConfigFile::setUpdateChannel(const QString &channel)