gdk/x11: Do not set PPosition hint

It is good practice for (floating) window managers to respect explicit
position hints from clients (as long as the window wouldn't end up
off-screen etc.).

Before commit 13d3afa56e9, GTK had a flag for setting the PPosition hint,
but now does so unconditionally. However the real intention is to *not*
request a fixed position, so don't do that.

diff --git a/gdk/x11/gdksurface-x11.c b/gdk/x11/gdksurface-x11.c
index e4952f2c7b164591b308093ff57d3f1984c0c544..11e6fc769bbcc6a28637afa5b053f46055b06250 100644 (file)
--- a/gdk/x11/gdksurface-x11.c
+++ b/gdk/x11/gdksurface-x11.c
@@ -2445,14 +2445,6 @@ gdk_x11_surface_set_geometry_hints (GdkSurface         *surface,
     }
   
   size_hints.flags = 0;
-  
-  size_hints.flags |= PPosition;
-  /* We need to initialize the following obsolete fields because KWM 
-   * apparently uses these fields if they are non-zero.
-   * #@#!#!$!.
-   */
-  size_hints.x = 0;
-  size_hints.y = 0;
 
   if (geom_mask & GDK_HINT_MIN_SIZE)
     {